From: Michael Walle <michael@walle.cc>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: pratyush@kernel.org, miquel.raynal@bootlin.com, richard@nod.at,
jaimeliao@mxic.com.tw, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] mtd: spi-nor: drop superfluous debug prints
Date: Mon, 18 Dec 2023 13:14:52 +0100 [thread overview]
Message-ID: <7d80cc0afe33ee9a9f660b6876b69e81@walle.cc> (raw)
In-Reply-To: <20231215082138.16063-5-tudor.ambarus@linaro.org>
Am 2023-12-15 09:21, schrieb Tudor Ambarus:
> The mtd data hall be obtained with the mtd ioctls or with new debugs
shall, debugfs
> entries if one cares. Drop the debug prints.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
With the above and the unused variables fixed:
Reviewed-by: Michael Walle <michael@walle.cc>
Miquel raised a valid point that if the rootfs is on this very
flash and if there is an error, you cannot use debugfs or the
ioctls. But I doubt that the info about the erase regions will
help much in that case.
-michael
next prev parent reply other threads:[~2023-12-18 12:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 8:21 [PATCH 0/4] mtd: spi-nor: mark the flash name as obsolete Tudor Ambarus
2023-12-15 8:21 ` [PATCH 1/4] mtd: spi-nor: print flash ID instead of name Tudor Ambarus
2023-12-18 12:07 ` Michael Walle
2024-01-29 13:12 ` Pratyush Yadav
2023-12-15 8:21 ` [PATCH 2/4] mtd: spi-nor: mark the flash name as obsolete Tudor Ambarus
2023-12-18 12:08 ` Michael Walle
2024-01-29 13:13 ` Pratyush Yadav
2023-12-15 8:21 ` [PATCH 3/4] mtd: spi-nor: sysfs: hide the flash name if not set Tudor Ambarus
2023-12-18 12:11 ` Michael Walle
2024-01-29 13:24 ` Pratyush Yadav
2023-12-15 8:21 ` [PATCH 4/4] mtd: spi-nor: drop superfluous debug prints Tudor Ambarus
2023-12-15 8:24 ` Tudor Ambarus
2024-01-29 13:26 ` Pratyush Yadav
2024-01-29 13:27 ` Tudor Ambarus
2024-01-29 13:34 ` Pratyush Yadav
2023-12-18 12:14 ` Michael Walle [this message]
2023-12-19 2:47 ` [PATCH 0/4] mtd: spi-nor: mark the flash name as obsolete Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d80cc0afe33ee9a9f660b6876b69e81@walle.cc \
--to=michael@walle.cc \
--cc=jaimeliao@mxic.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=tudor.ambarus@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®