From: Jorge Ramirez <jorge.ramirez-ortiz@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
khasim.mohammed@linaro.org
Subject: Re: [PATCH] regulator: core: do not report EPROBE_DEFER as error.
Date: Wed, 17 Apr 2019 19:05:52 +0200 [thread overview]
Message-ID: <7d84d820-c3e9-16cb-b5b7-31761589d4ec@linaro.org> (raw)
In-Reply-To: <20190417154638.GC5703@sirena.org.uk>
On 4/17/19 17:46, Mark Brown wrote:
> On Wed, Apr 17, 2019 at 10:54:11AM +0200, Jorge Ramirez-Ortiz wrote:
>> Do not log a temporary failure to get a regulator (EPROBE_DEFER) while
>> the driver is requesting retries.
>
>> - dev_err(dev, "Failed to get supply '%s': %d\n",
>> - consumers[i].supply, ret);
>> + if (ret != -EPROBE_DEFER)
>> + dev_err(dev, "Failed to get supply '%s': %d\n",
>> + consumers[i].supply, ret);
>
> Please leave at least a debug log in place, it's not good to just
> silently fail - even if we will retry someone might still need some help
> debugging (eg, figuring out that they need to enable whatever driver is
> providing the supply in their config) so we should tell them why we're
> deferring.
you mean replacing dev_err with dev_dbg on all cases or only on defer
leaving dev_err on the rest?
>
> BTW does an e-mail address need updating somewhere here?
>
dont know, whose email? I got these from get_maintainer.pl (below); or
are you referring to mine (in which case it is correct, I am back at
least for a bit longer)
Liam Girdwood <lgirdwood@gmail.com> (supporter:VOLTAGE AND CURRENT
REGULATOR FRAMEWORK)
Mark Brown <broonie@kernel.org> (supporter:VOLTAGE AND CURRENT REGULATOR
FRAMEWORK)
linux-kernel@vger.kernel.org (open list:VOLTAGE AND CURRENT REGULATOR
FRAMEWORK)
next prev parent reply other threads:[~2019-04-17 17:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 8:54 Jorge Ramirez-Ortiz
2019-04-17 15:46 ` Mark Brown
2019-04-17 17:05 ` Jorge Ramirez [this message]
2019-04-17 17:30 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d84d820-c3e9-16cb-b5b7-31761589d4ec@linaro.org \
--to=jorge.ramirez-ortiz@linaro.org \
--cc=broonie@kernel.org \
--cc=khasim.mohammed@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®