From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-2836235-1516673323-2-15997899736173242163 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no ("Email failed DMARC policy for domain") X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, FREEMAIL_FORGED_FROMDOMAIN 0.25, FREEMAIL_FROM 0.001, HEADER_FROM_DIFFERENT_DOMAINS 0.25, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org' X-Spam-charsets: plain='utf-8' X-IgnoreVacation: yes ("Email failed DMARC policy for domain") X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: linux-usb-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516673323; b=sz0wdLeDiapOUSHzOhP2bvMmSX2KKAwA44vBdWYZJWXgBM9 wyR983XCEKPNJM9miXwSD4SNmYnyaAQo5g+pV9ksswdL7Ai9BmBM5/zo7TJZrPvk aF+VjS7LbpW60B9asJW7oV++tWf/MuACg07RiekT/gKqG0PebKOPOeDHsuMAesnb CMoJTZ4+oK6XWU3wnCO9YAM9fi2cnO8Em/+YHvOC4avZJOLIzIdiIMHwNK0Sa415 3LD//Kj1R5EnvT0O0wbnZj2qC5DVc2iusmyeSeSA4e7vemSf2kQwzafr24hnIFat 6diSces52eRNHUXPmEhoeWsOj/xxuWpddYrgb0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=subject:to:cc:references:from:message-id :date:mime-version:in-reply-to:content-type :content-transfer-encoding:sender:list-id; s=arctest; t= 1516673323; bh=qg3nCZguhf/0/Q9oauvugkXzPQNPRr11WwU09Bqb+/E=; b=d PrLDEDYfK4hOPl4kM1h5MOnopz0rXKw9ecbgeblhN3smJnSlWmlAkXoQ2Cl+4t/a uXSvBwMamMjS/eYwSaOeVMGSwX++AYUJZBxZjQ/mfeFfxpvva9FTXWEJenIg3IwP Lrs4cqRjyjwSXz0DbJ0RJspRvajMq1evgnSI25X86WGiktr0Vem099htjsDtfWgz XunanzZG/zWzchzILSR9jAwA0umPHfkhLSWFs8QkdsCc9hM2+i8dpxm4K3QOV+0S lDQs4NIbVG7g1+JRCFOGWtMxaZGy0U4MLBxtvdBoUm8UppUL3RGEXe2I1916ibCB TAoM6EmLfD5sPYzWdcyHA== ARC-Authentication-Results: i=1; mx3.messagingengine.com; arc=none (no signatures found); dkim=fail (body has been altered; 2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=e5KDym2o x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=fail (p=none,has-list-id=yes,d=none) header.from=gmail.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-google-dkim=fail (body has been altered; 2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=QXilpOMZ; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=gmail.com header.result=pass header_is_org_domain=yes Authentication-Results: mx3.messagingengine.com; arc=none (no signatures found); dkim=fail (body has been altered; 2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=e5KDym2o x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=fail (p=none,has-list-id=yes,d=none) header.from=gmail.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-google-dkim=fail (body has been altered; 2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=QXilpOMZ; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=gmail.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751140AbeAWCI1 (ORCPT ); Mon, 22 Jan 2018 21:08:27 -0500 Received: from mail-pf0-f169.google.com ([209.85.192.169]:46597 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751077AbeAWCI0 (ORCPT ); Mon, 22 Jan 2018 21:08:26 -0500 X-Google-Smtp-Source: AH8x2253OtWLDFI709Rax++03qPt6v+BUZJO97Fk0q/YCfgS9mD+1dqeFZTBLc3DdcvjsLoKCZ+40w== Subject: Re: [PATCH 2/5] USB: serial: f81232: add high baud rate support To: Andy Shevchenko , Johan Hovold Cc: Greg Kroah-Hartman , USB , Linux Kernel Mailing List , Peter H , "Ji-Ze Hong (Peter Hong)" References: <1516607927-8887-1-git-send-email-hpeter+linux_kernel@gmail.com> <1516607927-8887-2-git-send-email-hpeter+linux_kernel@gmail.com> From: "Ji-Ze Hong (Peter Hong)" Message-ID: <7d8c1ff5-06fa-28f3-c5e8-3211497a6b17@gmail.com> Date: Tue, 23 Jan 2018 10:08:24 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-usb-owner@vger.kernel.org X-Mailing-List: linux-usb@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Hi Andy, Andy Shevchenko 於 2018/1/22 下午 10:55 寫道: > On Mon, Jan 22, 2018 at 9:58 AM, Ji-Ze Hong (Peter Hong) > wrote: >> The F81232 had 4 clocksource 1.846/18.46/14.77/24MHz and baud rates >> can be up to 1.5Mbits with 24MHz. >> >> F81232 Clock registers (106h) >> >> Bit1-0: Clock source selector >> 00: 1.846MHz. >> 01: 18.46MHz. >> 10: 24MHz. >> 11: 14.77MHz. > > Hmm... Why not to provide a proper clk driver (based on table variant > of clk-divider) and use it here? > > It seems too complex to use clock framework in this driver. What do you think about this, Johan ? Thanks -- With Best Regards, Peter Hong