From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98934C433E7 for ; Wed, 14 Oct 2020 18:35:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D4F02222C for ; Wed, 14 Oct 2020 18:35:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388854AbgJNSf3 (ORCPT ); Wed, 14 Oct 2020 14:35:29 -0400 Received: from smtprelay0100.hostedemail.com ([216.40.44.100]:48380 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2388112AbgJNSf2 (ORCPT ); Wed, 14 Oct 2020 14:35:28 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id E8CC6702; Wed, 14 Oct 2020 18:35:27 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: paper27_54145cd2720e X-Filterd-Recvd-Size: 2366 Received: from XPS-9350 (cpe-72-134-80-165.natsow.res.rr.com [72.134.80.165]) (Authenticated sender: joe@perches.com) by omf06.hostedemail.com (Postfix) with ESMTPA; Wed, 14 Oct 2020 18:35:26 +0000 (UTC) Message-ID: <7d8c7d80aa7b0524cca49a6dfe24e878bea6ab12.camel@perches.com> Subject: Re: [PATCH v2] checkpatch: add new exception to repeated word check From: Joe Perches To: Dwaipayan Ray Cc: linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel@vger.kernel.org, lukas.bulwahn@gmail.com Date: Wed, 14 Oct 2020 11:35:25 -0700 In-Reply-To: References: <20201014163738.117332-1-dwaipayanray1@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-10-14 at 23:42 +0530, Dwaipayan Ray wrote: > On Wed, Oct 14, 2020 at 11:33 PM Joe Perches wrote: > > On Wed, 2020-10-14 at 22:07 +0530, Dwaipayan Ray wrote: > > > Recently, commit 4f6ad8aa1eac ("checkpatch: move repeated word test") > > > moved the repeated word test to check for more file types. But after > > > this, if checkpatch.pl is run on MAINTAINERS, it generates several > > > new warnings of the type: > > > > Perhaps instead of adding more content checks so that > > word boundaries are not something like \S but also > > not punctuation so that content like > > > > git git:// > > @size size > > > > does not match? > > > > > Hi, > So currently the words are trimmed of non alphabets before the check: > > while ($rawline =~ /\b($word_pattern) (?=($word_pattern))/g) { > my $first = $1; > my $second = $2; > > where, the word_pattern is: > my $word_pattern = '\b[A-Z]?[a-z]{2,}\b'; I'm familiar. > So do you perhaps recommend modifying this word pattern to > include the punctuation as well rather than trimming them off? Not really, perhaps use the capture group position markers @- @+ or $-[1] $+[1] and $-[2] $+[2] with the substr could be used to see what characters are before and after the word matches. > > Thanks, > Dwaipayan.