From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f53.google.com (mail-oa1-f53.google.com [209.85.160.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40B641CEACB for ; Wed, 30 Apr 2025 18:46:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746038808; cv=none; b=WXguvjDOxPzayGkYozOHBgjmeRhKc5+zUuF0oli9s0dHryJ+mpGBgWEzX/k7zAPdtW4xxZa5M8eoV1ao7UvG50DUkLblnmpUTLumPFoLr0x29G9+qaB/Weo2J2UD8EO3Mbhf/Kyoitj5OuxQTmZnfjz+uJjbKlfGIpX3rUr8jgg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746038808; c=relaxed/simple; bh=Tjt7SVaTlOlpBRH6eoevRK63rsFx7sHHtqzp+HITOvU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NUf1m1IhpWTfli2hLU5xrKJbSDsqVJcdkPv1DtBaJxs7Nhe052OH+XLxf9bHHtH6YrGPSq3+DIYCDIUGPpQJU34pwZ0llgFZYiYbENoxAu7LrODZPmtgr3mOubq/Ec/so5aTYmOSeqbRFdRYz7SmPlYWd+X+xhyAxg+julnsOH4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=DXDdvIMN; arc=none smtp.client-ip=209.85.160.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="DXDdvIMN" Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-2c2bb447e5eso139651fac.0 for ; Wed, 30 Apr 2025 11:46:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1746038805; x=1746643605; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RXxYKFdvPhnv+i2OQnjVQIRhugvl2GuR0kkHgiv5OW4=; b=DXDdvIMNL7KSK9YwgOALkU4pQzb+iWP+LL7DW5mTrJiAVJw0EM6HDgSpmxrl0hxXiU NMCy65C6W2EdqMHXGB1PIX+INDdzfTUSKxKWrUz9oaq19SN3caF94BIg3a9r3FepBeVd tv+VEuTdsqERsnnPrX4RSKmykOSEx8BcI8wnL1gPEImTvmzK/sF/fFR8RBD1HiUupgDF vl/8XDBVESobOrNd9sm8X1zeAJU6ijgUVHud0qgd4uGdxoULauxE2t5d98p6erIq0rhu DceZg3xT23Sv39lidSNM4UrkJzheUpqX9yk6udhN1HDKqDA8lDw5RK17b5WyQuAMsjg+ SDQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746038805; x=1746643605; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RXxYKFdvPhnv+i2OQnjVQIRhugvl2GuR0kkHgiv5OW4=; b=H6w/upEZRQYcB52PNM2OfJf0EFJrTGf8FOsWOiiOx0oNYx9H/1QZQxeZIrVtjcMBZ4 qWE/LOuM9rQMfGTub4OOofntd1ux00b6y0WsVpcMG2Y8VHPoLcMrJyB/x32tHXuwOsPC +aOLIhRjMoRvSjNJRbJq/iyH+DSWMvG2eymjvYq4JHeZ9BD6Nfm3CWV3FaBdXnJnWMmg YjmaqhBpaIM7S8E7PP9DEZfCq81So9xJGLmJPPhVJFvK/ycRPVAqD9j1fYSQvcPGVqop WhyIaX3YDL719VAiWnxRa+9rJTc+DAy0CVIKQ56823xp1seUw4FV6stWmiCFsGXHB9Qo Gm8g== X-Forwarded-Encrypted: i=1; AJvYcCVQbtinopJaji3tsvbSZHkkPGb+3TEwXEmPTdz8mOFEULcbJCbtWcnvFZUl0iJUCkrmJToK8g6tx91hf3M=@vger.kernel.org X-Gm-Message-State: AOJu0YxN0T0Gz2c5Ts2iVSEsPLt74jKmY/aiI3rwibk5hFU8hZacc/xW 6dh40+j6LciYfGjuFbAxd6dvOqAtNA9bkbokM2IR6tdrMQH6rdW9q+05E5JIb8A= X-Gm-Gg: ASbGncus1EGlAlMRm7bGhS715zmfPCVNFZLfsp/syrjmoSA2nU5bvms7LqCgyfRpNwU 3T+uINSoTFaKDOj8/r6TuYFaOfzaoIDzRx4BVYDWJn/GwqoAlzfnBuQ/8qgwMadfqVuJ6jyE15h K/y4dZS4tq8BhXVTX/Lsd5yOopL8JAgaRKvWasgFUAImwe0hWZANkX7vvBWFcW3DVhbiSNQTzm7 reMYfkCwfOjdb/CZ1oU+5SRWVKzcHIV5DsFz9C+jY4joIEREtv0PnSQfImQDkxM/FyTTcSa484r j0QOdfb7svY+JymH+pVSXYQrV1qZg3Xt9Nxm9uTkAKwozpxVfWWhnE0b3P13E8s+aJ6fexV7j4N XNFJjpeuhzRN5fkidgvkCaniGYQ== X-Google-Smtp-Source: AGHT+IFPQcd2cZ+lppyTbrPKR3yE2CUjnINt9qXLSF2VkkLMNJ220iqVNXLIMGAHI/5Kafk9Ar//nQ== X-Received: by 2002:a05:6870:8315:b0:2c1:9897:dd24 with SMTP id 586e51a60fabf-2da8c82f967mr227133fac.35.1746038805290; Wed, 30 Apr 2025 11:46:45 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:1d00:359a:f1e:f988:206a? ([2600:8803:e7e4:1d00:359a:f1e:f988:206a]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2da6e4f7cccsm577231fac.33.2025.04.30.11.46.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Apr 2025 11:46:44 -0700 (PDT) Message-ID: <7d93075f-8426-45f1-8c7d-3c3c904a859a@baylibre.com> Date: Wed, 30 Apr 2025 13:46:43 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 02/11] dt-bindings: iio: adc: ad7768-1: add trigger-sources property To: Jonathan Santos , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Cc: andy@kernel.org, nuno.sa@analog.com, Michael.Hennerich@analog.com, marcelo.schmitt@analog.com, jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, marcelo.schmitt1@gmail.com, linus.walleij@linaro.org, brgl@bgdev.pl, lgirdwood@gmail.com, broonie@kernel.org, jonath4nns@gmail.com References: <128de2793d6d5424ad152c394faf1d51f0d56e0b.1745605382.git.Jonathan.Santos@analog.com> From: David Lechner Content-Language: en-US In-Reply-To: <128de2793d6d5424ad152c394faf1d51f0d56e0b.1745605382.git.Jonathan.Santos@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/27/25 7:12 PM, Jonathan Santos wrote: > In addition to GPIO synchronization, The AD7768-1 also supports > synchronization over SPI, which use is recommended when the GPIO > cannot provide a pulse synchronous with the base MCLK signal. It > consists of looping back the SYNC_OUT to the SYNC_IN pin and send > a command via SPI to trigger the synchronization. > > Introduce the 'trigger-sources' property to enable SPI-based > synchronization via SYNC_OUT pin, along with additional optional > entries for GPIO3 and DRDY pins. > > Also create #trigger-source-cells property to differentiate the trigger > sources provided by the ADC. To improve readability, create a > adi,ad7768-1.h header with the macros for the cell values. > > While at it, add description to the interrupts property. > > Signed-off-by: Jonathan Santos > --- ... > --- > .../bindings/iio/adc/adi,ad7768-1.yaml | 31 ++++++++++++++++++- > include/dt-bindings/iio/adc/adi,ad7768-1.h | 10 ++++++ > 2 files changed, 40 insertions(+), 1 deletion(-) > create mode 100644 include/dt-bindings/iio/adc/adi,ad7768-1.h We should add this new file to the MAINTAINERS entry. Otherwise: Reviewed-by: David Lechner