From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F316ACA0FE2 for ; Tue, 5 Sep 2023 16:22:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343717AbjIEQVw (ORCPT ); Tue, 5 Sep 2023 12:21:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353925AbjIEIiJ (ORCPT ); Tue, 5 Sep 2023 04:38:09 -0400 Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 233FECC7; Tue, 5 Sep 2023 01:38:06 -0700 (PDT) Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 3858btVg033569; Tue, 5 Sep 2023 03:37:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1693903076; bh=3WVgG6BMp/zwJvv4wo1Z0C7SZxs1AezUj/xUd/fKN/A=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=WPd62J44Z+/CQLoig0RFiF9f3DHXTKQ1+PjYfmmfFsd4TYQJaw/ElX9D0Dx1NEYP8 VbEbdigxCP8zRurDOTKZ0I/dBTeQ3IfMH/oRn7+6JghdccRg9RcK6PjmYfOLTPtK7B iBH59/BYLWx08qkjJuYX1P9AO4MDsSyFbwWJKAm4= Received: from DLEE109.ent.ti.com (dlee109.ent.ti.com [157.170.170.41]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 3858bt6M114883 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 5 Sep 2023 03:37:55 -0500 Received: from DLEE102.ent.ti.com (157.170.170.32) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 5 Sep 2023 03:37:55 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 5 Sep 2023 03:37:55 -0500 Received: from [10.24.69.199] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 3858bnn7009695; Tue, 5 Sep 2023 03:37:50 -0500 Message-ID: <7d957d85-b32e-c2b9-11df-4f0f86a5dc8c@ti.com> Date: Tue, 5 Sep 2023 14:07:49 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [RFC PATCH net-next 4/4] net: ti: icssg_prueth: add TAPRIO offload support Content-Language: en-US To: Andrew Lunn CC: Simon Horman , Roger Quadros , Vignesh Raghavendra , Jacob Keller , Richard Cochran , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , , , , References: <20230830110847.1219515-1-danishanwar@ti.com> <20230830110847.1219515-5-danishanwar@ti.com> From: MD Danish Anwar In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/09/23 19:42, Andrew Lunn wrote: >> +void icssg_qos_init(struct net_device *ndev) >> +{ >> + icssg_qos_tas_init(ndev); >> + >> + /* IET init goes here */ >> +} > > This sees like a TODO? > > Andrew It's actually a TODO only. IET support will come in later patches. I will drop this comment from here. -- Thanks and Regards, Danish