From: David Laight <David.Laight@ACULAB.COM>
To: 'Tong Zhang' <ztong0001@gmail.com>,
Anders Larsen <al@alarsen.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3] qnx4: qnx4_block_map error handling
Date: Tue, 3 Nov 2020 10:54:02 +0000 [thread overview]
Message-ID: <7d978bf40c5845e8b89a740250ba958a@AcuMS.aculab.com> (raw)
In-Reply-To: <20201102231420.1833852-1-ztong0001@gmail.com>
From: Tong Zhang
> Sent: 02 November 2020 23:14
>
> qnx4_block_map() may return -EIO on funny qnx4 fs image, in this case do
> not interpret -EIO as a correct block number
That commit message is now wrong.
Also 'blknum' is only 'unsigned long' so ~0ull is wrong.
It can be worth injecting an error and checking the error
propagation works.
What is the actual maximum file size?
Is there actually an 'out of range' blknum value
that can be used to signify an error without
changing the return value to 'long long'.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2020-11-03 10:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 21:16 [PATCH] qnx4: do not interpret -EIO as a correct address Tong Zhang
2020-11-02 9:12 ` Anders Larsen
2020-11-02 20:15 ` [PATCH v2] " Tong Zhang
2020-11-02 22:44 ` David Laight
2020-11-02 23:14 ` [PATCH v3] qnx4: qnx4_block_map error handling Tong Zhang
2020-11-03 10:54 ` David Laight [this message]
2020-11-03 13:52 ` Tong Zhang
2020-11-03 21:57 ` David Laight
2020-11-03 22:32 ` Tong Zhang
2020-11-11 1:33 ` Tong Zhang
2020-11-03 17:35 ` [PATCH v4] " Tong Zhang
2020-11-02 23:17 ` [PATCH v2] qnx4: do not interpret -EIO as a correct address Tong Zhang
2020-11-02 20:17 ` [PATCH] " Tong Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d978bf40c5845e8b89a740250ba958a@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=al@alarsen.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ztong0001@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®