From: "Arnd Bergmann" <arnd@arndb.de>
To: "Köry Maincent" <kory.maincent@bootlin.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com,
"Russell King" <linux@armlinux.org.uk>,
"Gregory Clement" <gregory.clement@bootlin.com>,
"Sudeep Holla" <sudeep.holla@arm.com>,
"Alexandre Ghiti" <alexandre.ghiti@canonical.com>
Subject: Re: [PATCH 3/6] arm: configs: spear6xx: Enable PL110 display controller
Date: Wed, 19 Oct 2022 15:52:12 +0200 [thread overview]
Message-ID: <7d97c52d-9917-4b3b-8ad2-7243566ae582@app.fastmail.com> (raw)
In-Reply-To: <20221019154841.1cb2a15a@kmaincent-XPS-13-7390>
On Wed, Oct 19, 2022, at 15:48, Köry Maincent wrote:
> Hello Krzysztof,
>
> On Wed, 19 Oct 2022 09:38:45 -0400
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
>
>> On 19/10/2022 09:32, Köry Maincent wrote:
>> > From: Kory Maincent <kory.maincent@bootlin.com>
>> >
>> > Enable the PL110 DRM driver, used by the spear600.
>> >
>> > CONFIG_I2C is dropped from the defconfig as it is selected by CONFIG_DRM.
>>
>> I2C as a user-selectable option should stay. Don't remove such
>> (user-selectable) top-level options just because something else selected it.
>
> As the CONFIG_DRM selects it, the "make savedefconfig" removes it by default.
> Why keeping something that is already automatically enabled by CONFIG_DRM?
It's something that DRM probably should not select, so if this
ever gets fixed in DRM, you get a broken build. Just leaving
the line in there is harmless.
Arnd
next prev parent reply other threads:[~2022-10-19 14:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221019133208.319626-1-kory.maincent@bootlin.com>
2022-10-19 13:32 ` [PATCH 1/6] arm: configs: spear6xx: Refresh defconfig Köry Maincent
2022-10-19 13:32 ` [PATCH 2/6] arm: dts: spear600: Fix clcd interrupt Köry Maincent
2022-10-20 4:35 ` Viresh Kumar
2022-10-19 13:32 ` [PATCH 3/6] arm: configs: spear6xx: Enable PL110 display controller Köry Maincent
2022-10-19 13:38 ` Krzysztof Kozlowski
2022-10-19 13:48 ` Köry Maincent
2022-10-19 13:52 ` Arnd Bergmann [this message]
2022-10-19 13:57 ` Krzysztof Kozlowski
2022-10-19 14:05 ` Köry Maincent
2022-10-19 13:32 ` [PATCH 4/6] clk: spear: Fix CLCD clock definition on SPEAr600 Köry Maincent
2022-10-20 4:36 ` Viresh Kumar
[not found] ` <20221028002149.A6573C433D6@smtp.kernel.org>
2022-11-02 8:33 ` Köry Maincent
2022-10-19 13:32 ` [PATCH 5/6] arm: dts: spear600: Add ssp controller nodes Köry Maincent
2022-10-20 4:36 ` Viresh Kumar
2022-10-19 13:32 ` [PATCH 6/6] clk: spear: Fix SSP clock definition on SPEAr600 Köry Maincent
2022-10-20 4:33 ` Viresh Kumar
[not found] ` <20221028002219.6AEEEC43470@smtp.kernel.org>
2022-11-02 8:32 ` Köry Maincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d97c52d-9917-4b3b-8ad2-7243566ae582@app.fastmail.com \
--to=arnd@arndb.de \
--cc=alexandre.ghiti@canonical.com \
--cc=gregory.clement@bootlin.com \
--cc=kory.maincent@bootlin.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=sudeep.holla@arm.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®