Re: [PATCH] sched_ext: Add trace point to track sched_ext core events

[Changwoo Min <changwoo@igalia.com>]

Hi Tejun,

On 25. 2. 27. 03:51, Tejun Heo wrote:
> Hello,
> 
> On Wed, Feb 26, 2025 at 11:33:27PM +0900, Changwoo Min wrote:
>> Add tracing support, which may be useful for debugging sched_ext schedulers
>> that trigger a certain event.
>>
>> Signed-off-by: Changwoo Min <changwoo@igalia.com>
>> ---
>>   include/trace/events/sched_ext.h | 21 +++++++++++++++++++++
>>   kernel/sched/ext.c               |  4 ++++
>>   2 files changed, 25 insertions(+)
>>
>> diff --git a/include/trace/events/sched_ext.h b/include/trace/events/sched_ext.h
>> index fe19da7315a9..88527b9316de 100644
>> --- a/include/trace/events/sched_ext.h
>> +++ b/include/trace/events/sched_ext.h
>> @@ -26,6 +26,27 @@ TRACE_EVENT(sched_ext_dump,
>>   	)
>>   );
>>   
>> +TRACE_EVENT(sched_ext_add_event,
>> +	    TP_PROTO(const char *name, int offset, __u64 added),
>> +	    TP_ARGS(name, offset, added),
> 
> Can we do sched_ext_event with @delta? Otherwise, looks fine to me.
Sure, @delta is clearer. I will change it as suggested.

Regards,
Changwoo Min