From: Markus Elfring <Markus.Elfring@web.de>
To: Shuhao Fu <sfual@cse.ust.hk>,
linux-fsdevel@vger.kernel.org,
Namjae Jeon <linkinjeon@kernel.org>,
Sungjong Seo <sj1557.seo@samsung.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Yuezhang Mo <yuezhang.mo@sony.com>
Subject: Re: [PATCH v2] exfat: fix refcount leak in exfat_find
Date: Tue, 21 Oct 2025 11:20:59 +0200 [thread overview]
Message-ID: <7d9a7fa8-4121-4239-8f5f-fb4268e148bd@web.de> (raw)
In-Reply-To: <aPdHWFiCupwDRiFM@osx.local>
…
> Function `exfat_get_dentry_set` would increase the reference counter of
> `es->bh` on success. Therefore, `exfat_put_dentry_set` must be called
> after `exfat_get_dentry_set` to ensure refcount consistency. This patch
> relocate two checks to avoid possible leaks.
…
* Would it be preferred to refer to the term “reference count” in consistent ways?
* I see possibilities to improve such a change description another bit.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.18-rc1#n94
Regards,
Markus
next prev parent reply other threads:[~2025-10-21 9:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 8:42 Shuhao Fu
2025-10-21 9:20 ` Markus Elfring [this message]
2025-10-22 4:55 ` Yuezhang.Mo
2025-10-22 5:41 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d9a7fa8-4121-4239-8f5f-fb4268e148bd@web.de \
--to=markus.elfring@web.de \
--cc=linkinjeon@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfual@cse.ust.hk \
--cc=sj1557.seo@samsung.com \
--cc=yuezhang.mo@sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®