From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8779D36C597 for ; Tue, 3 Feb 2026 20:18:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770149927; cv=none; b=SiOp8E5KfHktO5EeRjpxVazewMFNnCAoFgcN4mOKfDosXgDiu7lyuy2mfmu+zsXE7B6WveSvAqMrR3hCWBNEIsaYNGELthjeGpBRA7q0CVaUNMMeVSMR02gfVqTWVnu00wQXwk3lKuyXn/FyBiyye9C/5EqYj7mszn9TG4Dk+Ns= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770149927; c=relaxed/simple; bh=sIn0+PpHeGwl59t8r9yhm3iiMAcqZDGGOJQU4O0rpAs=; h=From:Message-ID:Date:MIME-Version:Subject:To:Cc:References: In-Reply-To:Content-Type; b=XUNZrQPYCxwdImiws3w1CT2K96NWgnWwG198ZZ8XmvS2sTkmbs/XdGWow4PZFS0zPZCePO7R2lH/QjJYV+92GujsHV2ukmzcmMkno0E7J1ibPlaJxU3nTw7ZLF0Jss7rA33C5HxI8/NG9cayjwTaz48Xr7a8m6zjqi6fYojRb2c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=U3/7EM+4; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=c85p+MH+; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="U3/7EM+4"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="c85p+MH+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770149924; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mOgtVFt2QSNKNnhhkPHuppGUAy5MYL9zrORdrlUpHd8=; b=U3/7EM+48OYWv6qnxjm6YbJGpCAROD5AMVp6JYvwBtncGZYbZ+g2HifYOFJjkpXQixkzw8 pGGTSfd8mCF7mRU6DY08Be00363GNwpKMmL44lf851o/0fLiBcN0sVdxxxfvZFHvQibZpV i/9u0NsszdBCHaIsK1MVc8qJeu/vlW8= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-319-DkeNbB9_M5GWOv4bJ6eqRA-1; Tue, 03 Feb 2026 15:18:43 -0500 X-MC-Unique: DkeNbB9_M5GWOv4bJ6eqRA-1 X-Mimecast-MFC-AGG-ID: DkeNbB9_M5GWOv4bJ6eqRA_1770149923 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8c70e610242so1641673185a.2 for ; Tue, 03 Feb 2026 12:18:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1770149922; x=1770754722; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:from:to :cc:subject:date:message-id:reply-to; bh=mOgtVFt2QSNKNnhhkPHuppGUAy5MYL9zrORdrlUpHd8=; b=c85p+MH+qdXN42MK0edsLHEArKwM98GQNhQsyFf+uZLucaCz8H/8sHyT6Z1T8hU7DW YE2rT9KNQD8gOAKCyaCEk7HuXeEnGi4+SzNJZpTmDUjkhWVXVOoLxsEebsvoEzux+h3n Htri7SHsRUYJ/T54VP/rGTMyZviru0Mv24b7xBLvmk0gtFtuMpG+vwHzBI74pYLbvyRH hQsQdHBTfukvZ86PfxrvG+06tJBYHFwCeCg8hIHqn3Twwb2mVSN8CaTnXtqyJh5YqBZj 6PExpDUS1n9l56arKQGwPW5itNInaMOK+dTvrtAA6CLMDxqnskMj4/hjCXfzBfRIY17n 0LXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770149922; x=1770754722; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mOgtVFt2QSNKNnhhkPHuppGUAy5MYL9zrORdrlUpHd8=; b=cbPp/bUXFhAAKysBXZ6xGTX0PuT60LU8wr9OYKfWE1T45z7kgnJg0TKivlFK4QS8ZO 0ySRxyVwzCgZocb/gIg3DIaL+hhxlWIuJ/HT57nM/OXPinbxo3VP5TeUnleiZduE/j2A iwtEKPU3NmRc6VNPtrGRsdcR7GDu1CtUetFeEMSh9th4p1z/E7rY+f+sO9nzUQajdCEV N+36/02CzNYU4lxLVT+qfZ84/Js0Ho00HWF/rvHdc6MItXwd/cKwiwgVc8b1hxyDYicG Xfusgj3/2dy78vsPNKvNSJ9XMUwu7zIV+woeTEzKL/dSpqx8nmb+R1CiVCjXILEkjl11 ZMAw== X-Forwarded-Encrypted: i=1; AJvYcCVjoy6UoFToadNFYUOVZWFYJGxx+WmCl44irN9IzhA1hxlm5vhu3Db+VgnacX1GhIJSYGDZ9NNUu5r6DVA=@vger.kernel.org X-Gm-Message-State: AOJu0Yybjml6l/ulY3+V9TOP8/dpQ9VziWQdHEtoQ+AI+fGBVAUhvHdO GmFxzoPwu8KNj03OnzbM8bfBHFkRnFBF+DmiaHa0mcMAAD7lEBjL2y3dkagF30NDqP9UIQNw9OY l2qU7qcYYVsE0VKn/deFvG5LKSbrXofUWLfXsK6DQaD1RsHcIXVsolEn2PNZCuZ7N5g== X-Gm-Gg: AZuq6aIWeMQ1Tpcnv9riv/wjI/y/qlb1P96A+jUls9Bh0OdD9yT5Vx1ZF1K1M+LbDY3 Be61pukFefS8vPNuyWYNiGNdxbVJvGoy2nm7aa+dk4DY0eoggk+TpBvMKTFq8xY1z5VEPc9TTvi iQt4BIwjt3dmhyatHVOFRvAnT7wjD8kR3maXUuKnyaxE9QaYqbOOQ5i0pLDunr89c50EnEzwbwF fbchlTRmT6LIk0Y7yJ84QpZxRg0+tU167X85aCpOXVfQCncrfW5YzeA3WrEzx6pcRMjVvFrj5Vs I8c1hpYh3GPPO/Ms9vaeyQdioPPddZ3bwNy60iucfOZYlNImmufVr3UkXtxoqIRK3Y1t7mBg+WP 2UMc/yb9oE+QNpiErdQFUr9a3rjzb/To5xWqpK2lumJ2ycxLaefnUGDw/ X-Received: by 2002:a05:620a:29d5:b0:8b2:f102:b904 with SMTP id af79cd13be357-8ca2f82e45dmr115301085a.12.1770149922679; Tue, 03 Feb 2026 12:18:42 -0800 (PST) X-Received: by 2002:a05:620a:29d5:b0:8b2:f102:b904 with SMTP id af79cd13be357-8ca2f82e45dmr115297885a.12.1770149922314; Tue, 03 Feb 2026 12:18:42 -0800 (PST) Received: from ?IPV6:2601:188:c102:b180:1f8b:71d0:77b1:1f6e? ([2601:188:c102:b180:1f8b:71d0:77b1:1f6e]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8ca2fd2cbbbsm41231285a.26.2026.02.03.12.18.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Feb 2026 12:18:41 -0800 (PST) From: Waiman Long X-Google-Original-From: Waiman Long Message-ID: <7d9f73c4-0071-4df5-9bc4-0f58ce427a8d@redhat.com> Date: Tue, 3 Feb 2026 15:18:40 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] audit: Avoid excessive dput/dget in audit_context setup and reset paths To: Al Viro Cc: Paul Moore , Eric Paris , Christian Brauner , linux-kernel@vger.kernel.org, audit@vger.kernel.org, Richard Guy Briggs , Ricardo Robaina References: <20260203194433.1738162-1-longman@redhat.com> <20260203195958.GG3183987@ZenIV> Content-Language: en-US In-Reply-To: <20260203195958.GG3183987@ZenIV> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/3/26 2:59 PM, Al Viro wrote: > On Tue, Feb 03, 2026 at 02:44:33PM -0500, Waiman Long wrote: > >> + /* >> + * Defer the path_put() call of the old pwd to workqueue as >> + * we may be in an atomic context that cannot call path_put() >> + * directly because of might_sleep(). >> + */ >> + pp = kmalloc(sizeof(*pp), GFP_NOFS); > If that really gets called in atomic context, this kmalloc will > in itself be enough to fuck you over, won't it? Looking at the bug report again, I realized that the problem is because of the get_cond_fs_pwd() helper in my v1 patch call path_put() in a spinlock critical section. So we don't need to use workqueue here, just doing a path_put() should be good enough. Thanks, Longman