From: Stefan Agner <stefan@agner.ch>
To: Shawn Guo <shawn.guo@freescale.com>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
wg@grandegger.com, kernel@pengutronix.de,
linux-arm-kernel@lists.infradead.org, linux-can@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] can: flexcan: add vf61x support for flexcan
Date: Mon, 14 Jul 2014 09:10:54 +0200 [thread overview]
Message-ID: <7da069ecd355069d82cbe95adc1043f5@agner.ch> (raw)
In-Reply-To: <cecd42e333cdf65ad512f719125f9180@agner.ch>
Am 2014-07-14 09:06, schrieb Stefan Agner:
> Am 2014-07-14 08:04, schrieb Shawn Guo:
>> On Fri, Jul 11, 2014 at 03:58:37PM +0200, Stefan Agner wrote:
>>> >> @@ -362,7 +374,7 @@
>>> >>
>>> >> esdhc1: esdhc@400b2000 {
>>> >> compatible = "fsl,imx53-esdhc";
>>> >> - reg = <0x400b2000 0x4000>;
>>> >> + reg = <0x400b2000 0x1000>;
>>> >
>>> > What's that doing here? :)
>>>
>>> That's an error I just stumbled upon.
>>
>> I do not see why it's an error. From Table 2-1. System Memory Map in
>> i.MX53 RM, the size of ESDHC1 is 16K.
>>
>> Shawn
>
> But then, the memory map within the SDHC peripheral has some registers
> also located in 0x400B3000. Hence I think 0x2000 is correct. Will send
> an updated and separated patch.
>
Sorry, I read this wrong. It is SDHC1 which is in the upper 0x1000 of
the memory map.
So I would say 0x1000 is really correct, since SDHC0 is at 0x400B1000
and SDHC1 is at 0x400B2000.
--
Stefan
next prev parent reply other threads:[~2014-07-14 7:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 10:52 Stefan Agner
2014-07-11 12:09 ` Marc Kleine-Budde
2014-07-11 13:58 ` Stefan Agner
2014-07-11 14:00 ` Lucas Stach
2014-07-11 17:53 ` Marc Kleine-Budde
2014-07-14 6:04 ` Shawn Guo
2014-07-14 7:06 ` Stefan Agner
2014-07-14 7:10 ` Stefan Agner [this message]
2014-07-14 7:32 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7da069ecd355069d82cbe95adc1043f5@agner.ch \
--to=stefan@agner.ch \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=shawn.guo@freescale.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome