From: Pavel Skripkin <paskripkin@gmail.com>
To: Ryusuke Konishi <konishi.ryusuke@gmail.com>,
Dongliang Mu <mudongliangabcd@gmail.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
linux-nilfs <linux-nilfs@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"Nanyong Sun" <sunnanyong@huawei.com>, 慕冬亮 <dzm91@hust.edu.cn>
Subject: Re: Fw:Re: [PATCH] fs: nilfs2: fix memory leak in nilfs sysfs create device group
Date: Sat, 12 Mar 2022 18:16:09 +0300 [thread overview]
Message-ID: <7da316f4-aa65-896e-9020-2dfff2bbfc09@gmail.com> (raw)
In-Reply-To: <CAKFNMon3=fFWtuUa1_wDyK9agpCXjbzA8b+rj=OYu=7Gs8nMqQ@mail.gmail.com>
Hi Ryusuke,
On 3/12/22 18:11, Ryusuke Konishi wrote:
>> In case of nilfs_attach_log_writer() error code jumps to
>> failed_checkpoint label and calls destroy_nilfs() which should call
>> nilfs_sysfs_delete_device_group().
>
> nilfs_sysfs_delete_device_group() is called in destroy_nilfs()
> if nilfs->ns_flags has THE_NILFS_INIT flag -- nilfs_init() inline
> function tests this flag.
>
> The flag is set after init_nilfs() succeeded at the beginning of
> nilfs_fill_super() because the set_nilfs_init() inline in init_nilfs() sets it.
>
> So, nilfs_sysfs_delete_group() seems to be called in case of
> the above failure. Am I missing something?
>
Yeah, that's what I mean :) I can't see how reported issue is possible
with current code.
Sorry for not being clear
With regards,
Pavel Skripkin
next prev parent reply other threads:[~2022-03-12 15:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3192BC90-D082-472B-B310-6E09A14A77C6@hust.edu.cn>
2022-01-21 3:47 ` Dongliang Mu
2022-01-22 4:22 ` Ryusuke Konishi
2022-03-08 2:22 ` Dongliang Mu
2022-03-08 7:58 ` Pavel Skripkin
2022-03-08 8:31 ` Ryusuke Konishi
2022-03-08 8:42 ` Dongliang Mu
2022-03-09 8:30 ` Dongliang Mu
2022-03-12 3:55 ` Ryusuke Konishi
2022-03-12 14:20 ` Pavel Skripkin
2022-03-12 15:11 ` Ryusuke Konishi
2022-03-12 15:16 ` Pavel Skripkin [this message]
2022-03-12 16:01 ` Ryusuke Konishi
2022-03-13 13:35 ` Dongliang Mu
2022-03-15 1:58 ` Dongliang Mu
2022-03-15 4:46 ` Ryusuke Konishi
2022-03-15 5:49 ` Dongliang Mu
2022-03-15 9:11 ` Ryusuke Konishi
2022-03-15 9:18 ` Dongliang Mu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7da316f4-aa65-896e-9020-2dfff2bbfc09@gmail.com \
--to=paskripkin@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dzm91@hust.edu.cn \
--cc=konishi.ryusuke@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=mudongliangabcd@gmail.com \
--cc=sunnanyong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®