From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752125AbeDILLb (ORCPT ); Mon, 9 Apr 2018 07:11:31 -0400 Received: from foss.arm.com ([217.140.101.70]:54882 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751702AbeDILL3 (ORCPT ); Mon, 9 Apr 2018 07:11:29 -0400 Subject: Re: [RFC v2 2/2] base: dma-mapping: Postpone page_to_pfn() on mmap() To: jacopo mondi Cc: Jacopo Mondi , ysato@users.sourceforge.jp, dalias@libc.org, laurent.pinchart@ideasonboard.com, geert@linux-m68k.org, linux-renesas-soc@vger.kernel.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org References: <1510679286-6988-1-git-send-email-jacopo+renesas@jmondi.org> <1510679286-6988-3-git-send-email-jacopo+renesas@jmondi.org> <20180409072547.GU20945@w540> From: Robin Murphy Message-ID: <7da3f31e-e4ad-7f1a-e66c-0d3e0fb8b27d@arm.com> Date: Mon, 9 Apr 2018 12:11:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180409072547.GU20945@w540> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jacopo, On 09/04/18 08:25, jacopo mondi wrote: > Hi Robin, Laurent, > a long time passed, sorry about this. > > On Wed, Nov 15, 2017 at 01:38:23PM +0000, Robin Murphy wrote: >> On 14/11/17 17:08, Jacopo Mondi wrote: >>> On SH4 architecture, with SPARSEMEM memory model, translating page to >>> pfn hangs the CPU. Post-pone translation to pfn after >>> dma_mmap_from_dev_coherent() function call as it succeeds and make page >>> translation not necessary. >>> >>> This patch was suggested by Laurent Pinchart and he's working to submit >>> a proper fix mainline. Not sending for inclusion at the moment. >> >> Y'know, I think this patch does have some merit by itself - until we know >> that cpu_addr *doesn't* represent some device-private memory which is not >> guaranteed to be backed by a struct page, calling virt_to_page() on it is >> arguably semantically incorrect, even if it might happen to be benign in >> most cases. > > I still need to carry this patch in my trees to have a working dma memory mapping > on SH4 platforms. My understanding from your comment is that there may > be a way forward for this patch, do you still think the same? Have you > got any suggestion on how to improve this eventually for inclusion? As before, the change itself does seem reasonable; it might be worth rewording the commit message in more general terms rather than making it sound like an SH-specific workaround (which I really don't think it is), but otherwise I'd say just repost it as a non-RFC patch. Robin. > > Thanks > j > >> >> Robin. >> >>> Suggested-by: Laurent Pinchart >>> Signed-off-by: Jacopo Mondi >>> --- >>> drivers/base/dma-mapping.c | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/base/dma-mapping.c b/drivers/base/dma-mapping.c >>> index e584edd..73d64d3 100644 >>> --- a/drivers/base/dma-mapping.c >>> +++ b/drivers/base/dma-mapping.c >>> @@ -227,8 +227,8 @@ int dma_common_mmap(struct device *dev, struct vm_area_struct *vma, >>> #ifndef CONFIG_ARCH_NO_COHERENT_DMA_MMAP >>> unsigned long user_count = vma_pages(vma); >>> unsigned long count = PAGE_ALIGN(size) >> PAGE_SHIFT; >>> - unsigned long pfn = page_to_pfn(virt_to_page(cpu_addr)); >>> unsigned long off = vma->vm_pgoff; >>> + unsigned long pfn; >>> >>> vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot); >>> >>> @@ -236,6 +236,7 @@ int dma_common_mmap(struct device *dev, struct vm_area_struct *vma, >>> return ret; >>> >>> if (off < count && user_count <= (count - off)) { >>> + pfn = page_to_pfn(virt_to_page(cpu_addr)); >>> ret = remap_pfn_range(vma, vma->vm_start, >>> pfn + off, >>> user_count << PAGE_SHIFT, >>> -- >>> 2.7.4 >>> >>> _______________________________________________ >>> iommu mailing list >>> iommu@lists.linux-foundation.org >>> https://lists.linuxfoundation.org/mailman/listinfo/iommu >>>