From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fllvem-ot03.ext.ti.com (fllvem-ot03.ext.ti.com [198.47.19.245]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AD3115746F; Sat, 19 Apr 2025 13:08:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.19.245 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745068101; cv=none; b=NTSv1XaHj4ooLUBwBpbecxTF6FKSVQFBQac3Jnae42WGZcUaGnutpOHcSob5vda1icSYFL7Hzi2iUDOYvN+yIWm6FmI26OOetCPgQifMcjXGUUUta4e+vesvibMNQotJclMUjNnKAGDM5iZiYf+r5xtDnZcY/hhBNofhRnFmczs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745068101; c=relaxed/simple; bh=ayX5EpVsWM+o+gNglC6xNAYJFVEm4csVnoiPFupgjM4=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=oHkvKFcwHokIFYZEGt7+mQH2z2gKyZFybckC9wxhRruzGbfNTDvcS9l1TQ0mirIghcSw10/D+BOA+v9eSXs5Fga1A0Mmu619iIpUhEFptOUSO4Agf/DDysUlDlOu6Y3ZJRUWcqblOuEETcCQRhb4rKQsIm0VYu/zY/pZVjqkNl8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=hwUTTBeP; arc=none smtp.client-ip=198.47.19.245 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="hwUTTBeP" Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllvem-ot03.ext.ti.com (8.15.2/8.15.2) with ESMTPS id 53JD85Co502312 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 19 Apr 2025 08:08:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1745068085; bh=XwEMlnTnv0lV+xni/6CjZLizXvcalTTI8wO/LpF/GOc=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=hwUTTBePzeMsJkq6SC3wu8CD91AhSqRw7J5ODT4Xa/Seg1prFx2rIUad3k0A8BBa8 U0/RmVRPSlY/g+X5RKJGPjLWvDUrx7DNQtFn8+c7Lvz1d3fPhtNoE8ZRpc/9boZz5W xJdEb6rrglevSIPp2Ouug9zEBO12jBb8J/nU+02c= Received: from DLEE100.ent.ti.com (dlee100.ent.ti.com [157.170.170.30]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 53JD85JE008025 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 19 Apr 2025 08:08:05 -0500 Received: from DLEE103.ent.ti.com (157.170.170.33) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Sat, 19 Apr 2025 08:08:04 -0500 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Sat, 19 Apr 2025 08:08:04 -0500 Received: from [10.249.141.75] ([10.249.141.75]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 53JD80JA029258; Sat, 19 Apr 2025 08:08:00 -0500 Message-ID: <7da470c6-5426-48bf-838a-bc7a5b5dc5db@ti.com> Date: Sat, 19 Apr 2025 18:38:00 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] arm64: dts: ti: k3-j784s4-main: Enable ACSPCIE outputs for PCIe interfaces To: Parth Pancholi , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Siddharth Vadapalli CC: Parth Pancholi , , , , References: <20250404101234.2671147-1-parth105105@gmail.com> Content-Language: en-US From: "Kumar, Udit" In-Reply-To: <20250404101234.2671147-1-parth105105@gmail.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea Thanks for patch, Parth On 4/4/2025 3:42 PM, Parth Pancholi wrote: > From: Parth Pancholi > > TI J784S4-based devices, such as the AM69 SoC, provide PCIE_REFCLK outputs > from the SoC, which can be used to clock external PCIe endpoint devices. > Each PCIE_REFCLK output is enabled via the corresponding ACSPCIE clock > buffer, with each buffer supporting two PADs to provide reference clocks > for two associated PCIe instances. The mappings are as follows: > - PCIe0 -> ACSPCIE1 PAD0 > - PCIe1 -> ACSPCIE0 PAD0 > - PCIe2 -> ACSPCIE1 PAD1 > - PCIe3 -> ACSPCIE0 PAD1 > > This patch enables each ACSPCIE module and its corresponding PADs to ensure > that all PCIE_REFCLK outputs are functional. > > This change have been tested on an AM69-based custom hardware platform, > where all four PCIe instances (PCIe0, PCIe1, PCIe2, and PCIe3) with the > internal PCIE_REFCLK are utilized with various endpoint devices such as > a WiFi card, NVMe SSD, and PCIe-to-USB bridge. You can enabling REFCLK to be out as default. There are few boards, on which this clock is either terminated at test point or not connected at all Example AM69 board PCIE_REFCLK2_P_OUT is not connected and PCIE_REFCLK0_P_OUT is terminated at test points. IMO, this clock to be enabled where this can be connected to PCIe EP. Let Siddharth also share his comment, where to enable these clocks board file or SOC file. Regards Udit > Link: https://e2e.ti.com/support/processors-group/processors/f/processors-forum/1484211/am69-pcie-refclk-out-and-acspcie-mappings > Signed-off-by: Parth Pancholi > --- > This change depends on https://lore.kernel.org/all/20241209085157.1203168-1-s-vadapalli@ti.com/ > v2: set ti,syscon-acspcie-proxy-ctrl mask to 0x3 for all PCIe instances to prevent unintended overrides. > v1: https://lore.kernel.org/all/20250320122259.525613-1-parth105105@gmail.com/ > --- > .../boot/dts/ti/k3-j784s4-j742s2-main-common.dtsi | 12 +++++++++--- > arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 10 ++++++---- > 2 files changed, 15 insertions(+), 7 deletions(-) > [..]