From: Markus Elfring <Markus.Elfring@web.de>
To: "Carlos Llamas" <cmllamas@google.com>,
kernel-team@android.com, "Alice Ryhl" <aliceryhl@google.com>,
"Arve Hjønnevåg" <arve@android.com>,
"Christian Brauner" <brauner@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Joel Fernandes" <joel@joelfernandes.org>,
"Martijn Coenen" <maco@android.com>,
"Suren Baghdasaryan" <surenb@google.com>,
"Todd Kjos" <tkjos@android.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Christophe Jaillet <christophe.jaillet@wanadoo.fr>,
John Stultz <jstultz@google.com>, Nick Chen <chenjia3@oppo.com>,
Steven Moreland <smoreland@google.com>,
Tim Murray <timmurray@google.com>
Subject: Re: [PATCH v5] binder: use bitmap for faster descriptor lookup
Date: Thu, 13 Jun 2024 18:50:53 +0200 [thread overview]
Message-ID: <7daafcb7-2c80-4c2a-bf25-7202634f79f0@web.de> (raw)
In-Reply-To: <20240612042535.1556708-1-cmllamas@google.com>
…
> +++ b/drivers/android/binder.c
…
> +static void try_shrink_dmap(struct binder_proc *proc)
> +{
…
> + binder_proc_lock(proc);
> + nbits = dbitmap_shrink_nbits(&proc->dmap);
> + binder_proc_unlock(proc);
…
> + new = bitmap_zalloc(nbits, GFP_KERNEL);
> + binder_proc_lock(proc);
> + dbitmap_shrink(&proc->dmap, new, nbits);
> + binder_proc_unlock(proc);
> +}
…
Would you become interested to apply lock guards?
https://elixir.bootlin.com/linux/v6.10-rc3/source/include/linux/cleanup.h#L124
Regards,
Markus
next prev parent reply other threads:[~2024-06-13 16:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-16 13:39 [PATCH v3] " Carlos Llamas
2024-05-16 14:10 ` Alice Ryhl
2024-05-17 3:24 ` Carlos Llamas
2024-05-17 3:28 ` [PATCH v4] " Carlos Llamas
2024-06-04 14:06 ` Greg Kroah-Hartman
2024-06-06 18:50 ` Carlos Llamas
2024-06-12 4:25 ` [PATCH v5] " Carlos Llamas
2024-06-13 16:50 ` Markus Elfring [this message]
2024-06-14 9:11 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7daafcb7-2c80-4c2a-bf25-7202634f79f0@web.de \
--to=markus.elfring@web.de \
--cc=aliceryhl@google.com \
--cc=arve@android.com \
--cc=brauner@kernel.org \
--cc=chenjia3@oppo.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=cmllamas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=joel@joelfernandes.org \
--cc=jstultz@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=smoreland@google.com \
--cc=surenb@google.com \
--cc=timmurray@google.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®