From: David Lechner <dlechner@baylibre.com>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>,
jic23@kernel.org, robh@kernel.org, conor+dt@kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: iio: amplifiers: add adl8113
Date: Sat, 22 Nov 2025 10:17:44 -0600 [thread overview]
Message-ID: <7db1158c-c29c-4788-a3d2-b9e7b1042708@baylibre.com> (raw)
In-Reply-To: <20251121095204.18574-2-antoniu.miclaus@analog.com>
On 11/21/25 3:52 AM, Antoniu Miclaus wrote:
> Add devicetree bindings for adl8113.
>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
>
...
> + adi,external-bypass-a-gain-db:
Hmm... are we sure we will never need a non-integer value? Maybe we should add
"-microdb$" to dtschema?
https://github.com/devicetree-org/dt-schema/blob/7033eb7cec1abe55f496309f0f6f271524f5d612/dtschema/schemas/property-units.yaml#L52
> + description:
> + Gain in dB of external amplifier connected to bypass path A (OUT_A/IN_A).
> + When specified, this gain value becomes selectable via the hardwaregain
> + attribute and automatically routes through the external A path.
The dt-bindings should not specify how the driver should operate. We can
leave out the last sentence. We could say though that when omitted it
means nothing is connected.
next prev parent reply other threads:[~2025-11-22 16:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 9:52 [PATCH v4 0/2] iio: amplifiers: add support for ADL8113 Low Noise Amplifier Antoniu Miclaus
2025-11-21 9:52 ` [PATCH v4 1/2] dt-bindings: iio: amplifiers: add adl8113 Antoniu Miclaus
2025-11-22 16:17 ` David Lechner [this message]
2025-11-21 9:52 ` [PATCH v4 2/2] iio: amplifiers: adl8113: add driver support Antoniu Miclaus
2025-11-22 16:52 ` David Lechner
2025-11-28 18:46 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7db1158c-c29c-4788-a3d2-b9e7b1042708@baylibre.com \
--to=dlechner@baylibre.com \
--cc=antoniu.miclaus@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®