From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA188C433E6 for ; Mon, 8 Mar 2021 09:11:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B8625651EB for ; Mon, 8 Mar 2021 09:11:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229814AbhCHJLD (ORCPT ); Mon, 8 Mar 2021 04:11:03 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:33282 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229740AbhCHJKm (ORCPT ); Mon, 8 Mar 2021 04:10:42 -0500 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 128931SI006449; Mon, 8 Mar 2021 10:10:14 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=8WboHxKMLlrdZDES8RgffUYZPXTsH+o3lKjSMUlYi2g=; b=yXfmZByMLKkbYZwHVgzbNyhWpFNIgZGT4j40RCx69PLGX3OyeRSUOdes1Px2py+/eAax Wv95lLB1vyJhnVmczG9XS81xqo3B3kWEedx0xAaDWEMix6aO5Vy6F4hlkoMpdgKA4X1n LmvNYm7zbn1xl2ePTgit4DIP7O7hPFgw5OiPxIINwqqfR6t45uj1dZ5twk+uFCIae0LS X78ht5zFH6s43tBJBLCzgmK4g5XdMtqmAZhYc2mYkUXYzcKNl0t2rGPmfdguYjEO0zRq oOdOnnTjsZ27jwo2Suv/qDgBrLZVAakOotKVTQ9m6d3OSZtl0sIkUex0pDqXwP/CeL0L UQ== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 3741gp9agm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 08 Mar 2021 10:10:14 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id F083310002A; Mon, 8 Mar 2021 10:10:08 +0100 (CET) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id C99E023D70F; Mon, 8 Mar 2021 10:10:08 +0100 (CET) Received: from lmecxl0951.lme.st.com (10.75.127.45) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 8 Mar 2021 10:10:07 +0100 Subject: Re: [PATCH 1/2] drm/stm: dsi: Avoid printing errors for -EPROBE_DEFER To: Raphael GALLAIS-POU - foss , "Yannick FERTRE" , Philippe CORNU , Benjamin Gaignard , Vincent ABRIOU , Sam Ravnborg , Joe Perches CC: David Airlie , Daniel Vetter , "Maxime Coquelin" , Alexandre TORGUE , "dri-devel@lists.freedesktop.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Philippe CORNU - foss , Raphael GALLAIS-POU , Alexandre TORGUE - foss References: <20210222092205.32086-1-raphael.gallais-pou@foss.st.com> <20210222092205.32086-2-raphael.gallais-pou@foss.st.com> From: yannick Fertre Message-ID: <7db3bebd-2cfa-d8d8-40e5-81702295e151@foss.st.com> Date: Mon, 8 Mar 2021 10:10:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210222092205.32086-2-raphael.gallais-pou@foss.st.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.45] X-ClientProxiedBy: SFHDAG2NODE2.st.com (10.75.127.5) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761 definitions=2021-03-08_04:2021-03-08,2021-03-08 signatures=0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tested-by: Yannick Fertre On 2/22/21 10:22 AM, Raphael GALLAIS-POU - foss wrote: > From: Yannick Fertre > > Don't print error when probe deferred error is returned. > > Signed-off-by: Raphael Gallais-Pou > Signed-off-by: Yannick Fertre > --- > drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c > index 2e1f2664495d..8399d337589d 100644 > --- a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c > +++ b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c > @@ -363,8 +363,7 @@ static int dw_mipi_dsi_stm_probe(struct platform_device *pdev) > dsi->vdd_supply = devm_regulator_get(dev, "phy-dsi"); > if (IS_ERR(dsi->vdd_supply)) { > ret = PTR_ERR(dsi->vdd_supply); > - if (ret != -EPROBE_DEFER) > - DRM_ERROR("Failed to request regulator: %d\n", ret); > + dev_err_probe(dev, ret, "Failed to request regulator\n"); > return ret; > } > > @@ -377,9 +376,7 @@ static int dw_mipi_dsi_stm_probe(struct platform_device *pdev) > dsi->pllref_clk = devm_clk_get(dev, "ref"); > if (IS_ERR(dsi->pllref_clk)) { > ret = PTR_ERR(dsi->pllref_clk); > - if (ret != -EPROBE_DEFER) > - DRM_ERROR("Unable to get pll reference clock: %d\n", > - ret); > + dev_err_probe(dev, ret, "Unable to get pll reference clock\n"); > goto err_clk_get; > } > > @@ -419,7 +416,7 @@ static int dw_mipi_dsi_stm_probe(struct platform_device *pdev) > dsi->dsi = dw_mipi_dsi_probe(pdev, &dw_mipi_dsi_stm_plat_data); > if (IS_ERR(dsi->dsi)) { > ret = PTR_ERR(dsi->dsi); > - DRM_ERROR("Failed to initialize mipi dsi host: %d\n", ret); > + dev_err_probe(dev, ret, "Failed to initialize mipi dsi host\n"); > goto err_dsi_probe; > } > >