From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27A1A481B7; Wed, 23 Oct 2024 06:44:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=60.244.123.138 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729665887; cv=none; b=L+rSYbh2YuCurG/mpJEmy3dKPIsBssN+eTpxge0Y9N8EnqDU42ROd3sLu3rMJgrfeQEVKBaUUUdVxlCh2dwjdDXxXWttbBHC7N0gbxfQLGjsO/ppR+bW0g2YkPlbIlDiNrv8wJj7PW7vEOX3F8T77viQ6gLVT7tr/u4cvshuil0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729665887; c=relaxed/simple; bh=xVbTMSxcUlqK7MDOgo6acnDe14gnr92aTZ+Vz3qIc8E=; h=Message-ID:Date:MIME-Version:Subject:From:To:CC:References: In-Reply-To:Content-Type; b=MgbgDR51LWEzx4oq/aL4CaZBfludFCdd3fiP03WuIO2Q6NkpXLNLromwKxxmi74+q3rsnMVoMJljRpSIJ9j6EZUkRLBFunZISpSusgBz5DCKqpFudpOayKy3CPELVJ2YHODqctphY38E77h+T2yCeb3CWEJvz1dECINWsxKtiLc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com; spf=pass smtp.mailfrom=mediatek.com; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b=FuDrhIy5; arc=none smtp.client-ip=60.244.123.138 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mediatek.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="FuDrhIy5" X-UUID: 4673e858910a11efb88477ffae1fc7a5-20241023 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:References:CC:To:From:Subject:MIME-Version:Date:Message-ID; bh=/LlyPax/7pZTsDzzT62rFA+njlFCuzS51AjASbHBcXQ=; b=FuDrhIy5dSp5HmVbFRIwY5+QEpy5W3536QpetOkAK3rgvIjkoOe4DfbjDgithFBXruB4lONL3CVz5UNxVEEObHBBH0tBhmPPp+O0dc+xMyezc3LqeJaeC4PBJAJFSXiOXQ3jQ7nCMQTLZbXKsJIhyzza170b1nLmkSJeI5wodvc=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.42,REQID:2ed6a149-bead-4843-9491-4e84b2d97db4,IP:0,U RL:0,TC:0,Content:1,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:1 X-CID-META: VersionHash:b0fcdc3,CLOUDID:a370f92d-a7a0-4b06-8464-80be82133975,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:4|-5,EDM:-3,IP:ni l,URL:1,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES :1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_ULS,TF_CID_SPAM_SNR X-UUID: 4673e858910a11efb88477ffae1fc7a5-20241023 Received: from mtkmbs14n1.mediatek.inc [(172.21.101.75)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 523556408; Wed, 23 Oct 2024 14:44:38 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Wed, 23 Oct 2024 14:44:33 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Wed, 23 Oct 2024 14:44:32 +0800 Message-ID: <7db67825-cd14-8085-081d-90f090804724@mediatek.com> Date: Wed, 23 Oct 2024 14:44:31 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2] arm64: dts: mediatek: mt8195: Fix dtbs_check error for tphy Content-Language: en-US From: Macpaul Lin To: AngeloGioacchino Del Regno , "Rob Herring" , Krzysztof Kozlowski , "Conor Dooley" , Matthias Brugger , , , , , Seiya Wang , Tinghan Shen , Chunfeng Yun , Alexandre Mergnat , Jian Yang , Jianguo Zhang , "Jieyy Yang" CC: Bear Wang , Pablo Sun , Macpaul Lin , Sen Chu , "Chris-qj chen" , MediaTek Chromebook Upstream , Chen-Yu Tsai References: <20241008071540.32607-1-macpaul.lin@mediatek.com> <314aafed-5903-2478-971f-59870b8ac5fa@mediatek.com> In-Reply-To: <314aafed-5903-2478-971f-59870b8ac5fa@mediatek.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-Product-Ver: SMEX-14.0.0.3152-9.1.1006-23728.005 X-TM-AS-Result: No-10--14.693900-8.000000 X-TMASE-MatchedRID: 6otD/cJAac0OwH4pD14DsPHkpkyUphL9Wot5Z16+u76+UkTh6A/Dwdno quRwHY3BkAluVYknZHpbzVVgo9RtXiA1dgOjatGGXP5rFAucBUHnpmIrKZRxTs/PM4nfEDArIyZ NTlgT7qnRLHyi43Gvn5VYfV6rzvhfRyV3gdKbiKMpa6LJktEjgPioIsi7Sa0gUUVrdcYJZJ0sgd kHScxUMZKrGRECKhSOExCEFq1jOnsTY/HRCFabdLU+IyHhkXf1f2g6KJZtxl2YBF1C0J2QPuuYG VimV8axiI8t/Y95trJ7nZmSglxg9i1Wsi+5O6JcJQI+kfsRJdqeimGtNywjtpsoi2XrUn/Jsuf7 RWbvUtyrusVRy4an8SAHAopEd76vRgZ0es9KU/RKAyF67tDyvJxdMmyRqn9gNXm9bRYGgkKW0XD zeoW8Rw== X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--14.693900-8.000000 X-TMASE-Version: SMEX-14.0.0.3152-9.1.1006-23728.005 X-TM-SNTS-SMTP: C810F8B9D87195458A9F7EFB21E49AFFF30BA1B0E50E32FA1B6818C4E7A366842000:8 On 10/9/24 17:21, Macpaul Lin wrote: > > > On 10/8/24 17:09, AngeloGioacchino Del Regno wrote: >> Il 08/10/24 09:15, Macpaul Lin ha scritto: >>> The u3phy1 node in mt8195.dtsi was triggering a dtbs_check error. >>> The error message was: >>>    t-phy@11e30000: 'power-domains' does not match any of the regexes: >>>      '^(usb|pcie|sata)-phy@[0-9a-f]+$', 'pinctrl-[0-9]+' >>> Fix this issue by dropping 'power-domains' of u3phy1 node. >>> >>> This is because MediaTek tphy dose not need to add mtcmos.  It is not >>> necessary to add 'power-domains'. If the power of the tphy is turned >>> off, >>> it will affect other functions. From the current USB hardware design >>> perspective, even if mtcmos is added to the phy, it is always on. >>> >>> Fixes: 37f2582883be ("arm64: dts: Add mediatek SoC mt8195 and >>> evaluation board") >>> Signed-off-by: Macpaul Lin >> >> Reviewed-by: AngeloGioacchino Del Regno >> > > Sorry for bothering, it seems MediaTek internal still have some > discussion about according to Conor's suggestion: > > [1] > https://lore.kernel.org/lkml/20241008-disorder-slacking-d8196ceb68f7@spud/T/#mccf978d76f52cc26970f3f3be6120055e4698fe6 > > > Please don't to pick this patch until if MediaTek could have some > conclusions. Update: This patch could be dropped since the correct fix in TPHY's DT Schema has been accepted. [2] https://lore.kernel.org/all/172917936283.288841.9548294790735623997.b4-ty@kernel.org/ >>> --- >>>   arch/arm64/boot/dts/mediatek/mt8195.dtsi | 1 - >>>   1 file changed, 1 deletion(-) >>> >>> Changes for v2: >>>   - Add detail description of the tphy design for explaining the reason >>>     of this change. >>> >>> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi >>> b/arch/arm64/boot/dts/mediatek/mt8195.dtsi >>> index ade685ed2190..1c6f08dde31c 100644 >>> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi >>> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi >>> @@ -1920,7 +1920,6 @@ u3phy1: t-phy@11e30000 { >>>               #address-cells = <1>; >>>               #size-cells = <1>; >>>               ranges = <0 0 0x11e30000 0xe00>; >>> -            power-domains = <&spm MT8195_POWER_DOMAIN_SSUSB_PCIE_PHY>; >>>               status = "disabled"; >>>               u2port1: usb-phy@0 { >> >> > > Thanks! > Macpaul Lin Thanks! Macpaul Lin