From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EBDE2673A1; Tue, 8 Apr 2025 09:54:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744106057; cv=none; b=klaYVH4/1aO+Bd7e3ENmM+YUmtvUTQ3Stj25mbLfdQhVGc1shOTpPNoKVIjeE1e9UBpZQOw+BMSdF6uRgiQ5635yUP2UEykNKrJ0dwwPT4Gnzk0FR+mnSYzLhPnI+S5/r+3h4IxWPc0e9ok9ze0Y33hIQJS1MS4R2HBZjB1ZJhQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744106057; c=relaxed/simple; bh=UBCLFcHxtnIpnZRQr/Y1J/L8GVcFDESfnxgo711iWPg=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=HyRYdVLFacPc0Sc52uJMyY/EZSgIv0Mmg1bvUP6nYcMvjyWvND2tI1i8UnThJHHc3GPbgvbHooB8fJehL2CVJPpI0Ax2flg01uZOefmXlE027R70c3O+IrxVhWOmiY/NlFp47k7+jbp+rDo/I/JO5TwyeHSGE4INg+wEI0UmSJ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=MGVBmeb+; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="MGVBmeb+" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5382GSVo008168; Tue, 8 Apr 2025 09:54:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fizUwIrV0cpC9lIVh+PAaW3sb5m6ocUw8SwBxQRgILw=; b=MGVBmeb+EXIfcpj1 xynl9HPyHwrSceRfoUWerSm++f6TRZsR4LAEbf6TSTShEpr6iIGpLUVyA9nQbKrp o0lZV2ISCK6klHWEgDh9WN3tswcTI3ko2tdmiDpkgi8MlRBED13BGP1w6LkPgfBP Sjm5eS0lbmgBE1oZQuSSnlC5dy8K3WQL1w9tluqmc4/wIoniFFRJckrNVd4svWAe GytF4i+tKhmaxSxOqJmrjSd4nsZ8QyHIy62LTlOJ137EqdSzXIwrAStfYvOIsK6Z O9umFDAMY1kNBpRxkkQJ1aqoPU/RUYOIndKNB43rva53pEpvWBxYYRWSf8L3yshy OFXoXw== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45twtaybr2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 08 Apr 2025 09:54:03 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 5389s287004531 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 8 Apr 2025 09:54:02 GMT Received: from [10.216.15.222] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Tue, 8 Apr 2025 02:53:58 -0700 Message-ID: <7db95e73-18c9-cad2-5a5c-181db8e4aba7@quicinc.com> Date: Tue, 8 Apr 2025 15:23:55 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH ath-next v4 5/9] wifi: ath12k: fix firmware assert during reboot with hardware grouping Content-Language: en-US To: Aditya Kumar Singh , Johannes Berg , Jeff Johnson , "Karthikeyan Periyasamy" , Kalle Valo , Harshitha Prem CC: Jeff Johnson , , , References: <20250408-fix_reboot_issues_with_hw_grouping-v4-0-95e7bf048595@oss.qualcomm.com> <20250408-fix_reboot_issues_with_hw_grouping-v4-5-95e7bf048595@oss.qualcomm.com> From: Vasanthakumar Thiagarajan In-Reply-To: <20250408-fix_reboot_issues_with_hw_grouping-v4-5-95e7bf048595@oss.qualcomm.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: -mCQanm--1LXYyvVIPnt4M51_hSuKzqV X-Authority-Analysis: v=2.4 cv=LLlmQIW9 c=1 sm=1 tr=0 ts=67f4f23b cx=c_pps a=ouPCqIW2jiPt+lZRy3xVPw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=GEpy-HfZoHoA:10 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=EUspDBNiAAAA:8 a=_MiNaS0KeY7sYsYnmAYA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-ORIG-GUID: -mCQanm--1LXYyvVIPnt4M51_hSuKzqV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-08_03,2025-04-07_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 clxscore=1015 mlxlogscore=829 malwarescore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 mlxscore=0 spamscore=0 adultscore=0 suspectscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504080070 On 4/8/2025 11:36 AM, Aditya Kumar Singh wrote: > At present, during PCI shutdown, the power down is only executed for a > single device. However, when operating in a group, all devices need to be > powered down simultaneously. Failure to do so will result in a firmware > assertion. > > Hence, introduce a new ath12k_pci_hw_group_power_down() and call it during > power down. This will ensure that all partner devices are properly powered > down. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1 > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.4.1-00199-QCAHKSWPL_SILICONZ-1 > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 > > Signed-off-by: Aditya Kumar Singh Reviewed-by: Vasanthakumar Thiagarajan