From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751065AbdESHzO (ORCPT ); Fri, 19 May 2017 03:55:14 -0400 Received: from thoth.sbs.de ([192.35.17.2]:45861 "EHLO thoth.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750731AbdESHzN (ORCPT ); Fri, 19 May 2017 03:55:13 -0400 Subject: Re: [PATCH] mfd: intel_quark_i2c_gpio: Add support for SIMATIC IOT2000 platform To: Lee Jones , Andy Shevchenko Cc: Linux Kernel Mailing List References: <80e73378-83d9-b61e-670d-6cd7372171c2@siemens.com> <1494329692.30052.75.camel@linux.intel.com> <20170512081209.2xvq7gtvl54dxl6b@dell> From: Jan Kiszka Message-ID: <7dbd8673-32af-f5ec-5ed5-c37ea87f7487@siemens.com> Date: Fri, 19 May 2017 09:55:08 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <20170512081209.2xvq7gtvl54dxl6b@dell> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-05-12 10:12, Lee Jones wrote: > On Tue, 09 May 2017, Andy Shevchenko wrote: > >> On Tue, 2017-05-09 at 06:40 +0200, Jan Kiszka wrote: >>> The SIMATIC IOT2000 is derived from the Galileo Gen2 board and shares >>> its I2C frequency. >>> >>> Signed-off-by: Jan Kiszka >> >>> Signed-off-by: Sascha Weisenberger >> >> Hmm... I thought that SoB chain goes from first author to last. (Or in >> case of maintainer / submitter their SoB goes at the end, which is >> apparently not the case here). > > Yes, that's correct. I will switch them when I apply the patch. Apparently, the patch is not yet in mfd-next, so let me retract it: I just realized we should rather do an exact name/asset-tags match here as well (like for exar and stmmac). Moreover, I'd like to rework the DMI matching along Andy's suggestion and use native matching methods (dmi_system_id table) instead of the current open-code one. Patches will follow soon. Jan > >> Other than above >> >> Reviewed-by: Andy Shevchenko > >>> >>> --- >>> drivers/mfd/intel_quark_i2c_gpio.c | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/drivers/mfd/intel_quark_i2c_gpio.c >>> b/drivers/mfd/intel_quark_i2c_gpio.c >>> index 7946d6e38b87..98dddf2831ad 100644 >>> --- a/drivers/mfd/intel_quark_i2c_gpio.c >>> +++ b/drivers/mfd/intel_quark_i2c_gpio.c >>> @@ -72,6 +72,10 @@ static const struct i2c_mode_info >>> platform_i2c_mode_info[] = { >>> .name = "GalileoGen2", >>> .i2c_scl_freq = 400000, >>> }, >>> + { >>> + .name = "SIMATIC IOT2000", >>> + .i2c_scl_freq = 400000, >>> + }, >>> {} >>> }; >>> >> > -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux