From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933071AbdKASoL (ORCPT <rfc822;w@1wt.eu>);
        Wed, 1 Nov 2017 14:44:11 -0400
Received: from mx1.redhat.com ([209.132.183.28]:51966 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751428AbdKASoK (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 1 Nov 2017 14:44:10 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 21BB881DF8
Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=longman@redhat.com
Subject: Re: [PATCH v8 1/6] lib/dlock-list: Distributed and lock-protected
 lists
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.com>,
        Jeff Layton <jlayton@poochiereds.net>,
        "J. Bruce Fields" <bfields@fieldses.org>, Tejun Heo <tj@kernel.org>,
        Christoph Lameter <cl@linux-foundation.org>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>,
        Andi Kleen <andi@firstfloor.org>, Dave Chinner <dchinner@redhat.com>,
        Boqun Feng <boqun.feng@gmail.com>
References: <1509475860-16139-1-git-send-email-longman@redhat.com>
 <1509475860-16139-2-git-send-email-longman@redhat.com>
 <20171031213732.2nqqbdefvxxorg52@linux-n805>
From: Waiman Long <longman@redhat.com>
Organization: Red Hat
Message-ID: <7dc0b507-fdb7-4d32-5d44-d2125409d73b@redhat.com>
Date: Wed, 1 Nov 2017 14:44:08 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.0
MIME-Version: 1.0
In-Reply-To: <20171031213732.2nqqbdefvxxorg52@linux-n805>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 01 Nov 2017 18:44:10 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/31/2017 05:37 PM, Davidlohr Bueso wrote:
> On Tue, 31 Oct 2017, Waiman Long wrote:
>
>> +void dlock_lists_del(struct dlock_list_node *node)
>> +{
>> +    struct dlock_list_head *head;
>> +    bool retry;
>> +
>> +    do {
>> +        head = READ_ONCE(node->head);
>
> Boqun had previously pointed this out; you need to WRITE_ONCE()
> node->head too.

Right, I will get that into the next version of the patch.

Cheers,
Longman