From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C29DCC433FE for ; Thu, 9 Sep 2021 10:51:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A4D0460F4A for ; Thu, 9 Sep 2021 10:51:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234339AbhIIKwg (ORCPT ); Thu, 9 Sep 2021 06:52:36 -0400 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:14326 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232903AbhIIKwf (ORCPT ); Thu, 9 Sep 2021 06:52:35 -0400 Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1896onVx002355; Thu, 9 Sep 2021 05:51:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=PODMain02222019; bh=vV2E/bPOCiDXIXiqkPzy5Kt8Vs/IvVSFsRIuqXLKxFM=; b=Zi3ZOHlhXIMKHtWoluEvl5r/O6KDehvSF4IeYn92I4aqALLZ6EbaFQxPZf255JFdXfQr YhNMRLOCJ0ba9XYImKxI9M5KEL32Esahuqwi65UQq8m21VBvw8IrRRYDNevg95FaNaM8 HsoMVs2ttqCTn4ARVXF8EhNYwhYgUtZ5wFVdXRM5qJG0pbUOXc0+i9/3bABrHfYdffPJ qvumz9yOpFYMywHT/IU8EpuktezzEbOR5tvCBI0u8lpnqP218T3ag2HHCyvgIe6YwDjO Lj+i+IEtesZMD4BIQ5nIToSoncWah9Au3aOYmEXSZD47IACbDuVaSvsb8JLaFjxct7jq cw== Received: from ediex01.ad.cirrus.com ([87.246.76.36]) by mx0b-001ae601.pphosted.com with ESMTP id 3ay8n60dna-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Thu, 09 Sep 2021 05:51:23 -0500 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 9 Sep 2021 11:51:21 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.2242.12 via Frontend Transport; Thu, 9 Sep 2021 11:51:21 +0100 Received: from [198.61.64.231] (unknown [198.61.64.231]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 565E3478; Thu, 9 Sep 2021 10:51:21 +0000 (UTC) Subject: Re: [PATCH 03/10] spi: Add flag for no TX after a RX in the same Chip Select To: Mark Brown CC: Greg Kroah-Hartman , "Rafael J . Wysocki" , Sanjay R Mehta , Nehal Bakulchandra Shah , , , References: <20210908113450.788452-1-tanureal@opensource.cirrus.com> <20210908113450.788452-4-tanureal@opensource.cirrus.com> <20210908123734.GF4112@sirena.org.uk> From: Lucas tanure Message-ID: <7dc20785-95da-6599-49dc-8e5f805d6a14@opensource.cirrus.com> Date: Thu, 9 Sep 2021 11:51:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210908123734.GF4112@sirena.org.uk> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: Pmt-t4LicdzZ8Q9yaFx4gS45mSJbI8b2 X-Proofpoint-GUID: Pmt-t4LicdzZ8Q9yaFx4gS45mSJbI8b2 X-Proofpoint-Spam-Reason: safe Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/8/21 1:37 PM, Mark Brown wrote: > On Wed, Sep 08, 2021 at 12:34:44PM +0100, Lucas Tanure wrote: >> Some controllers can't write to the bus after a read without >> releasing the chip select, so add flag and a check in spi core > > Nothing you've added ever reads this flag and I'm not sure what anything > would be able to constructively do with it so why add the flag? I don't > understand what the use case is. > __spi_validate checks this flag and makes sure the message can be received by the controller. __spi_validate can't fix the message, so it only rejects the message.