From: Brijesh Singh <brijesh.singh@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: brijesh.singh@amd.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Joerg Roedel" <joro@8bytes.org>,
"Tom Lendacky" <thomas.lendacky@amd.com>,
x86@kernel.org
Subject: Re: [Part2 PATCH v7 33/38] KVM: SVM: Add support for SEV DEBUG_ENCRYPT command
Date: Mon, 6 Nov 2017 10:38:00 -0600 [thread overview]
Message-ID: <7dcacb08-2a08-c902-691c-a454a3737aca@amd.com> (raw)
In-Reply-To: <20171106113105.qvw5wq7qts3ak5c2@pd.tnic>
On 11/06/2017 05:31 AM, Borislav Petkov wrote:
...
>> - ret = sev_dbg_decrypt_user(kvm,
>> - __sme_page_pa(src_p[0]) + s_off,
>> - dst_vaddr,
>> - __sme_page_pa(dst_p[0]) + d_off,
>> - len, &argp->error);
>> + if (dec)
>> + ret = sev_dbg_decrypt_user(kvm,
>> + __sme_page_pa(src_p[0]) + s_off,
>> + dst_vaddr,
>> + __sme_page_pa(dst_p[0]) + d_off,
>> + len, &argp->error);
>> + else
>> + ret = __sev_dbg_encrypt_user(kvm,
>> + __sme_page_pa(src_p[0]) + s_off,
>> + vaddr,
>> + __sme_page_pa(dst_p[0]) + d_off,
>> + dst_vaddr,
>> + len, &argp->error);
>
> sev_dbg_decrypt_user but __sev_dbg_encrypt_user, with the "__" ??
>
yes they both should be "__", I will overlooked it and will fix in next rev.
next prev parent reply other threads:[~2017-11-06 16:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-01 21:17 [Part2 PATCH v7 30/38] KVM: SVM: Add support for SEV LAUNCH_FINISH command Brijesh Singh
2017-11-01 21:17 ` [Part2 PATCH v7 31/38] KVM: SVM: Add support for SEV GUEST_STATUS command Brijesh Singh
2017-11-01 21:17 ` [Part2 PATCH v7 32/38] KVM: SVM: Add support for SEV DEBUG_DECRYPT command Brijesh Singh
2017-11-06 11:24 ` Borislav Petkov
2017-11-01 21:17 ` [Part2 PATCH v7 33/38] KVM: SVM: Add support for SEV DEBUG_ENCRYPT command Brijesh Singh
2017-11-06 11:31 ` Borislav Petkov
2017-11-06 16:38 ` Brijesh Singh [this message]
2017-11-01 21:17 ` [Part2 PATCH v7 34/38] KVM: SVM: Add support for SEV LAUNCH_SECRET command Brijesh Singh
2017-11-06 14:36 ` Borislav Petkov
2017-11-01 21:17 ` [Part2 PATCH v7 35/38] KVM: SVM: Pin guest memory when SEV is active Brijesh Singh
2017-11-06 14:43 ` Borislav Petkov
2017-11-06 16:55 ` Brijesh Singh
2017-11-01 21:17 ` [Part2 PATCH v7 36/38] KVM: SVM: Clear C-bit from the page fault address Brijesh Singh
2017-11-01 21:17 ` [Part2 PATCH v7 37/38] KVM: SVM: Do not install #UD intercept when SEV is enabled Brijesh Singh
2017-11-01 21:17 ` [Part2 PATCH v7 38/38] KVM: X86: Restart the guest when insn_len is zero and " Brijesh Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7dcacb08-2a08-c902-691c-a454a3737aca@amd.com \
--to=brijesh.singh@amd.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®