From: "Simmons, James A." <simmonsja@ornl.gov>
To: "'Joe Perches'" <joe@perches.com>,
"'Greg Kroah-Hartman'" <gregkh@linuxfoundation.org>,
"Dilger, Andreas" <andreas.dilger@intel.com>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"Drokin, Oleg" <oleg.drokin@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lustre Development List <lustre-devel@lists.lustre.org>
Subject: RE: [lustre-devel] [PATCH] Revert "Staging: lustre: o2iblnd: Use sizeof type *pointer instead of sizeof type."
Date: Wed, 23 Mar 2016 20:29:49 +0000 [thread overview]
Message-ID: <7dcad179d49c4535b4f24d3ceb85607a@EXCHCS32.ornl.gov> (raw)
In-Reply-To: <1458758864.18165.4.camel@perches.com>
>> > > so the right code should be:
>> > >
>> > > sizeof(**net->ibn_tx_ps);
>> > > and the same for sizeof(**net->ibn_fmr_ps)
>> > That's a mess, isn't there some other way to fix this up to be more
>> > "obvious"?
>> This must have been encountered in the past. How was it handle in those
>> other cases?
>
>I fail to see why it's a mess. It's just **
>and someone making a mistake.
I have no trouble with **. If we revert it someone else will come along and
do the same mistake so I think we are stuck with the change to **.
>Removing the "typedef struct" uses from lustre
>would probably make a lot of this clearer though.
That along with a few hundred more patches heading Greg's way :-)
next prev parent reply other threads:[~2016-03-23 20:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 22:21 James Simmons
2016-03-23 1:49 ` Greg Kroah-Hartman
2016-03-23 5:39 ` [lustre-devel] " Dilger, Andreas
2016-03-23 6:29 ` Oucharek, Doug S
2016-03-23 13:41 ` Greg Kroah-Hartman
2016-03-23 18:31 ` Simmons, James A.
2016-03-23 18:47 ` Joe Perches
2016-03-23 20:29 ` Simmons, James A. [this message]
2016-03-23 20:43 ` 'Greg Kroah-Hartman'
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7dcad179d49c4535b4f24d3ceb85607a@EXCHCS32.ornl.gov \
--to=simmonsja@ornl.gov \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®