From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C776C433F5 for ; Mon, 20 Sep 2021 08:26:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 048F960F12 for ; Mon, 20 Sep 2021 08:26:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235748AbhITI2D (ORCPT ); Mon, 20 Sep 2021 04:28:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235727AbhITI2A (ORCPT ); Mon, 20 Sep 2021 04:28:00 -0400 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40805C061574 for ; Mon, 20 Sep 2021 01:26:33 -0700 (PDT) Received: by mail-wr1-x429.google.com with SMTP id w17so19208629wrv.10 for ; Mon, 20 Sep 2021 01:26:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Sd2zasa8jsIrDfE+uKpeLHxh1coC9+sVR27g2clwkhM=; b=ckRxkYg0UKty5XJskZHyKC1uz5SKwEvg6hMxqc/s62FhCOm6PxEQHRhWcKB9WAoSJp GO4n/go5FJ+TTQdsm5+lFhx3+c9s44JCpKFqB96Py8X5+8mSfZxLDql4uVACODWS03lw osn3vXU5pyd4zEsoet9nqiW6CJ7lQqYzMd2AClGhOZqoA/1hYjPwwafSU9EWemy0XmgD fNHCxgzxURbgJYyH1nHQvqUL/NwJg6HbHMpaEri8rjH3AZSIUVr7F7CLvLO3CIzFZpL/ AePngvOzTZNvxjRvw4wn+8WMUODP+GsiasazeQaiTRMy6wrFCNLZzlBKQI3u2jXhTYAN EpwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Sd2zasa8jsIrDfE+uKpeLHxh1coC9+sVR27g2clwkhM=; b=0bw34owZINsqZihH1Byb1a9Z+VYytKywbMFrxLGj8YIO9a3t8lA/1b6jviMDQEnzL/ NkEVLJt2Qmt5Qe66+1Q4bZsDvTXryHAABJwpvgsGHQu2edhy8Ci/O1fEHSwDQiUSHyDD deHg1imuejk7b7dSGIROVLNM1Lf3S/0LAIFq+RpMadqUvskZayYxo7IMnmr5vRNeUaou eejSYwbbOEYHLQx5AmevBEqiQmXFN+OPTM5W4kt1yEfYkgi7EVX5HWRI31VdZPLXqB9C p6vWnOVHXmLqCm4X7dTdMMjcrWHoeD+xlQMO6KkZWca/2RiFQxDHNqo1YqJ3z/eaYZME EeBg== X-Gm-Message-State: AOAM531Pn3x3+gySUHFBS24OBQvYLX5Ku7pPjek5vMLzoUqQ/nCj8nY8 CCoFmgFlMNzgkURsaphU6DYSbQ== X-Google-Smtp-Source: ABdhPJw/mT3WUCPVZ29jbrBrgnE8L+20CP0Qbr5FtszQo+bi6bIe+hZ7C0epV27RPl5aeN5zYF9n9g== X-Received: by 2002:a5d:6d8e:: with SMTP id l14mr27071868wrs.196.1632126391761; Mon, 20 Sep 2021 01:26:31 -0700 (PDT) Received: from [172.20.10.7] ([37.169.24.17]) by smtp.gmail.com with ESMTPSA id c132sm6707022wma.22.2021.09.20.01.26.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Sep 2021 01:26:31 -0700 (PDT) Subject: Re: [PATCH] regulator: pwm-regulator: Make use of the helper function dev_err_probe() To: Anand Moon , linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Martin Blumenstingl , Liam Girdwood , Mark Brown , Jon Hunter References: <20210919211129.4364-1-linux.amoon@gmail.com> From: Neil Armstrong Organization: Baylibre Message-ID: <7dcee097-9119-1987-9bb5-777d541cc9f7@baylibre.com> Date: Mon, 20 Sep 2021 10:26:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210919211129.4364-1-linux.amoon@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/09/2021 23:11, Anand Moon wrote: > devm_regulator_register can return -EPROBE_DEFER if the > regulator is not ready yet. Use dev_err_probe() for > pwm regulator resources to indicate the deferral reason > when waiting for the resource to come up. > > Fixes: 0cd71b9a43ad ("regulator: pwm: Don't warn on probe deferral") > > Cc: Martin Blumenstingl > Signed-off-by: Anand Moon > --- > drivers/regulator/pwm-regulator.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/regulator/pwm-regulator.c b/drivers/regulator/pwm-regulator.c > index 7629476d94ae..451e57a739f8 100644 > --- a/drivers/regulator/pwm-regulator.c > +++ b/drivers/regulator/pwm-regulator.c > @@ -382,9 +382,9 @@ static int pwm_regulator_probe(struct platform_device *pdev) > &drvdata->desc, &config); > if (IS_ERR(regulator)) { > ret = PTR_ERR(regulator); > - dev_err(&pdev->dev, "Failed to register regulator %s: %d\n", > - drvdata->desc.name, ret); > - return ret; > + return dev_err_probe(&pdev->dev, ret, > + "Failed to register regulator %s: %d\n", > + drvdata->desc.name, ret); No need to keep ret and print it since it will be printed by dev_err_probe, pass directly PTR_ERR(regulator) and drop the ": %d" from the error string. Neil > } > > return 0; >