From: Neil Armstrong <neil.armstrong@linaro.org>
To: Luca Weiss <luca.weiss@fairphone.com>,
Bastien Nocera <hadess@hadess.net>,
Hans de Goede <hdegoede@redhat.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jeff LaBundy <jeff@labundy.com>,
Charles Wang <charles.goodix@gmail.com>,
Jens Reidel <adrian@travitia.xyz>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Input: goodix-berlin - fix comment referencing wrong regulator
Date: Fri, 3 Jan 2025 10:26:13 +0100 [thread overview]
Message-ID: <7dd25309-cf51-4e5e-8ddd-24267670ecf2@linaro.org> (raw)
In-Reply-To: <20250103-goodix-berlin-fixes-v1-1-b014737b08b2@fairphone.com>
On 03/01/2025 10:21, Luca Weiss wrote:
> In the statement above AVDD gets enabled, and not IOVDD, so fix this
> copy-paste mistake.
>
> Fixes: 44362279bdd4 ("Input: add core support for Goodix Berlin Touchscreen IC")
> Reported-by: Jens Reidel <adrian@travitia.xyz>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> drivers/input/touchscreen/goodix_berlin_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/goodix_berlin_core.c b/drivers/input/touchscreen/goodix_berlin_core.c
> index 3fc03cf0ca23fdbe36028a6228030d3ffb8d3a09..e273fb8edc6b92bcbad0fd35223a841d7da7d671 100644
> --- a/drivers/input/touchscreen/goodix_berlin_core.c
> +++ b/drivers/input/touchscreen/goodix_berlin_core.c
> @@ -263,7 +263,7 @@ static int goodix_berlin_power_on(struct goodix_berlin_core *cd)
> goto err_iovdd_disable;
> }
>
> - /* Vendor waits 15ms for IOVDD to settle */
> + /* Vendor waits 15ms for AVDD to settle */
> usleep_range(15000, 15100);
>
> gpiod_set_value_cansleep(cd->reset_gpio, 0);
>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
next prev parent reply other threads:[~2025-01-03 9:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-03 9:21 [PATCH 0/2] Some fixes for Goodix Berlin touchscreen driver Luca Weiss
2025-01-03 9:21 ` [PATCH 1/2] Input: goodix-berlin - fix comment referencing wrong regulator Luca Weiss
2025-01-03 9:26 ` Neil Armstrong [this message]
2025-02-25 6:29 ` Dmitry Torokhov
2025-01-03 9:21 ` [PATCH 2/2] Input: goodix-berlin - fix vddio regulator references Luca Weiss
2025-01-03 9:27 ` Neil Armstrong
2025-01-03 9:52 ` Luca Weiss
2025-02-25 6:29 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7dd25309-cf51-4e5e-8ddd-24267670ecf2@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=adrian@travitia.xyz \
--cc=charles.goodix@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hadess@hadess.net \
--cc=hdegoede@redhat.com \
--cc=jeff@labundy.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=phone-devel@vger.kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®