From: Andrew Lunn <andrew@lunn.ch>
To: Alex Tran <alex.t.tran@gmail.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v1] Fixes: xircom auto-negoation timer
Date: Mon, 25 Aug 2025 21:04:11 +0200 [thread overview]
Message-ID: <7dd4c448-df2a-4fee-90d6-cc3606a5c3dc@lunn.ch> (raw)
In-Reply-To: <CA+hkOd72gg-8VVfdpNpATbunJt-Oc7Dujor9crQP7sFiDj_L8w@mail.gmail.com>
On Mon, Aug 25, 2025 at 10:40:45AM -0700, Alex Tran wrote:
> > > You state this is a fix. Which problem does it fix?
> The change was originally suggested under a FIXME comment but it seems
> like more of a cleanup.
>
> > > Do you have this hardware for testing your patches?
> I do not have the physical hardware. The change was made based on code
> analysis and successful kselftests and kernel compilation on all yes
> config.
Sorry, without the hardware: NACK.
For old hardware like this, please only work on them if you have the
hardware. Otherwise, you are likely to break it. There is no gain for
work like this, and in effect you just waste reviewer time.
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2025-08-25 19:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-25 1:28 Alex Tran
2025-08-25 6:44 ` Heiner Kallweit
2025-08-25 12:08 ` Andrew Lunn
2025-08-25 17:40 ` Alex Tran
2025-08-25 19:04 ` Andrew Lunn [this message]
2025-08-31 14:11 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7dd4c448-df2a-4fee-90d6-cc3606a5c3dc@lunn.ch \
--to=andrew@lunn.ch \
--cc=alex.t.tran@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®