From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36ACBC77B60 for ; Mon, 3 Apr 2023 09:42:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232253AbjDCJma (ORCPT ); Mon, 3 Apr 2023 05:42:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231484AbjDCJl5 (ORCPT ); Mon, 3 Apr 2023 05:41:57 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DD3F10AAF; Mon, 3 Apr 2023 02:41:49 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 8B1E266003AC; Mon, 3 Apr 2023 10:41:47 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1680514907; bh=yGQW+RsdLz3zsU0uhQhgjYH5b+qFEACrFhpDyGP/USQ=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=c7zZUCTGZHXDjVnF0waGyq29bWYrauWP3P1JK1iny0dI7oDgtifm7Own5ozu8Hitt W/BdzT3aYT/E6VkgiyV1y6hShdda0PH2RxYUSYdFUqnyLN036L7TnTAorTvnLDl3Eu vSKAKv9TL3kirQyzOgIcVfe+Y9PNP40/ay8LYbgeSkR11xSJJjua0hWYnhSIBeu76u /wppMDE3yUvYResE8KVYkt3ONmiprL8LHwnWxsKa9+s706qRD/g0hbJ/yGlzrJq38Q la0cJu5ief1jtaELTlOWP3c8YEaBVOBvjfixCxqudSwpkTAwP8aZvtK4ILuDBRaKPS 3r2MGcciaxFiw== Message-ID: <7dd87d0c-c5fc-fe00-f021-34061f0705e4@collabora.com> Date: Mon, 3 Apr 2023 11:41:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: linux-next: build failure after merge of the mediatek tree Content-Language: en-US From: AngeloGioacchino Del Regno To: Stephen Rothwell , Matthias Brugger Cc: Linux Kernel Mailing List , Linux Next Mailing List References: <20230403181552.607a8b64@canb.auug.org.au> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 03/04/23 10:45, AngeloGioacchino Del Regno ha scritto: > Il 03/04/23 10:15, Stephen Rothwell ha scritto: >> Hi all, >> >> After merging the mediatek tree, today's linux-next build (arm64 >> defconfig) failed like this: >> >> aarch64-linux-gnu-ld: Unexpected GOT/PLT entries detected! >> aarch64-linux-gnu-ld: Unexpected run-time procedure linkages detected! >> aarch64-linux-gnu-ld: drivers/soc/mediatek/mtk-mmsys.o: in function >> `mtk_mmsys_update_bits': >> drivers/soc/mediatek/mtk-mmsys.c:147: undefined reference to `cmdq_pkt_write_mask' >> aarch64-linux-gnu-ld: drivers/soc/mediatek/mtk-mmsys.o: in function >> `mtk_mmsys_probe': >> drivers/soc/mediatek/mtk-mmsys.c:386: undefined reference to >> `cmdq_dev_get_client_reg' >> aarch64-linux-gnu-ld: drivers/soc/mediatek/mtk-mutex.o: in function >> `mtk_mutex_enable_by_cmdq': >> drivers/soc/mediatek/mtk-mutex.c:883: undefined reference to `cmdq_pkt_write' >> aarch64-linux-gnu-ld: drivers/soc/mediatek/mtk-mutex.o: in function >> `mtk_mutex_probe': >> drivers/soc/mediatek/mtk-mutex.c:1023: undefined reference to >> `cmdq_dev_get_client_reg' >> >> Caused by commit >> >>    b34884b4c878 ("soc: mediatek: Cleanup ifdefs for IS_REACHABLE(CONFIG_MTK_CMDQ)") >> > > I can recheck why this happens - otherwise we can simply avoid applying that commit > if there's no time. > Followup: I've rechecked and sent a solution for that; please check [1]. [1]: https://lore.kernel.org/lkml/20230403093304.276418-1-angelogioacchino.delregno@collabora.com/ >> I have used the mediatek tree from next-20230331 for today. >> >> There were also the following warnings: >> >> arch/arm64/boot/dts/mediatek/mt6795-sony-xperia-m5.dts:104.21-109.4: Warning >> (unit_address_format): /soc/i2c@11010000/accelerometer@0x10: unit name should not >> have leading "0x" >> arch/arm64/boot/dts/mediatek/mt6795-sony-xperia-m5.dts:111.20-114.4: Warning >> (unit_address_format): /soc/i2c@11010000/magnetometer@0x12: unit name should not >> have leading "0x" >> arch/arm64/boot/dts/mediatek/mt6795-sony-xperia-m5.dts:104.21-109.4: Warning >> (i2c_bus_reg): /soc/i2c@11010000/accelerometer@0x10: I2C bus unit address format >> error, expected "10" >> arch/arm64/boot/dts/mediatek/mt6795-sony-xperia-m5.dts:111.20-114.4: Warning >> (i2c_bus_reg): /soc/i2c@11010000/magnetometer@0x12: I2C bus unit address format >> error, expected "12" >> > > Matthias, should I send new versions of the commits, addressing this sad overlook > from my side, or would you fix that, or should I send new commits cleaning that up > on top? > > Please let me know how to proceed here. > > Thanks, > Angelo >