From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751911AbcFYA5L (ORCPT ); Fri, 24 Jun 2016 20:57:11 -0400 Received: from megous.com ([83.167.254.221]:33817 "EHLO xff.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751842AbcFYA5I (ORCPT ); Fri, 24 Jun 2016 20:57:08 -0400 Subject: Re: [PATCH 03/14] thermal: Add support for sun8i THS on Allwinner H3 To: Chen-Yu Tsai References: <20160623192104.18720-1-megous@megous.com> <20160623192104.18720-4-megous@megous.com> Cc: dev , linux-arm-kernel , open list , "open list:THERMAL" From: =?UTF-8?Q?Ond=c5=99ej_Jirman?= Message-ID: <7dd9107e-c9ec-595f-4c7d-6226c049a6aa@megous.com> Date: Sat, 25 Jun 2016 02:56:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QACmJNw8OtAwAvBPND6OTVELwvo6CUAFr" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QACmJNw8OtAwAvBPND6OTVELwvo6CUAFr Content-Type: multipart/mixed; boundary="aNfoO1CmeJr3mgOvVcjA2lJgnsDC1Flxt" From: =?UTF-8?Q?Ond=c5=99ej_Jirman?= To: Chen-Yu Tsai Cc: dev , linux-arm-kernel , open list , "open list:THERMAL" Message-ID: <7dd9107e-c9ec-595f-4c7d-6226c049a6aa@megous.com> Subject: Re: [PATCH 03/14] thermal: Add support for sun8i THS on Allwinner H3 References: <20160623192104.18720-1-megous@megous.com> <20160623192104.18720-4-megous@megous.com> In-Reply-To: --aNfoO1CmeJr3mgOvVcjA2lJgnsDC1Flxt Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 25.6.2016 02:54, Chen-Yu Tsai wrote: > On Sat, Jun 25, 2016 at 8:35 AM, Ond=C5=99ej Jirman = wrote: >> On 24.6.2016 05:09, Chen-Yu Tsai wrote: >>>> +static int sun8i_ths_h3_init(struct platform_device *pdev, >>>> + struct sun8i_ths_data *data) >>>> +{ >>>> + int ret; >>>> + size_t callen; >>>> + s32 *caldata; >>>> + >>>> + data->busclk =3D devm_clk_get(&pdev->dev, "ahb"); >>>> + if (IS_ERR(data->busclk)) { >>>> + ret =3D PTR_ERR(data->busclk); >>>> + dev_err(&pdev->dev, "failed to get ahb clk: %d\n", r= et); >>>> + return ret; >>>> + } >>>> + >>>> + data->clk =3D devm_clk_get(&pdev->dev, "ths"); >>>> + if (IS_ERR(data->clk)) { >>>> + ret =3D PTR_ERR(data->clk); >>>> + dev_err(&pdev->dev, "failed to get ths clk: %d\n", r= et); >>>> + return ret; >>>> + } >>>> + >>>> + data->reset =3D devm_reset_control_get(&pdev->dev, "ahb"); >>> >>> IIRC with the new shared reset control stuff merged, you are supposed= >>> to specify whether you want a shared or exclusive one when you ask fo= r >>> it. >> >> Here devm_reset_control_get will get the exclusive reference. So this >> should be ok. >=20 > See https://patchwork.kernel.org/patch/9158691/ >=20 > The generic ones might be removed later on. I remember in another threa= d > it was asked that new users should use the explicit API, and avoid havi= ng > to be converted. I see, thank you, I'll change that. regards, Ondrej > ChenYu >=20 >> >> regards, >> Ondrej >> >>> >>> Regards >>> ChenYu >>> >>>> +MODULE_LICENSE("GPL v2"); >>>> -- >>>> 2.9.0 >>>> >> --aNfoO1CmeJr3mgOvVcjA2lJgnsDC1Flxt-- --QACmJNw8OtAwAvBPND6OTVELwvo6CUAFr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXbdbbAAoJEG5kJsZ3z+/xpDwQAI19Rbn7tn74fr7EXf1KW1zw xb0mCCoFY93GfRX915optRBeMz64O5nild+kOYg8HaopH8tEWG/ivAta0g7DBhQT 6Yj3GM/wlVS4pP6uOY+ZJdrhWxB6nmM7GsOD2DGbk9O5PG1rGLFjSo72JBqhAXQE rc7EW5ME5mw3ZDgdbRhJbxVNEsseiGq45f66EpUA3WTpUWY2pCTx7ckuNj7uZRu5 CvmIeDcDd+r9uss8s2D/jtM/cIx2/nkbbFSeo+Twkdr6hvAOZ7BabRTG+e9ozumg Ge3PRWDL5nFR2L/IBWQiJNpEtgmMpJKMq7Eex+vPygWj1u4dYOHvm+8QFNYnUAaU GwZa1eJloRdnDl73as7EYQAGA501uX/4k2C2PtQyzkwOPHr5WoozI+Md0dZts93q ccjhRljhpO6O02HEFu+p5z39MQT/RsvdAreDycgGC1/lIO639LalX1TXpvAZU7ri Y+zfSxkcaU4DOUr1Lvlv5MsN2IDBWbcxbYeL0Z4vEdrTRmvpo87nkDVQ0Q7knhXe Z8XfCfd/ilxP4GhuVKDU/CGY2g5CYSkD8FQm52n58xauXBtbtPCZ3P7eZB93nJ5+ AQ0Rq/T+wJI5uVVysuyb/TiaTGjzOrTOJRETqrPns14XrUdoQH/Ivcx4pG1jhICd Gi4ORrJeWI2X4rscNbww =jcVW -----END PGP SIGNATURE----- --QACmJNw8OtAwAvBPND6OTVELwvo6CUAFr--