From: Finn Thain <fthain@linux-m68k.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>,
Kees Cook <keescook@chromium.org>, Arnd Bergmann <arnd@arndb.de>,
Michael Ellerman <mpe@ellerman.id.au>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] macintosh: fix via-pmu and via-cuda build errors
Date: Thu, 7 Apr 2022 17:31:03 +1000 (AEST) [thread overview]
Message-ID: <7ddb26a1-be89-813f-8dcc-4bebaf8f5636@linux-m68k.org> (raw)
In-Reply-To: <20220407023700.7216-1-rdunlap@infradead.org>
On Wed, 6 Apr 2022, Randy Dunlap wrote:
> When CONFIG_RTC_CLASS is not set, rtc_tm_to_time64() is not defined.
>
> ...
>
> m68k-linux-ld: drivers/macintosh/via-pmu.o: in function `pmu_set_rtc_time':
> drivers/macintosh/via-pmu.c:1758: undefined reference to `rtc_tm_to_time64'
> m68k-linux-ld: drivers/macintosh/via-cuda.o: in function `cuda_set_rtc_time':
> drivers/macintosh/via-cuda.c:797: undefined reference to `rtc_tm_to_time64'
>
> ...
> This is a big hammer type of patch. We could possibly do (a) some
> conditional code blocks for RTC_CLASS
rtc_tm_to_time64() call sites also appear in several other files without
conditionals:
arch/powerpc/kernel/time.c
arch/powerpc/platforms/8xx/m8xx_setup.c
arch/powerpc/platforms/maple/time.c
arch/powerpc/platforms/powermac/time.c
Why not use mktime64() instead? That seems to be a common pattern for this
kind of thing (without needing conditional code).
prev parent reply other threads:[~2022-04-07 7:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 2:37 Randy Dunlap
2022-04-07 3:16 ` Randy Dunlap
2022-04-07 7:14 ` Christophe Leroy
2022-04-07 7:41 ` Finn Thain
2022-04-07 7:22 ` Christophe Leroy
2022-04-07 7:31 ` Finn Thain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ddb26a1-be89-813f-8dcc-4bebaf8f5636@linux-m68k.org \
--to=fthain@linux-m68k.org \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=geert@linux-m68k.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkp@intel.com \
--cc=mpe@ellerman.id.au \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®