From: Andrew Lunn <andrew@lunn.ch>
To: Jinjie Ruan <ruanjinjie@huawei.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>, Nishanth Menon <nm@ti.com>,
ssantosh@kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, jic23@kernel.org
Subject: Re: [PATCH -next v2 2/4] soc: ti: knav_dma: Use dev_err_probe() to simplfy code
Date: Sat, 31 Aug 2024 20:53:14 +0200 [thread overview]
Message-ID: <7ddd1e8f-7c33-42cc-9994-d251c63fddcb@lunn.ch> (raw)
In-Reply-To: <5ba9c21f-acfa-7c89-a358-b52aa9ecedd3@huawei.com>
> > Fine but not much useful and at the same time huge churn from @vivo.com.
>
> I see, it is fine with these dev_err_probe() dropped, the main is the
> scoped child iterate.
Which is also a lot of churn.
How about you start with those that are actually broken, missing a
put. Those changes are useful. Changing code which is already correct
has a lot less value.
Andrew
next prev parent reply other threads:[~2024-08-31 18:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 6:32 [PATCH -next v2 0/4] soc: ti: Simplify with scoped for each OF child loop and dev_err_probe() Jinjie Ruan
2024-08-30 6:32 ` [PATCH -next v2 1/4] soc: ti: knav_dma: Simplify with scoped for each OF child loop Jinjie Ruan
2024-08-30 6:32 ` [PATCH -next v2 2/4] soc: ti: knav_dma: Use dev_err_probe() to simplfy code Jinjie Ruan
2024-08-30 10:31 ` Nishanth Menon
2024-08-30 10:36 ` Krzysztof Kozlowski
2024-08-30 10:42 ` Krzysztof Kozlowski
2024-08-31 1:59 ` Jinjie Ruan
2024-08-31 5:21 ` Krzysztof Kozlowski
2024-08-31 6:27 ` Jinjie Ruan
2024-08-31 18:53 ` Andrew Lunn [this message]
2024-09-03 13:40 ` Uwe Kleine-König
2024-08-30 6:32 ` [PATCH -next v2 3/4] soc: ti: knav_qmss_queue: Simplify with scoped for each OF child loop Jinjie Ruan
2024-08-30 6:32 ` [PATCH -next v2 4/4] soc: ti: knav_qmss_queue: Simplify with dev_err_probe() Jinjie Ruan
2024-08-30 10:38 ` Nishanth Menon
2024-08-31 11:06 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ddd1e8f-7c33-42cc-9994-d251c63fddcb@lunn.ch \
--to=andrew@lunn.ch \
--cc=jic23@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=ruanjinjie@huawei.com \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®