mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Alex Tran <alex.t.tran@gmail.com>
Cc: lgirdwood@gmail.com, tiwai@suse.com, perex@perex.cz,
	shenghao-ding@ti.com, kevin-lu@ti.com, baojun.xu@ti.com,
	linus.walleij@linaro.org, brgl@bgdev.pl,
	linux-sound@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ASoC: codecs: tlv320dac33: switch to gpiod api
Date: Mon, 1 Sep 2025 11:35:35 +0100	[thread overview]
Message-ID: <7de59d85-a72e-4afa-b3d7-8729e22f4c3f@sirena.org.uk> (raw)
In-Reply-To: <20250901035956.1195081-1-alex.t.tran@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1133 bytes --]

On Sun, Aug 31, 2025 at 08:59:56PM -0700, Alex Tran wrote:
> Changelog:
> - Changed reset GPIO setup that uses 'gpio_request' and
>   'gpio_direction_output' to use 'devm_gpio_request_one' instead 
>   for legacy support.
> - Convert to gpio descriptor for use.
> - Better error handling with 'gpiod_set_value'.
> - Removed cleanup of reset gpio as gpiod api is now used.
> 
> 
> - Performed full conversion to gpiod with 'devm_gpiod_get_optional'.
> - Removed struct 'tlv320dac33_platform_data' as it is
>   not used in the kernel.
> - Removed file 'tlv320dac33-plat.h' as it was not included
>   anywhere outside this driver.
> - Removed 'power_gpio' and added 'reset_gpiod'.
> - Added default value for dac33->burst_bclkdiv as it can't be 0 (2-17).
>   See <https://www.ti.com/lit/ds/symlink/tlv320dac32.pdf>

This is a set of separate changes which as covered in
submitting-patches.rst should each be split into individual patches,
this makes things much easier to review.

As also covered in submitting-patches.rst any inter-version changelogs
should go after the --- so they can be removed by tooling.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2025-09-01 10:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-01  3:59 Alex Tran
2025-09-01 10:35 ` Mark Brown [this message]
2025-09-01 18:09   ` Alex Tran
2025-09-01 16:35 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7de59d85-a72e-4afa-b3d7-8729e22f4c3f@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alex.t.tran@gmail.com \
    --cc=baojun.xu@ti.com \
    --cc=brgl@bgdev.pl \
    --cc=kevin-lu@ti.com \
    --cc=lgirdwood@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=shenghao-ding@ti.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®