From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761969AbcJ1VLi (ORCPT ); Fri, 28 Oct 2016 17:11:38 -0400 Received: from mail-wm0-f47.google.com ([74.125.82.47]:36713 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756712AbcJ1VLh (ORCPT ); Fri, 28 Oct 2016 17:11:37 -0400 Subject: Re: [PATCH 2/3] ASoC: lpass-platform: Fix broken pcm data usage To: Mark Brown References: <1477668740-30389-1-git-send-email-srinivas.kandagatla@linaro.org> <1477668740-30389-3-git-send-email-srinivas.kandagatla@linaro.org> <20161028182644.nbsbm6h7fcj3rlcj@sirena.org.uk> Cc: alsa-devel@alsa-project.org, Banajit Goswami , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , linux-kernel@vger.kernel.org, Kenneth Westfield , Kuninori Morimoto From: Srinivas Kandagatla Message-ID: <7de5b48a-c3e4-0111-b21d-4d733786b5d9@linaro.org> Date: Fri, 28 Oct 2016 22:11:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161028182644.nbsbm6h7fcj3rlcj@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/10/16 19:26, Mark Brown wrote: > On Fri, Oct 28, 2016 at 04:32:19PM +0100, Srinivas Kandagatla wrote: >> This patch fixes lpass-platform driver which was broken in v4.9-rc1. >> lpass_pcm_data data structure holds information specific to stream. >> Holding a single private pointer to it in global lpass_data >> will not work, because it would be overwritten by for each pcm instance. > > This is a bug fix but you've made it depend on patch 1 which is just a > refactoring and should therefore not be sent to Linus as a fix. Please > don't do this, fix bugs first then do any cleanups and new > functionality. That way we can send fixes to Linus without needing to > pull in extra stuff. Sorry about that, I will resend the fix patch without any dependencies. Thanks, srini >