From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E9823FF887 for ; Wed, 13 May 2026 11:40:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778672423; cv=none; b=WILw980cR8gLqvQmOgoTWuKKM3J35Vos49Oert57AKJHMnd47N12B3I0WCzAiWWbEbZP0EY/LxiP3QiYgJu3EQGub/BRYTSwLybkka68KR2cIaaaLx5d58gDjtUnbqySiIq0hHJOaRUOe3YMNxai7AemhR2rsoT7I6jtoxVjGKM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778672423; c=relaxed/simple; bh=eMf2CLDG44C1jZ2p7u/edjuiS9xo64r85ao5+r/5ux4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jVPKj75xhZkitYH38GC6rB9R2LlLqmFGCUAsS/6SHPZ6X/ziEiIRZb1/XtHGoxa6FDnfjAOpehtJbfPDzwwAryYoViuwE5lX2mmLu4ZQmE6A8oGBFObddnFGFyBWF1meUXlv+yNaLcdTBjquPcJLLwWDRc+G/s1WbhoAY8IYYpk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=starlabs.systems; spf=pass smtp.mailfrom=starlabs.systems; dkim=pass (2048-bit key) header.d=starlabs-systems.20251104.gappssmtp.com header.i=@starlabs-systems.20251104.gappssmtp.com header.b=l4CWWQCP; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=starlabs.systems Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=starlabs.systems Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=starlabs-systems.20251104.gappssmtp.com header.i=@starlabs-systems.20251104.gappssmtp.com header.b="l4CWWQCP" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-48984d29fe3so71072915e9.0 for ; Wed, 13 May 2026 04:40:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=starlabs-systems.20251104.gappssmtp.com; s=20251104; t=1778672420; x=1779277220; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kQFvj5LmJIGIKjgLPEHd0VQ/ZMItSCOV0/e8nhf5n6k=; b=l4CWWQCPcZu7yzn0CNg+J78xhQ1MJumppuDVdKvB3ZSESP/0igH+6wdDyANWFqrlz/ 2tg9mrl2rVuy/V2CM9JvJylxKNyzvZEmhQAqxXgbUIZK1sNHBSoXdKwnE0PVOdv36BOP KXjMY3axE/H1eq/LltiRpPLLy3Ry6nr4xUYKK9XSq7H7wjac7Skh02I/NX0H2jehvigN tOOTjAtB2x6MPJZRSa7j0IJ5A/h2IeoVIVCVNtvo/uFTPqoCaYubCzc9SK6rnn0tkQbk Qyb00Cdy5nNpvJ412kE2agc0KrdgZc0bczbd2oAGHu/+6RnJG2QnSfC4ovNaan1dPJce 6L+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778672420; x=1779277220; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kQFvj5LmJIGIKjgLPEHd0VQ/ZMItSCOV0/e8nhf5n6k=; b=j4Df5WPACQEaJ/uMB+5m5VUJ9vfgqzOVF965+6yjYCUaOEAF1UdpM6yxny1AgTQn// PmkglKWpX+AdkUxxdi1qzFc0AJc1vyfhsNz5KBTg4NpQ1yJ/2pGx2051ed2JwyW7SlF+ oNmhD9cjMgDXY4xj7ZMeCnMUI7wcgmSW7/yDemzgEHcmggNewZR9ZWapj1/U9U+f+8k4 6fQrtdG23+XTetpDPhyXJo2Ksfb9YX9qi6jPCVE4VhY0K3Ji3Jk5439r8l9Pv6U9CQdH +jUBs81Ib7NpaQI9p2PuGPUjSwFeJxPiPOt6Q5mOGnFxvzb7HgzK9GR0t8ERN95GKx2V fb5w== X-Forwarded-Encrypted: i=1; AFNElJ9VzNeU1tgzy1+OgoOkmd0hPC55RvQdgs71+4e4MOFlhWKOvMypAVKgO+0lZgxhit3UUfGXXamOashdPlI=@vger.kernel.org X-Gm-Message-State: AOJu0YyW7N5YI9TylBslpBTLe5OLJ/z2e8lKDt0r1KGhUWgEEXxffzQR bh61Ue2sNqVtNt/RE8Ntc9Q4m1GllRDuMidOhYedqgKMIcKCcvxkAO9nFRH2bv8Shg== X-Gm-Gg: Acq92OHS9P1uSfsAZMTIAkZHlgTBsM9B+1WGENXfEoyS51HKeuzMAIdezmXO1Zh6pUA +sos0Cj/vHDmnRPRM/WDhH0Pc34SW5+XGakE/od22NIrUAd7TihmtZ2mwTVueg0EY83aVro1iFI UdQSZBsQlUwhTu2w/Zl5PYiFom+/8rK290uJtK7rljnkssZ/ZI8IMRbmIrq+FxNumCpXSxNlnPG sHomaqC0dSCzaGAyiZeGHQNLKsV9p1Dm8bOczgP1IYa1ojS+oD38K/YNUvUSTi4/429BQ/jRaVD 6JIwd+HtlcpUzDHlhX+w+sskoHXHmE+6wgOfYJeYKTfIaboQwIbJlHwE9/825w2BhLJ6L70mOas o27WC1L/F70X8iKMxkGwP/qKKobPOY887JiiyJixc6edfC+W8V8WJUH9qgwqC/M504mdbDh8G1D 7O5P6UWetg3W9sFYNGLyZg8R4edO0DwncnBIKRv/UMz33Jbc51Er95sK61XE2NDfTnVbIz X-Received: by 2002:a05:600c:6303:b0:48a:592c:e632 with SMTP id 5b1f17b1804b1-48fc9a2b921mr44740155e9.16.1778672419876; Wed, 13 May 2026 04:40:19 -0700 (PDT) Received: from horizon.localdomain ([212.105.128.254]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fcdf64013sm53508475e9.2.2026.05.13.04.40.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2026 04:40:19 -0700 (PDT) From: Sean Rhodes To: Ulf Hansson Cc: Ricky Wu , Avri Altman , Sean Rhodes , Jisheng Zhang , Nathan Chancellor , Dan Carpenter , Binbin Zhou , linux-mmc@vger.kernel.org, Huacai Chen , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, gregkh@linuxfoundation.org, arnd@arndb.de, ulf.hansson@linaro.org, adrian.hunter@intel.com, rogerable@realtek.com, matthew.schwartz@linux.dev Subject: [RFC PATCH 2/2] mmc: rtsx_usb_sdmmc: start card power-up at 3.3V Date: Wed, 13 May 2026 12:40:13 +0100 Message-ID: <7de637dbc99f1c2dc40cd255b078de9f1efd1ccb.1778672403.git.sean@starlabs.systems> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Some tray-based readers keep SD_CD asserted even without a card. The rtsx_usb_sdmmc driver now validates insertion with a minimal probe sequence. That probe must start with the SD pads in 3.3V mode. Like the old rts5139 driver (sd_init_power()), force the SD pads to 3.3V and tune the SD18 regulator to 3.3V before powering up the card. This avoids spurious probe timeouts when the reader is left in 1.8V from a previous UHS session. Tested: Realtek RTS5129 (0bda:0129) + tray + Lexar 2TB SDXC Tested: cold boot detects mmcblk0 (2026-02-24) Tested: hotplug insert enumerates mmcblk0 (2026-02-23) Signed-off-by: Sean Rhodes --- drivers/mmc/host/rtsx_usb_sdmmc.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/mmc/host/rtsx_usb_sdmmc.c b/drivers/mmc/host/rtsx_usb_sdmmc.c index ec3eeea78e95..6be98926387d 100644 --- a/drivers/mmc/host/rtsx_usb_sdmmc.c +++ b/drivers/mmc/host/rtsx_usb_sdmmc.c @@ -1108,6 +1108,11 @@ static int sd_power_on(struct rtsx_usb_sdmmc *host) } dev_dbg(sdmmc_dev(host), "%s\n", __func__); rtsx_usb_init_cmd(ucr); + /* Start SD init at 3.3V, like the old rts5139 driver. */ + rtsx_usb_add_cmd(ucr, WRITE_REG_CMD, SD_PAD_CTL, + SD_IO_USING_1V8, SD_IO_USING_3V3); + rtsx_usb_add_cmd(ucr, WRITE_REG_CMD, LDO_POWER_CFG, + TUNE_SD18_MASK, TUNE_SD18_3V3); rtsx_usb_add_cmd(ucr, WRITE_REG_CMD, CARD_SELECT, 0x07, SD_MOD_SEL); rtsx_usb_add_cmd(ucr, WRITE_REG_CMD, CARD_SHARE_MODE, CARD_SHARE_MASK, CARD_SHARE_SD);