mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: Javier Martinez Canillas <javierm@redhat.com>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	linux-kernel@vger.kernel.org
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>,
	"Pekka Paalanen" <pekka.paalanen@collabora.com>,
	"Hans de Goede" <hdegoede@redhat.com>,
	"David Airlie" <airlied@linux.ie>,
	"Daniel Vetter" <daniel.vetter@ffwll.ch>,
	dri-devel@lists.freedesktop.org,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	amd-gfx@lists.freedesktop.org,
	"Gurchetan Singh" <gurchetansingh@chromium.org>,
	"Ben Skeggs" <bskeggs@redhat.com>,
	"VMware Graphics" <linux-graphics-maintainer@vmware.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	spice-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Dave Airlie" <airlied@redhat.com>,
	"Christian König" <christian.koenig@amd.com>,
	virtualization@lists.linux-foundation.org,
	intel-gfx@lists.freedesktop.org,
	"Michel Dänzer" <michel@daenzer.net>,
	"Peter Robinson" <pbrobinson@gmail.com>
Subject: Re: [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled
Date: Fri, 5 Nov 2021 14:00:23 +0100	[thread overview]
Message-ID: <7de8c495-7e01-98f9-71c7-9168d51733c3@suse.de> (raw)
In-Reply-To: <335a9e0f-cce9-480b-10e0-bd312b81e587@redhat.com>


[-- Attachment #1.1: Type: text/plain, Size: 1372 bytes --]

Hi

Am 05.11.21 um 13:00 schrieb Javier Martinez Canillas:
> On 11/5/21 11:04, Jani Nikula wrote:
>> On Fri, 05 Nov 2021, Javier Martinez Canillas <javierm@redhat.com> wrote:
> 
> [snip]
> 
>>>
>>> Do you envision other condition that could be added later to disable a
>>> DRM driver ? Or do you think that just from a code readability point of
>>> view makes worth it ?
>>
>> Taking a step back for perspective.
>>
>> I think there's broad consensus in moving the parameter to drm, naming
>> the check function to drm_something_something(), and breaking the ties
>> to CONFIG_VGA_CONSOLE. I appreciate the work you're doing to that
>> effect.
>>
> 
> Thanks, I appreciate your feedback and comments.
>   
>> I think everything beyond that is still a bit vague and/or
>> contentious. So how about making the first 2-3 patches just that?
>> Something we can all agree on, makes good progress, improves the kernel,
>> and gives us something to build on?
>>
> 
> That works for me. Thomas, do you agree with that approach ?

Sure. I think that's more or less what I proposed in my reply to that mail.

Best regards
Thomas

>   
> Best regards,
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

  reply	other threads:[~2021-11-05 13:01 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-04 16:07 [PATCH v2 0/2] Cleanups for the nomodeset kernel command line parameter logic Javier Martinez Canillas
2021-11-04 16:07 ` [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled Javier Martinez Canillas
2021-11-04 16:24   ` Jani Nikula
2021-11-04 16:44     ` Javier Martinez Canillas
     [not found]   ` <YYQaYsCr+piMlRpS@ravnborg.org>
2021-11-04 17:57     ` Jani Nikula
2021-11-04 18:20       ` Javier Martinez Canillas
     [not found]         ` <YYQ0doL/F3ULjXyr@ravnborg.org>
2021-11-04 19:54           ` Jani Nikula
2021-11-04 19:57   ` Jani Nikula
2021-11-04 20:09     ` Javier Martinez Canillas
2021-11-05  8:43       ` Thomas Zimmermann
2021-11-05  9:48         ` Javier Martinez Canillas
2021-11-05 10:04           ` Jani Nikula
2021-11-05 12:00             ` Javier Martinez Canillas
2021-11-05 13:00               ` Thomas Zimmermann [this message]
2021-11-05 10:15           ` Thomas Zimmermann
2021-11-04 16:07 ` [PATCH v2 2/2] drm: Move nomodeset kernel parameter to the DRM subsystem Javier Martinez Canillas
2021-11-05  9:00   ` Thomas Zimmermann
2021-11-05  9:22     ` Jani Nikula
2021-11-05  9:39       ` Thomas Zimmermann
2021-11-05  9:58         ` Javier Martinez Canillas
2021-11-05  9:55     ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7de8c495-7e01-98f9-71c7-9168d51733c3@suse.de \
    --to=tzimmermann@suse.de \
    --cc=Xinhui.Pan@amd.com \
    --cc=airlied@linux.ie \
    --cc=airlied@redhat.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=bskeggs@redhat.com \
    --cc=christian.koenig@amd.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gurchetansingh@chromium.org \
    --cc=hdegoede@redhat.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=javierm@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=linux-graphics-maintainer@vmware.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michel@daenzer.net \
    --cc=nouveau@lists.freedesktop.org \
    --cc=pbrobinson@gmail.com \
    --cc=pekka.paalanen@collabora.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=spice-devel@lists.freedesktop.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®