From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97C452F1FC7 for ; Tue, 9 Jun 2026 10:17:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781000225; cv=none; b=ImRB1Gwjj/yB0DUox8Xo/xqEV3qMweF93OxYIlTdmxZf62asUKxubQ2u7PHBGHQePL3uLsFS5NblLWBuhQsaXLtMXjJjuS6perxZ/hUOFiJCE4eirVc8Z2NtR0/MnIi6J1KxvS++/1voF8XTnooQfpAN7Dw8RyxRcdm+pbqpFQI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781000225; c=relaxed/simple; bh=60lbSBPHLuPejyGJzFkNlNTtgRn0AxS2NaXpKwq4/9w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tcLdW3TFtXGXjKF/fNsFaneRc3OHZ/N5HH/l56uGlfsfsjnKU/esOJc4DvH+9lscu2ai7WDI82hyEZKAA6151zff4sadiAPI+EJ/9pgqfV74ALbhAFadXJMmjWV+kvh4jqz0Tm7onQq4tbFmgqfuUe/FGz1oFN5zKcwCIfCGyEk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nlgDO/26; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=V5+VleG3; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nlgDO/26"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="V5+VleG3" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6599xBsx2312336 for ; Tue, 9 Jun 2026 10:17:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= JudsusfDtbrr44rlxP7/oBk73rfyE1SdPB/IQf+KXPc=; b=nlgDO/26oEBjtB33 e3LXmHI/I+uVAz0axQLW9DaSUmE5W2QolchARMtMAxaOv5oCsHMA9BanvXAn2rgj Rzq5mUiXmTCa4pNfaKyjrBpcgC3ZoMpdJXTtJre1w8HVbEU3n7lQQn2jEG7xbHEv NtjSa71NrurmuRmGEnKlHmteCs0fRGu6YYOy/BtMQx4mmJJaeduh8RSvYmcUU3R/ L7hLmQ0bL2KGK9Od26tveYRWJxYm4N64xOciOSvHhfXkrW+FXFktHpi5TlLYrYAG opVIE8rTihmgBAAboS14MA8z98EGrJ4UFyS7mWuyMX7NVPm0Gnomn33MTNELmDnm /PNbBQ== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4epg3v076w-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 09 Jun 2026 10:17:03 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-36d97a4e08fso5013660a91.0 for ; Tue, 09 Jun 2026 03:17:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781000222; x=1781605022; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JudsusfDtbrr44rlxP7/oBk73rfyE1SdPB/IQf+KXPc=; b=V5+VleG32ERvBmUt0YSAraRb5W3R5M+snEPbUaVDV/8Sm+8/2FDbw1ECKCqC3TUCPm dItXu3aLGTJZ6nULo/IdKg9rdCnF3FKTX7/M1DAjVU5DeKyNUNujI/95O0KQA5bUFNEJ +ypE0bb+YTiHaH4pqH8Ibz/yzgho45pzVfHeZhXAXZRuIy4A16imFcBBFVqfAwZG4HQw 0R4cxBCfVzgwW5NszIlgNxwDdahl0ADGzV5nJw6LmzrWQv/kSA4B8dSPaN+KK2TqBvTS eUI9qN5hnejS1IEXN10tLdGpZkeQKPFE2j1j2iVmFvyEc8/czNjiMBa/W5ujm44/iv3t 9+gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781000222; x=1781605022; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JudsusfDtbrr44rlxP7/oBk73rfyE1SdPB/IQf+KXPc=; b=bmX8TwekMesdqYl+xEIUjUmMviIwOu15BsKanVk6ShFS1Q+Ib6PjaiX+hze3QNG9bP +MKB3INJ9A+PQkT9ZR+d4blfBfVO3YTh9AHhElfnE6vS6HdtKlgeT4LScoCXcTI4cOAc X7FCW/6XxDrFYwQhjXBqmxCwkLSViXYOTunrJa/lc/BnVwWVedcsRCZgL2KsV4jtBKHI po8BYyYT4DsflpT7DaZAp1g3GufQisah8qPU8oW3IfunTMhHsOWqx3xZP79bHtHu/aqE zkZ3rsQU9DPs8p2VeKX6M9S+9kpt1nlfhJXSdw9YmrripnNLqJh9hiVV1v8B8cdHF3c/ pyjg== X-Forwarded-Encrypted: i=1; AFNElJ9A/Hv2LVf24MROFAZbvoZgYZLpwrDJzWrOEliGQPHroGYL3DdC4VxTEbDuBiL3aSt0K3XiWvB2A2k+368=@vger.kernel.org X-Gm-Message-State: AOJu0YxEuSNQES+UnWpEKMVVEBwXFZdW4a0b6mvWEp2i25wSEJymytrj Su5GZvJ0LgTxmfjveSnGWwYeMmyefZymD02rpWkiJEgN/lArFjtkOALvVxHuSvQfuOdV1Ue2Pso CqbsSpLxRDqg/gRATMyvHuEeILHATwkkzLAzIpRKGl0rk4MRZ4LjFzdwi4zvvjlmFXuE= X-Gm-Gg: Acq92OHCy2wFzlXQ2vABluYRt+R6TjBnIPpPsZR0qlyA4lz5h4C6P81ac8U0Srq1yyN Ed6PGOQkHksQqKxE8428XLJ6nrjucxG6NXMvRgjN88oDtt3qfuDyRXIuMvi9AYyHyVshmWBkt+Z COcH4FcgU/QXINxjNN2lZ97S7X6mgCwwjkFXvFwFiT9KKUC901eyCXZurdCY+Gh+F0zzh0FLAY6 BDBhI+gyZdq58Psprtz063BpIN6jaG4U6Ycv99MBQwceDM4kgztXwTRlaIVhWmxF+cGeKTt0bnV agcJnyRznaP4y6/fm5XbeGpkNthoGVPmwGIUdSUg4OLYlqVPtTLDtHFMJOsDicdz6RH/y/OmOi0 hv6hzz7p2gl1Zvn6KhYgAjJyd8uUp9ee7bz16tElGwtXNP7CxbAZQMqvjutXUTPIx1GdiW8jg70 Sd X-Received: by 2002:a05:6a20:9398:b0:3b4:640e:f6c0 with SMTP id adf61e73a8af0-3b4ccd77534mr18165469637.13.1781000222561; Tue, 09 Jun 2026 03:17:02 -0700 (PDT) X-Received: by 2002:a05:6a20:9398:b0:3b4:640e:f6c0 with SMTP id adf61e73a8af0-3b4ccd77534mr18165419637.13.1781000222095; Tue, 09 Jun 2026 03:17:02 -0700 (PDT) Received: from [10.151.37.217] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c85df0b374fsm17704239a12.25.2026.06.09.03.16.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jun 2026 03:17:01 -0700 (PDT) Message-ID: <7def2ccd-0319-4f85-8275-73fd254d887d@oss.qualcomm.com> Date: Tue, 9 Jun 2026 15:46:56 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] phy: qcom: qmp-pcie: Add IPQ9650 PCIe PHY support To: Dmitry Baryshkov Cc: Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260602-ipq9650_pcie_phy-v1-0-d8c32a36dbd9@oss.qualcomm.com> <20260602-ipq9650_pcie_phy-v1-2-d8c32a36dbd9@oss.qualcomm.com> <56zkq7bwrt5smmmum6jckzrekkkqrych2gntx3obnrmamwumtv@espahwe6pc3v> Content-Language: en-US From: Kathiravan Thirumoorthy In-Reply-To: <56zkq7bwrt5smmmum6jckzrekkkqrych2gntx3obnrmamwumtv@espahwe6pc3v> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=St6gLvO0 c=1 sm=1 tr=0 ts=6a27e81f cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=qlr8FlQxwEk1uUl_DVUA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-ORIG-GUID: DWja_XD6ZBv0PS6AowCO5TivFF3C0G-1 X-Proofpoint-GUID: DWja_XD6ZBv0PS6AowCO5TivFF3C0G-1 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA5MDA5NSBTYWx0ZWRfX9+pwYzqsd81R AZ7wRwSyHctZYj6k6U26tanMemXOlQj3df2KuQyjhZQ1DWXeBRA+EOkqdvcIgKcBOwJb0c1hfLZ ZGNpcsPSC8eSJ6GCqG+c5FsJ/GmZSU/EHQS87FgEdBgeDoRW+8W/QFXiTrNAAmGWO2XaaVEtZ7/ eb62189bUTYmHG5g5E/kJPZ5mQDsuHi2ErhccgjGnW/SM8fdrZYDXjv59Tf5jsvd+C/z9P114XR mhyx0tMkTPEg9s4WNjj/I+gpC1j2FPfB6bmUawR0ROEWSNueY3JIPt/xxapKCAz2LJ4kDiJcxzv eEl7ve1h9tXi2Y5qMXRtZmSuPsgBI705VDrsKckvZ2mDsx4Acyg48WrqRf2MbblCzyAgiOQKjR8 bTnk7WAiJyTBK14tm7YasTnwg0aQfMsXLsFdRXDbLdXWGk4gnjHYQidx+kMwjcCa5lUx+mTenE/ ehf8nEYQ45iNDNo6V0Q== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-09_02,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 suspectscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 bulkscore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606090095 On 6/8/2026 12:26 PM, Dmitry Baryshkov wrote: > On Tue, Jun 02, 2026 at 02:40:18PM +0530, Kathiravan Thirumoorthy wrote: >> The IPQ9650 platform has three Gen3 2-lane PCIe controllers and two Gen3 >> 1-lane PCIe controllers. The PHY instances also require the on-chip refgen >> supply. >> >> Add the IPQ9650 Gen3 x1 and x2 QMP PCIe PHY configurations, including the >> refgen regulator supply. >> >> Signed-off-by: Kathiravan Thirumoorthy >> --- >> drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 220 +++++++++++++++++++++++++++++++ >> 1 file changed, 220 insertions(+) >> >> @@ -3378,6 +3524,10 @@ static const char * const qmp_phy_vreg_l[] = { >> "vdda-phy", "vdda-pll", >> }; >> >> +static const char * const ipq9650_qmp_phy_vreg_l[] = { >> + "refgen", >> +}; > Now vdda-phy / vdda-pll supplies? Cross checked with HW team again. Along with refgen, there is a on-chip LDO which supplies fixed voltage to the PHYs. It is enabled upon system power on and no SW intervention is required. regulator-fixed doesn't take the resource 'reg'. May be should I create another regulator driver which accepts 'reg', something similar to the qcom-refgen-regulator? Please advise. > >> + >> static const char * const sm8550_qmp_phy_vreg_l[] = { >> "vdda-phy", "vdda-pll", "vdda-qref", >> };