From: Tim Tianyang Chen <tianyang.chen@oracle.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, dhaval.giani@oracle.com,
"John 'Warthog9' Hawley" <warthog9@kernel.org>
Subject: Re: [PATCH 1/2][RFC]Ktest: Add email support
Date: Thu, 14 Dec 2017 16:11:25 -0800 [thread overview]
Message-ID: <7def72e8-d30d-b9c0-bb31-1263cfcadfd0@oracle.com> (raw)
In-Reply-To: <20171214183914.7d911500@gandalf.local.home>
Thanks for the review Steven!
> First comment is that the numbered patches need to be a reply to the
> cover patch (that is patches 1/2 and 2/2 need to be replies of 0/2).
> Otherwise, my mailer loses them, because I always have my email sorted
> by threads, and a reply to 0/2 will move it away from the other patches
> if the other patches are not replies.
Not sure what happened. I used --thread option for git send-email, and
in thunderbird I can see all the patches in one thread replying to 0/2.
> Hmm, I'm thinking it doesn't get sent when we hit Ctrl-C. Or at last
> have these as options to when to send them.
>
> I think by default, it should only send when finished, or failed. But
> have options like:
>
> EMAIL_WHEN_STARTED, EMAIL_WHEN_CANCELED (both default false)
> EMAIL_WHEN_FINIHSED and EMAIL_ON_ERROR (both default true).
Yeah. It's a good idea to add them as options.
Thanks,
Tim
prev parent reply other threads:[~2017-12-15 0:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171120173738.34823-2-tianyang.chen@oracle.com>
2017-11-21 18:53 ` Tim Tianyang Chen
2017-12-14 23:39 ` Steven Rostedt
2017-12-15 0:11 ` Tim Tianyang Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7def72e8-d30d-b9c0-bb31-1263cfcadfd0@oracle.com \
--to=tianyang.chen@oracle.com \
--cc=dhaval.giani@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=warthog9@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®