From: Philip Tricca <flihp@twobit.us>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Javier Martinez Canillas <javierm@redhat.com>
Cc: linux-kernel@vger.kernel.org, Peter Huewe <peterhuewe@gmx.de>,
Jerry Snitselaar <jsnitsel@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Philip Tricca <philip.b.tricca@intel.com>,
linux-integrity@vger.kernel.org,
William Roberts <william.c.roberts@intel.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: Re: [PATCH v2] tpm: return a TPM_RC_COMMAND_CODE response if a command isn't implemented
Date: Wed, 29 Nov 2017 17:45:49 -0800 [thread overview]
Message-ID: <7df9ad8d-08b7-2be1-ebd8-874777aaed98@twobit.us> (raw)
In-Reply-To: <20171129175738.pim7is5zc3wmult6@linux.intel.com>
On 11/29/2017 09:57 AM, Jarkko Sakkinen wrote:
> On Wed, Nov 29, 2017 at 12:08:46PM +0100, Javier Martinez Canillas wrote:
>> +#define TPM2_RC_LAYER_SHIFT 16
>> +#define TPM2_RESMGRTPM_RC_LAYER (11 << TPM2_RC_LAYER_SHIFT)
>
> I got this spec from Philip [1].
As part of this I've been doing a pass back over the current draft spec
fixing up all of the places where the we were using 'ERROR_LEVEL',
'RESPONSE_LEVEL' etc interchangeably. Everything will be 'RC_LAYER' in
the next published draft. Apologies if this caused any confusion here
but it looks like Javier was able to work around this regardless Next
time around the spec should be more clear.
Philip
> Couple of remarks:
>
> * What is the difference between TSS2_RESMGR_RC_LAYER and
> TSS2_RESMGR_TPM_RC_LAYER?
> * Should the driver code use TSS2 or TPM2 prefix?
>
> [1] https://trustedcomputinggroup.org/wp-content/uploads/TCG-TSS-2.0-Overview-and-Common-Structures-Specification-Version-0.90-Revision-02.pdf
>
> /Jarkko
>
prev parent reply other threads:[~2017-11-30 1:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 11:08 Javier Martinez Canillas
2017-11-29 17:57 ` Jarkko Sakkinen
2017-11-29 18:24 ` Javier Martinez Canillas
2017-11-30 2:13 ` Philip Tricca
2017-11-30 16:39 ` Jarkko Sakkinen
2017-11-30 16:38 ` Jarkko Sakkinen
2017-11-30 17:21 ` Javier Martinez Canillas
2017-11-30 1:45 ` Philip Tricca [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7df9ad8d-08b7-2be1-ebd8-874777aaed98@twobit.us \
--to=flihp@twobit.us \
--cc=James.Bottomley@HansenPartnership.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=javierm@redhat.com \
--cc=jgg@ziepe.ca \
--cc=jsnitsel@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=philip.b.tricca@intel.com \
--cc=william.c.roberts@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®