From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jonas Karlman <jonas@kwiboo.se>,
Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
Sandy Huang <hjc@rock-chips.com>,
Heiko Stuebner <heiko@sntech.de>,
Andy Yan <andy.yan@rock-chips.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] drm/rockchip: vop: Split rk3288-vop into big and lit
Date: Mon, 23 Sep 2024 17:43:14 +0200 [thread overview]
Message-ID: <7dfc70fa-6076-4bd0-a9d1-2477a5a088e8@kernel.org> (raw)
In-Reply-To: <26ed8563-b6d6-4e72-91a9-f4d5946cef8f@kwiboo.se>
On 23/09/2024 11:01, Jonas Karlman wrote:
>>> 0, 0,
>>> @@ -1245,8 +1253,13 @@ static const struct of_device_id vop_driver_dt_match[] = {
>>> .data = &rk3066_vop },
>>> { .compatible = "rockchip,rk3188-vop",
>>> .data = &rk3188_vop },
>>> + { .compatible = "rockchip,rk3288-vop-big",
>>> + .data = &rk3288_vop_big },
>>
>> Hm... that's not really needed. Instead of having three compatibles, you
>> could keep "rk3288-vop" as big and then my comment on bindings patch
>> could be ignored (you keep the compatible).
>
> Thanks, I guess that just adding a new compatible for vop-lit should be
> enough.
>
> VOP_BIG: rockchip,rk3288-vop
> VOP_LIT: rockchip,rk3288-vop-lit, rockchip,rk3288-vop
>
> That should ensure backward/forward compatibility with any mix of
> old/new boot-firmware, DTs and kernels.
>
> Will change to use that in v2.
Yes, thanks.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-09-23 15:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-21 22:20 [PATCH 0/3] rockchip: Split rk3288-vop compatible " Jonas Karlman
2024-09-21 22:20 ` [PATCH 1/3] dt-bindings: display: rockchip-vop: Split rk3288-vop " Jonas Karlman
2024-09-22 8:12 ` Krzysztof Kozlowski
2024-09-21 22:20 ` [PATCH 2/3] ARM: dts: rockchip: " Jonas Karlman
2024-09-21 22:20 ` [PATCH 3/3] drm/rockchip: vop: " Jonas Karlman
2024-09-22 8:15 ` Krzysztof Kozlowski
2024-09-23 9:01 ` Jonas Karlman
2024-09-23 15:43 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7dfc70fa-6076-4bd0-a9d1-2477a5a088e8@kernel.org \
--to=krzk@kernel.org \
--cc=airlied@gmail.com \
--cc=andy.yan@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®