From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x225KfiXWYNUela37yMXjk+MaTg31S8H5y1KdoHC91AOXaLvvPUsKHrTMx1yu+q3bYcHEL78V ARC-Seal: i=1; a=rsa-sha256; t=1517277967; cv=none; d=google.com; s=arc-20160816; b=pDedbyWhijEJRCa10S+Se+fIpYfuRPwEDsser6ZSoQ/POn23FYNeT02u5WWPvhK2gz AQWXLc6xBPX7tgOeJGh68oJlE+zqzcYVicK+1ukmN2SSdAIdReEXsRZZudH/aZEfA2Rs o5/O0Djqq/xBAUDVqfX89tvEPitSn3f5aqU2EhggI8adl6S1VW9vIcUzA6wqreZv1xNS 5ZFzx8QMqyXhUp4NMm7sUTZsMyLdP/2UMFzJJr4dLnHk/MBpEGNtzaO6Wya/FGIAR6Lz kp1ARtgO7D7TLzR0X++EO1xavBZE//pQ5sPuChLAXI7x2WZzVjVtKHqhccAVenLt8/H9 Xy1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-language:content-transfer-encoding:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :arc-authentication-results; bh=U+pzil65q41tys9yHBN1Z+F+gwoXLI56Y9XE7LFYmDg=; b=RnR/+UDhGhr+P9MTOnmdRJiLkH6Y6SYrFOAKG1t8TG2lSaBbIacGczabj5qBKlLL4r Vqg0vFMrD7EW1KPnwrimMYbt7iXSiaSr2bztJoSTk0SxEtb37uXMiBJoAxtbPP8OKrET tz3OPCyueJXrecIkv2ZAbuDf5ivVnPoXDXQMIftMnSLgl7M7tYjhSGLJ7sDkbiOVMSeu htY2FElvcoHkjw7XvIRCHMUBEWKkQjNqB6hkFUCQ12N/JjFTL0XsgRGajo6cCCHaccba VLFYQswo8MCIEQgf/1ne2J56pevDmvw1qv4Y2LSSJHYsNsOmifaYxL1Co3g65C8ZLfxH FB3g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of richard.gong@linux.intel.com designates 134.134.136.31 as permitted sender) smtp.mailfrom=richard.gong@linux.intel.com Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of richard.gong@linux.intel.com designates 134.134.136.31 as permitted sender) smtp.mailfrom=richard.gong@linux.intel.com X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,433,1511856000"; d="scan'208";a="13574852" Subject: Re: [PATCHv1] Add Intel Stratix10 service layer driver To: Greg KH Cc: arnd@arndb.de, linux-kernel@vger.kernel.org, atull@kernel.org References: <1516898344-20020-1-git-send-email-richard.gong@linux.intel.com> <20180125165352.GA21640@kroah.com> From: Richard Gong Message-ID: <7e01745c-24aa-62f7-0be9-f74f19d6d880@linux.intel.com> Date: Mon, 29 Jan 2018 20:08:11 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180125165352.GA21640@kroah.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590583065067005929?= X-GMAIL-MSGID: =?utf-8?q?1590981261834716457?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Hi Greg, Many thanks for your reviews. On 01/25/2018 10:53 AM, Greg KH wrote: > On Thu, Jan 25, 2018 at 10:39:03AM -0600, richard.gong@linux.intel.com wrote: >> From: Richard Gong >> >> Intel Stratix10 SoC is composed of a 64 bit quad-core ARM Cortex A53 hard >> processor system (HPS) and Secure Device Manager (SDM). SDM is the hardware >> which does the FPGA configuration, QSPI, Crypto and warm reset. >> >> When the FPGA is configured from HPS, there needs to be a way for HPS to >> notify SDM the location and size of the configuration data. Then SDM will >> get the configuration data from that location and perform the FPGA configuration. >> >> To meet the whole system security needs and support virtual machine >> requesting communication with SDM, only the secure world of software (EL3, >> Exception Level 3) can interface with SDM. All software entities running >> on other exception levels must channel through the EL3 software whenever it >> needs service from SDM. >> >> Intel Stratix10 service layer driver is added to provide the service for >> FPGA configuration. Running at privileged exception level (EL1, Exception >> Level 1), Intel Stratix10 service layer driver interfaces with the service >> provider at EL1 (Intel Stratix10 FPGA Manager) and manages secure monitor >> call (SMC) to communicate with secure monitor software at secure monitor >> exception level (EL3). >> >> Later the Intel Stratix10 service layer driver will be extended to provide >> services for QSPI, Crypto and warm reset. >> >> Richard Gong (1): >> driver: misc: add Intel Stratix10 service layer driver >> >> drivers/misc/Kconfig | 3 +- >> drivers/misc/Makefile | 3 +- >> drivers/misc/intel-service/Kconfig | 9 + >> drivers/misc/intel-service/Makefile | 2 + >> drivers/misc/intel-service/intel_service.c | 703 +++++++++++++++++++++++++++++ >> include/linux/intel-service-client.h | 227 ++++++++++ >> include/linux/intel-service.h | 122 +++++ >> include/linux/intel-smc.h | 246 ++++++++++ > Simple questions first: > - why do you have 3 different .h files for a single .c file? This is because service layer driver interface with both the service provider and secure monitor SW. intel-service-client.h is created to define interface between service providers (FPGA manager is one of them) and service layer. Alan Tull's FPGA manager .c file includes this header file intel-smc.h defines the secure monitor call (SMC) message protocols used for service layer driver in normal world (EL1) to communicate with secure monitor SW in secure monitor exception level 3 (EL3). Also this header file is shared with firmware since both (FW, service layer) utilizes the same SMC message protocol. intel-sevice.h is created to define service layer's own data structures (service controller, channel for communicating with service provider, shared memory region, private data etc) > - why do you have any public .h files for a single .c file? intel-service-client.h is public .h and should be at include/linux/ intel-service.h and intel-smc.h are private .h files, should be in driver/misc/ (assume I move .c file from driver/misc/intel-service/ to driver/misc/) > - use the correct SPDX markers for your file licenses, Intel legal > knows all about this, please follow their rules. I will follow those rules. > - why is this in a subdirectory for a single .c file? Currently service layer is implemented to support FPGA configuration only. We have the new requirements and need to extend service layer to support additional features such as QSPI, Crypto and warm reset. It is expected that a few new files will be added later. For now I can move the single .c file from driver/misc/intel-service/ to driver/misc/. Regards, Richard > thanks, > > greg k-h