From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9E8E2F3C22 for ; Mon, 2 Feb 2026 09:58:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.152.168 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770026317; cv=fail; b=qIxlKnHn5Bbm872/+RvQaYCuNAb57tJs5SjDBSCywkpo+WrJUH5VSvOerNOYGvJZqhw6IY0BoJlmJr5yb2B1yTk++3zR94mq/mu7A9WtYmXdAjHr09KSQ4I6ZCfgO/BLk6d7/+0Km8gKrorzPtlpD1eZuyPkiE1bLOgntA5cZkw= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770026317; c=relaxed/simple; bh=2EPTdibdHfcoEE43SEqY8O655e1yWUYzCEA/URi4voc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uj6MP5te3sxQ2dPi07J1tiLFvMI/eLnBK9bVmoMyU0tRwJ5+F/mmk2EGTbYCPbw3BA6H3y2Uachuh8tYcPOOY01Lc5XIfTv3Hmnl/bKZY0KDTRpCGXW0YbmBGIi21BwigHL+oXYYH8HxLpJGpHNsjUmem3PGKLGgaR/bl5f3v5A= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=bsU1SK3z; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=mD3SlI8I; arc=fail smtp.client-ip=67.231.152.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="bsU1SK3z"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="mD3SlI8I" Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6123gvr33710877; Mon, 2 Feb 2026 03:58:29 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=wrn13XxEBTf/TvJCGqkDoPALR6P+kAOD2OToeFAvaCI=; b= bsU1SK3z007qbVWZKKk8/CDybNvklrkzk11LT1/CIMIxW6gP/tqu9SLu5jwHu4+l 4N6NgAQS1Fy6NJ6l/G+i2hODUr/C0uVPOq7S4/dXtH2bbuwFovL3qQ2dzswyNvDZ 299eZuZ22iB0U2yarsql2KnQZg6KvXoG3m5HYaa5rOT/A1aMHNMe6svFd3FieOj4 hpamM4KakCuDdVqMiBiz8CYshGtQENy7wkPeg+xWL+BFDxtZdtFW4j5Ly4Wtf8Ih 27frA5pL8lBuzyFxAQGDJh5sI53+FqgCiIFasyujv8QubV8EvM/Rbe9axb1zemTs S8H5rb/xeivAFUUiXJtkhA== Received: from ph0pr06cu001.outbound.protection.outlook.com (mail-westus3azon11021103.outbound.protection.outlook.com [40.107.208.103]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 4c1f1k1ked-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 02 Feb 2026 03:58:28 -0600 (CST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XoseqqtwpboC9D7gS2Gvm5bWUNCT+sVFv1e/rlLzLSyJLmzVFC66cRlZgpZKTgR78+2mm8rkmCJQNdm49WoBqbfrt3W01Fz4hBBWgiRvTelUXP54JAaeuZli/WC+jZb/GxSa0iY3FJiy/A/hpuoxChEVCcOUEDD6jzUp2mKeej5H8+hXra5BX/ubYck+7rrDojrG11ujFX1zuM744mXYVagVkNnTlCif7r/IXdzqGK4FEhB9h0FvMZSK5EjK7kM4jETFWoLs+PgP4mF/bfc76YpRpvSGaI7w9vY61r9+x/eHbgiKk07f3T6Lp3t8zP5zaEPLyITPaL4OBijS2yARjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wrn13XxEBTf/TvJCGqkDoPALR6P+kAOD2OToeFAvaCI=; b=MTPR8wug9Xjlr7XC0mD3eI8w6z5o9Qa9RTOroZ0gya4COH5P74o+civOX/HQUYcyS/k/vikAI1fUg51BDOxz2qMFbFo9U30SzDI40h7wZui1NqJN7zTUaUgG6A2bitdgBy19eDQNF0ZwQ5SXKA69QC5MNvgPQ7STxboNjjplnz6BNQf3hxqv2SczFdIKzjUIGUATUEzcHison8TQv5MhoFeSARK8Flsv+fkpi5IgKJ7hoFMEK4g7tFElXfz7ZA8C/J1+nVwBR7q3bNKeFCvFvIVbck/DkuAol9AjYM7OHmmxZikLFOsJdxVV0Q36sZr3ObBFkHZo28gdbXpP1EMSPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wrn13XxEBTf/TvJCGqkDoPALR6P+kAOD2OToeFAvaCI=; b=mD3SlI8I1UpN3Ln2vg0Lx3mi/WdwSh+NVg0eLWFQ+UUJMJuzQzwHdKzucd3D/5n5hlgw8FOGFtIbevxB4VB7I2M65mwumXe4gjpcmIEm1rVssWcvxrYnuf17+Jw9KU5K7fkHSL7WvrNCKtlcvVHK/Zh2CLZ4JWOmaYk+oVxuYew= Received: from BYAPR08CA0015.namprd08.prod.outlook.com (2603:10b6:a03:100::28) by IA3PR19MB8687.namprd19.prod.outlook.com (2603:10b6:208:528::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9564.16; Mon, 2 Feb 2026 09:58:25 +0000 Received: from SJ1PEPF00001CE5.namprd03.prod.outlook.com (2603:10b6:a03:100:cafe::86) by BYAPR08CA0015.outlook.office365.com (2603:10b6:a03:100::28) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9564.15 via Frontend Transport; Mon, 2 Feb 2026 09:58:23 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: Fail (protection.outlook.com: domain of opensource.cirrus.com does not designate 84.19.233.75 as permitted sender) receiver=protection.outlook.com; client-ip=84.19.233.75; helo=edirelay1.ad.cirrus.com; Received: from edirelay1.ad.cirrus.com (84.19.233.75) by SJ1PEPF00001CE5.mail.protection.outlook.com (10.167.242.21) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9587.10 via Frontend Transport; Mon, 2 Feb 2026 09:58:24 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 4A681406540; Mon, 2 Feb 2026 09:58:23 +0000 (UTC) Received: from [198.90.208.24] (ediswws06.ad.cirrus.com [198.90.208.24]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 30030820249; Mon, 2 Feb 2026 09:58:23 +0000 (UTC) Message-ID: <7e0183dd-33b7-4fed-8be6-9b41bb612610@opensource.cirrus.com> Date: Mon, 2 Feb 2026 09:58:22 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] firmware: cs_dsp: fix missing pwr_lock in cs_dsp_signal_event_controls() To: Ziyi Guo , Simon Trimmer , Charles Keepax Cc: patches@opensource.cirrus.com, linux-kernel@vger.kernel.org References: <20260131223317.3328639-1-n7l8m4@u.northwestern.edu> Content-Language: en-GB From: Richard Fitzgerald In-Reply-To: <20260131223317.3328639-1-n7l8m4@u.northwestern.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE5:EE_|IA3PR19MB8687:EE_ X-MS-Office365-Filtering-Correlation-Id: 782dee2f-bf61-4933-898b-08de62419b3d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|36860700013|61400799027|54012099003|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?TkxrU2cvYUlIRGN4ZUJkM0QyK0lySmRYOXExMjZVcUpDQzZySHJ5a0NMN1Bj?= =?utf-8?B?elp2SEE0U1MwekNnNVA0dTFRdkhUVFJoWjYyWlFYQTZqaWZaU0pBaFFNa1A5?= =?utf-8?B?YzgwcTEvLzJFMm5PbnVYRjNXc2szbDNWRVVMSVE3L2Jwc2dhZ0xVV1BMYTE3?= =?utf-8?B?YkVCUzVHM1RHbzBLRHd3aUkwTTlKZlJuNldobWlwb29UUjFUR2JFNFo3ZGhq?= =?utf-8?B?Q0pBTnZINmM0cFZ5dlFoYWpKNHR1M2NwTHJocFN4a3RYUFRnRGlIaWNOUXhv?= =?utf-8?B?MjV6OGQyWnAxZ3hBTkorRFM4NGVoWVozc0xxYU5HS0p3U3lNbTJLN0lSeHpi?= =?utf-8?B?WU9nY0FxNXczblZaQmErY05Tc0tUR1JCQWxWL0xzRnNxZXpIcGNaYTc2SEVU?= =?utf-8?B?bjFBL3hTTFFTbFFMdmRYMFVYT3dhQ0VBSm5YRXQyYllNdlBUMGI2Syt1Q0Zw?= =?utf-8?B?VVRvRTNoc3BaNGFORWpQRThMODgrMjNXOGpYZ2thNmx0L1M5Mlh4aW16Q1k3?= =?utf-8?B?b1FyNWZvUEgreXNCSkdTTUVLVy9jRVJBcDNiNjY5d0N1bFVaaHVNUXdPTTh6?= =?utf-8?B?Y3M4UzhOMlY3RTVpNmVGR1BRTytPV1l0TE9nL0VCeGtWNW5HRXFra2trT0dT?= =?utf-8?B?MFpaUnZoVHR0ZXVYNVgycFROYVZwRzNpdThXcEcvajZZcU15ampVdTkrOUUx?= =?utf-8?B?VTEvL0dKdUhIVlpoQ1djQkVzTWtVS2dEU2ZWOWlRRC9nck9JeU1CdDFGcUZ1?= =?utf-8?B?bzVZTlVTYUhENlQzcjVZUm5LWW1IcmtLNE5GSjNTRW1pU3NIU0tJMk5PalJj?= =?utf-8?B?MFlMRGJVWGw1YkV0bmduWHYxbmFTS0cvMzMydllINVFpNFdsVi9xZUZSblhD?= =?utf-8?B?b1Y5NXNaMGlzL0R5MldqemZUcGpxbDlJa0Rudng2Mm1zVjF6S0ZObjNKbk1E?= =?utf-8?B?T1M5V3M1RllKWW41OEdEbFUyVGtQVWlMY2hnb3FhR2xMYlM5aW5DSCsremVS?= =?utf-8?B?SXF2bG1meDdpMUUycHBCY3dydGFkeEVSaE05YWsvZjd6dit5VDRWTitkOHNl?= =?utf-8?B?aWJoNy93TzlGOURUemkyK3hjSFJ1cXd4RmZLS3QwbFlVOUJMSXExZDBwdjEv?= =?utf-8?B?dzhSNUlVQXNiRlREZXphTGN3NVlFbnh3OVZkUTRibUpGbEFDV3J5RVc2clhH?= =?utf-8?B?ZjQ4eGdiTGxacFVZYjBTMkVSZkRtdUorZm9FRjIxdWNqRGhqb0NqVEtLSXhu?= =?utf-8?B?N3lheFMyZ3BVV1JDVlFGVm1SVnVYQUNDVlp3L0dIcDhuNDNyLzY3Wml3VzZL?= =?utf-8?B?SVg1V244M1AzMzE2SHRqdS90VGRtS3hwVFpYbDdDNWFkeXlWc1hnOGJQZXM3?= =?utf-8?B?Ujc1WVJ2VU4xOSt1NWZnd3FHcUNpSG1XOTJ4R2E0clhRemhNNnYwUUx5b1F5?= =?utf-8?B?Nzc2RWVxd2lYaDkybWtseThPQzlTNHgwSlpNZy9BSkF1RFYza2t0N3dXU0g3?= =?utf-8?B?aVBKdWk3ZzlFcmc0cVBXVUVJQ2Y2K01DWUJtd09zZXN1aHdmTEV1dDNXQk1r?= =?utf-8?B?K3NhWnozMk1tRmFhSVdZa1FaZzB6ZDJaYU1EQ29UdHQ1K3ZiZ0doQmVSU0x3?= =?utf-8?B?WTZab0RLcHhWU2NnejNtaTc2MzQweEpqNkFUTmRNODlnVUcram9NSE1EVUxD?= =?utf-8?B?OGJLeHZPZVpuSVIzRUkwdnZsMjVoNEl0cTQyM0czekd4U0ZYOWNrSTVwVU8w?= =?utf-8?B?d0huM1JMYjNEa1E2U1hnWU1zUyszQ2RWb1c5bk05WVBxUzE5NUt5ZzJNRXpm?= =?utf-8?B?WGY2bnlucEJPeXNpeVJ0Ynk2SWxEYXkrTERXdlFQaEJYQ3d1eHl2VE5QN1B2?= =?utf-8?B?TnJzN1lCb0N4emVZTGlBc2x2dGtpVmVDS3cvR0xtVzdCNDZ2c3FIU0VETzBh?= =?utf-8?B?WExxL21TVzRqbzAzcGg2Vlg3d0pOUXFxc2NWZzhLbDNxYkNCdGxiSnNlTmdV?= =?utf-8?B?QzhGTUpXeTZlaGZNaXlyMDFZQUpXbHVOL0h1cWdtUnd0NnpiU0R0azJFSGdS?= =?utf-8?B?Qll5MkNIckxIWjBpWE51YTBOUjdsUVlLc3hrQmY3RmdEcDZ3bEFjcmtaa3pZ?= =?utf-8?B?bXY1WXpvRzd0Tm1UZ3Q2ci9XNmJrVkRIaERSdnlkT0ZHWUNwVktMRjVDNzUw?= =?utf-8?B?WjVpd3lrRTFVR2w1SHU3ZXBOckkwWXZZK2M3SDJIeFhma25FTlp5SFV5N2hG?= =?utf-8?B?blloRTRlcjgxV1JSUzVzVHRiQWdnPT0=?= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(82310400026)(36860700013)(61400799027)(54012099003)(7053199007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: KKUJ1SBYs1c17bw5Aun0aJnClITBtrBYutXe1tENn4jscSfBxktbn3oHSzHHScw+ooKQmdnNw1+7FZFwYwu0m8Ma4XmE7x4Yfb5yset0q3wEPniB7qYmgCbpou2LWu3FH1aHY+HPxzRB83JLVEPq9cZcm/q78V7QLqTWHQOkxGskgbN9XGgoYNOCyZX61x4PHqPVouXvQvf63EhkJwmtAGp50L80Iw0WOUHAQsrKK78OAZ4dTdDQ674/wdM1SJhTp0Ajh8k1eiCtMhBiFSOdJTiukXdYdwhHNXryrpVnAw8GJTUSBhKL5SczWFM77KMe2qyOBiMK/cHgVEq3RAY/xedjiS77SwPWB/bXqCi7qdfgFkqFE+W/wkZyJT8yulebuC7/wb3Fl/3ocnEoy40vM3RXD3g1pbFL6VbgfR1kOUrSilOnC9JzzHJLSL9WTANm X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2026 09:58:24.6846 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 782dee2f-bf61-4933-898b-08de62419b3d X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-SJ1PEPF00001CE5.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA3PR19MB8687 X-Authority-Analysis: v=2.4 cv=d+j4CBjE c=1 sm=1 tr=0 ts=69807544 cx=c_pps a=oz2EmwyjMC44gvVfu4wkxw==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=_SMzmrfqNTR-zZoqJtQA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjAyMDA4MyBTYWx0ZWRfX9P9c/0nd9v7a Ie8a6t/sz8SMBp1/1aDJ3k5HB04YhbQs/pTkLkzxUKuvt64s1sF66wGbddFlEEJzbkOjmKAiKK+ QB4HLVqBUI89pPUBsQKcLS1MUkruW1cidOzJBlDTe4DmO6Neq8o6UAkgYxr/qp9H4ehVDRyujfm sBRKAEM7bqGJjmzxb0FCekAAE6QDvYeKLg6B5SApyAIo+yYuijErl/qkGj3kUOe9Qa+syhEsy7d FxUR/YeSU/8oOZgBbn9w3BFpjlpkZGDHGGh4SukfB6+ePsq+gWzTlubEdEgexIF37szVrKtZnyW aRNvPpr9WlKB7I1FlOWe0OD69m3eJePIjInmj1drSgyXjK7YCV9Uc0YSyI/sEBAYgTau30vAicP 2hCtvFI1R8x1w1jRDKtxTq2tFp5oQi0cKIiY2mg83bJKw/zKSSUik9ZebvzvYV/qIqMChdjSZEQ NxjGodciQFnzORXZ6lQ== X-Proofpoint-GUID: hZhxoq07B1ptT7nWZhOOToKdB7GArZ_B X-Proofpoint-ORIG-GUID: hZhxoq07B1ptT7nWZhOOToKdB7GArZ_B X-Proofpoint-Spam-Reason: safe On 31/01/2026 10:33 pm, Ziyi Guo wrote: > cs_dsp_signal_event_controls() calls cs_dsp_coeff_write_acked_control() > which has lockdep_assert_held(&dsp->pwr_lock), but the lock is not held. > > Add mutex_lock()/mutex_unlock() around the control list iteration in > cs_dsp_signal_event_controls() to fix the missing lock protection. > > Signed-off-by: Ziyi Guo I don't think this is the correct fix. The mutex_lock() in cs_dsp_stop() should be at the top of the function. Compare with cs_dsp_run().