From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4F8A32E729 for ; Tue, 10 Mar 2026 19:22:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773170564; cv=none; b=UFHiUot47AbyP8QR51DcJFx6LeohAVYZFxwxsp2an33XGGc0offRszfZxl9Sjwap8bEGJ+9X6tz2ZV5VK51ZXoxPPayHgi28zwloFAgXtILKsy8JxRsD+DaCfI20qfFRxwBUJLi9Yg/48yR875JYxQ7ciyEHeCzDunWJ5lO9DRU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773170564; c=relaxed/simple; bh=2X0JXluk460/BnzKu+STGhWj8xvDcmWnGO58GKgYU4c=; h=Date:Message-ID:MIME-Version:Content-Type:From:To:Cc:Subject: References:In-Reply-To; b=d9soz+NgvdoaKzBcpkliw7YSNUkIJ9mGJvrGTY+ynPWv/1sPDE2PjvdOTj28E78ZZ//hw7Arr/tcGJa+1Ejyfm4nlVrgbTfUat1E16ufwr4v4Xm5GuzzAIia8/s62nTxMxUTMUfKWzdZnU+Wg1oOlgl1lhvhz41QXQggroQymTE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com; spf=pass smtp.mailfrom=paul-moore.com; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b=OzfW7yAX; arc=none smtp.client-ip=209.85.160.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b="OzfW7yAX" Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-5090c48de85so31566991cf.0 for ; Tue, 10 Mar 2026 12:22:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1773170563; x=1773775363; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :mime-version:message-id:date:from:to:cc:subject:date:message-id :reply-to; bh=aV7hXCLQCflyUrdLM8cprfjVR2mNmzi/mjO0qXwCdXc=; b=OzfW7yAXtfvHxL94OM+4L81dUyr+dBSvMXs0Gikx7L5T0YCyf0/JCV01g4jTb4z0VK YRFH0N2CGEv5vvG+8kN4UZ1KOiTeuZZKrtdkzp3lsMz1oqLZYQphkqBZthu0L6Qzs0l7 ZPjusBuo75EJ+mxei/VKZQCEcIG851RSpPiru+lwQ15qMYemD5BiZtY4aN9tDrKB+tHJ +zNohkq80ZYT6BPN2PmuDRA4pKgAoukf5eXrojutRKI6hYLzc8cPBPKu8wH5IyOSLzbx qzbNVRD8C8VeFUbGMbF5Sd9JBZ3sTtUD5oCnKQC2q5YQcKcfkhfk8wgqoa3Q8QMnQ8dJ yP7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773170563; x=1773775363; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :mime-version:message-id:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aV7hXCLQCflyUrdLM8cprfjVR2mNmzi/mjO0qXwCdXc=; b=FW76UnTBCb+e7mX9GIC1qVQF+56GusTnqZA8yAusreltZfl3tFkz2yZB/s7A0x45BD LLTJw+kYat6lQGGvq1oGCAGO08l5asHhNybA5cQEzwaJqE9xT5yK9nqJbeEhzFtciKZF T4p6ZAVK31fk0pxhMiVdt7CChkihS2fZyY6nRLloPZyKt0YY3OFJgRaONiuFqXQERc0y kGHPaV88EUFMZWiJKfrboc9woVqk+2LW7isLT2GDgjRVF3FARe4p4ogENeUN71BMCVZR 0XjGwClgTd34xciiVn9+Vdx5bLKk1kCnQY5cXOBpuqP7hceeRxt0UioFXUXab71xo+vO M6Mw== X-Forwarded-Encrypted: i=1; AJvYcCWo9+4Wi/kqn8RHra/avxObPefOUW80gcTMoracu3spDX1Ov6cHH2dIlG2GUOOhwDySTw9TbUYAEakkNEI=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/0sM9swXxeJlV6YNxXxathQKpbYvaMeWZN+IPbT3sjLd3C+gF VmaIqXiKMkRZC16148mmb/w9DhPcPgXRqt1pUbn1sCxIAV8ZCd3ZfBu60K0sXVfqiA== X-Gm-Gg: ATEYQzxl9yMik8FjqmA4FM7nTX6qQt14Ki2ONto8chuRRS3MYj+iZnQuO9cPyBgma+T PL6AqNTxdglPwZ9oV24PIMhJWsaK5mbpNhCU/4W6l8ddOfwPriVjrTRvn6hGjD0B4sW5lH9N9dR 3HwSAy5kowL4Bprv54m90nnUfWc20FkWbx2O/qvJIuVafURlvm16BX7DiaJZtm0meva+sd3pql1 1U3K0v8zF/jz7BvxovJWb0Rxh6794gYNTtmMptjP6RlYqjLG4Qt/iizapOOM4RxUxeVJIxamXMs 06IqXXXD7IjpSCbh0AmnAAKAqiF84qVbFrsWDMlF4VhihVjWRdtqqQPjMxbLU1/urqPEggHB+zX dNHFfsSq7CkGAw4ZYkOjjS02TD6GE7Q//0pmJ48kDdOYwP3DBEi1BU7cGKti13o3ipC0EX9svfK BD4r/2Th+6YePygUCi9dRu6jLiIqm5mlAZ5FHf3NDikXg9QjEA1Cr6yDd7X9RhORPcSkTw X-Received: by 2002:ac8:59c8:0:b0:509:1c90:e192 with SMTP id d75a77b69052e-5091c90ea59mr96495091cf.66.1773170562824; Tue, 10 Mar 2026 12:22:42 -0700 (PDT) Received: from localhost (pool-71-126-255-178.bstnma.fios.verizon.net. [71.126.255.178]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-5093862bbc9sm1796501cf.5.2026.03.10.12.22.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 12:22:42 -0700 (PDT) Date: Tue, 10 Mar 2026 15:22:40 -0400 Message-ID: <7e02e707baecb7c94db329d5d03c1c15@paul-moore.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: pstg-pwork:20260310_1520/pstg-lib:20260310_1519/pstg-pwork:20260310_1520 From: Paul Moore To: Ricardo Robaina , audit@vger.kernel.org, linux-kernel@vger.kernel.org Cc: eparis@redhat.com, Ricardo Robaina , Steve Grubb Subject: Re: [PATCH v2] audit: handle unknown status requests in audit_receive_msg References: <20260309130533.158095-1-rrobaina@redhat.com> In-Reply-To: <20260309130533.158095-1-rrobaina@redhat.com> On Mar 9, 2026 Ricardo Robaina wrote: > > Currently, audit_receive_msg() ignores unknown status bits in AUDIT_SET > requests, incorrectly returning success to newer user space tools > querying unsupported features. This breaks forward compatibility. > > Fix this by defining AUDIT_STATUS_ALL and returning -EINVAL if any > unrecognized bits are set (s.mask & ~AUDIT_STATUS_ALL). > This ensures invalid requests are safely rejected, allowing user space > to reliably test for and gracefully handle feature detection on older > kernels. > > Suggested-by: Steve Grubb > Signed-off-by: Ricardo Robaina > --- > v1 -> v2: > - Moved AUDIT_STATUS_ALL from include/uapi/linux/audit.h to > include/linux/audit.h. > > include/linux/audit.h | 9 +++++++++ > kernel/audit.c | 2 ++ > 2 files changed, 11 insertions(+) Merged into audit/dev, thanks. -- paul-moore.com