From: Shawn Lin <shawn.lin@rock-chips.com>
To: Geraldo Nascimento <geraldogabriel@gmail.com>
Cc: shawn.lin@rock-chips.com, linux-rockchip@lists.infradead.org,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Johan Jonker" <jbx6244@gmail.com>,
"Dragan Simic" <dsimic@manjaro.org>
Subject: Re: [PATCH v2 0/4] PCI: rockchip: 5.0 GT/s speed may be dangerous
Date: Tue, 18 Nov 2025 08:43:41 +0800 [thread overview]
Message-ID: <7e050003-f4ea-4e89-8140-2159c670182f@rock-chips.com> (raw)
In-Reply-To: <cover.1763415705.git.geraldogabriel@gmail.com>
在 2025/11/18 星期二 5:46, Geraldo Nascimento 写道:
> Dragan Simic already had warned me of potential issues with 5.0 GT/s
> speed operation in Rockchip PCIe. However, in recent interactions
> with Shawn Lin from Rockchip it came to my attention there's grave
> danger in the unknown errata regarding 5.0 GT/s operational speed
> of their PCIe core. Even if the odds are low, to contain any damage,
> let's cover the remaining corner-cases where the default would lead
> to 5.0 GT/s operation as well as add a comment to Root Complex driver
> core, documenting this danger. Furthermore, remove redundant
> declaration of max-link-speed from rk3399-nanopi-r4s.dtsi
>
> Signed-off-by: Geraldo Nascimento <geraldogabriel@gmail.com>
>
Thanks for fixing these.
Acked-by: Shawn Lin <shawn.lin@rock-chips.com>
> ---
>
> Changes in v2:
> - hard limit to 2.5 GT/s, not just warn
> - add Reported-by: and Reviewed-by: Dragan Simic
> - remove redundant declaration of max-link-speed from helios64 dts
> - fix Link: of helios64 patch
> - simplify RC mode comment
> - Link to v1: https://lore.kernel.org/all/aRhR79u5BPtRRFw3@geday/
>
> Geraldo Nascimento (4):
> PCI: rockchip: limit RK3399 to 2.5 GT/s to prevent damage
> PCI: rockchip-host: comment danger of 5.0 GT/s speed
> arm64: dts: rockchip: remove dangerous max-link-speed from helios64
> arm64: dts: rockchip: remove redundant max-link-speed from nanopi-r4s
>
> arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts | 1 -
> arch/arm64/boot/dts/rockchip/rk3399-nanopi-r4s.dtsi | 1 -
> drivers/pci/controller/pcie-rockchip-host.c | 3 +++
> drivers/pci/controller/pcie-rockchip.c | 10 ++++++++--
> 4 files changed, 11 insertions(+), 4 deletions(-)
>
next prev parent reply other threads:[~2025-11-18 0:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 21:46 Geraldo Nascimento
2025-11-17 21:47 ` [PATCH v2 1/4] PCI: rockchip: limit RK3399 to 2.5 GT/s to prevent damage Geraldo Nascimento
2025-12-18 8:05 ` Manivannan Sadhasivam
2025-12-18 9:47 ` Dragan Simic
2025-12-18 10:01 ` Diederik de Haas
2025-12-18 10:13 ` Dragan Simic
2025-12-24 2:24 ` Geraldo Nascimento
2025-12-24 5:18 ` Anand Moon
2025-12-24 5:38 ` Geraldo Nascimento
2025-12-24 8:04 ` Anand Moon
2025-12-24 12:55 ` Dragan Simic
2025-12-24 16:11 ` Anand Moon
2025-12-24 16:52 ` Dragan Simic
2025-12-24 21:57 ` Geraldo Nascimento
2025-11-17 21:47 ` [PATCH v2 2/4] PCI: rockchip-host: comment danger of 5.0 GT/s speed Geraldo Nascimento
2025-11-17 21:47 ` [PATCH v2 3/4] arm64: dts: rockchip: remove dangerous max-link-speed from helios64 Geraldo Nascimento
2025-11-17 21:47 ` [PATCH v2 4/4] arm64: dts: rockchip: remove redundant max-link-speed from nanopi-r4s Geraldo Nascimento
2025-11-18 0:43 ` Shawn Lin [this message]
2025-12-22 13:38 ` (subset) [PATCH v2 0/4] PCI: rockchip: 5.0 GT/s speed may be dangerous Heiko Stuebner
2025-11-18 6:45 Dragan Simic
2025-11-18 7:17 ` Geraldo Nascimento
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e050003-f4ea-4e89-8140-2159c670182f@rock-chips.com \
--to=shawn.lin@rock-chips.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dsimic@manjaro.org \
--cc=geraldogabriel@gmail.com \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®