mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Johann Baudy" <johaahn@gmail.com>
To: hjk@linutronix.de, gregkh@suse.de
Cc: linux-kernel@vger.kernel.org
Subject: UIO: phys_mem_access_prot() miss?
Date: Tue, 13 May 2008 15:55:29 +0200	[thread overview]
Message-ID: <7e0dd21a0805130655xd8b1c8ap9a329943e25fe6fb@mail.gmail.com> (raw)

Hi Hans, Greg,

I need some help on UIO driver.
I have to add this below workaround (in uio.c) to be able to access
phys memory from user space.
I'm currently using PPC arch.
Am I wrong? or Is it a miss?

static int uio_mmap(struct file *filep, struct vm_area_struct *vma)
{

...
	switch (idev->info->mem[mi].memtype) {
		case UIO_MEM_PHYS:
+       	vma->vm_page_prot = phys_mem_access_prot(filep,
+            idev->info->mem[mi].addr >> PAGE_SHIFT,
+						 vma->vm_end - vma->vm_start,
+						 vma->vm_page_prot);
			return uio_mmap_physical(vma);
		case UIO_MEM_LOGICAL:
...

}

FYI: I've copied those lines from mem char driver in mmap_mem().

Thanks in advance,
Johann

             reply	other threads:[~2008-05-13 13:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-13 13:55 Johann Baudy [this message]
2008-05-13 18:51 ` Hans J. Koch
2008-05-15  7:45   ` Johann Baudy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e0dd21a0805130655xd8b1c8ap9a329943e25fe6fb@mail.gmail.com \
    --to=johaahn@gmail.com \
    --cc=gregkh@suse.de \
    --cc=hjk@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®