From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B904B1EF0A2 for ; Thu, 7 Nov 2024 12:08:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730981328; cv=none; b=JG5VgQvxz7IdvGlKo3p3bynBZ5pi45nVfTL3qswADthnrS7STl9OBNQfMpnDRWSnJUJQFwe5Wfr/c6gFCplCiH5/4MsCoE+6kGSjsYOFjYn/Jt6R0hga+ZeVa9LkvOd+sbp/dRE7OZ+GUnIxpC+pgs1+JwhvBTK0Cn6OHLDqbcw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730981328; c=relaxed/simple; bh=P+ZmCLNqT/7hSPWujVP3owEJpB951n6H3S7VxdBjr2s=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=TCg1gqNB4Ya32ePuEjfFK8dqDTl54QJLBlwzQjUPzEBPSGhCYq6GcMlfHJsaiCYrJq+6Aw8wmfSi/DS1EQZ6izPiSqIYu4aWJozwtSl0hBEEYWDC0MIr6gJkrNWnCHkT720BzJf8Cp3+LP/IhF7RijUDOG/pZiwgz3E21GLbIyo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Zbw2wbCF; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Zbw2wbCF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730981325; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P+ZmCLNqT/7hSPWujVP3owEJpB951n6H3S7VxdBjr2s=; b=Zbw2wbCFfcmyriiBER4v0yI/iksoGo+KQAEbhjQBJzWATdBPEM7hsEVjSFU8VnWvt18iDR XhwbuEYuw9d8xNy/95swXo/LmRE26wAe7MUWOKtzH30oJ9szG/0KZkpmF5LOQK1qysSpm2 BISmGc6jBXh1VDIqSBn1FkB9Cfr4fYU= Received: from mail-oa1-f70.google.com (mail-oa1-f70.google.com [209.85.160.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-490-RfKiCZGbP-Kia9cHiGhYKg-1; Thu, 07 Nov 2024 07:08:44 -0500 X-MC-Unique: RfKiCZGbP-Kia9cHiGhYKg-1 X-Mimecast-MFC-AGG-ID: RfKiCZGbP-Kia9cHiGhYKg Received: by mail-oa1-f70.google.com with SMTP id 586e51a60fabf-2891d447ebaso1063911fac.3 for ; Thu, 07 Nov 2024 04:08:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730981324; x=1731586124; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=P+ZmCLNqT/7hSPWujVP3owEJpB951n6H3S7VxdBjr2s=; b=mV7iYptedFikBDv5u5B1oA1nsPI2SA75kGaYJsPWqH3SI/HUTcMNLYqLXTsZdzQH03 0YEtjUS4OFhDciNMfS6t0jE3tw3HGSUHzQwFnVLu4iTvwgtbJVEfB3V9vOW3k19d1tQH uBvVT8zXwhd4K+1kjVhpujPaYcfy9t0PUi0P3oNWxB2zhYXPLqRDqWyMKBEp7ByrA+TG swAyc7I9+/xUQuPQJ4CmENwVGPQqpA4oi/Nz7N4675an0zxZZuXglNMT+WftVyneoCUf wxp+TcZEWH9habI4XorazzwSP6ZyOb6LiowqfHe/B6Zz+DCVJ2TpXGw/VbZvxwZJqQKw xGrA== X-Forwarded-Encrypted: i=1; AJvYcCUIv2k/9iwM8ysQA7YY7sQDFuGazX1BZEgMCoKSS3Yxd0yxTqKHojida9UgSqn5AoDLkOQIQYNi9UC7+Eo=@vger.kernel.org X-Gm-Message-State: AOJu0YyIB7g0cM9Mm5inG4Dy+6KFdlQ49xI+8X0A5HCHhla74Kp3jW1b liwfOUdkzAsyFYXoYqilZdIOuHpqa6AIkYnPk1k4pJFj/lmwkwfa10zEi9VHcgVHfgrnOGuHLRn XrhCBGCcBcXDOIB1lZW4udE/XACnQW66c2J57NJk/uWTCrGvZ889SSgC/NOwc3Q== X-Received: by 2002:a05:6870:178e:b0:261:164e:d12a with SMTP id 586e51a60fabf-2949ee0b87emr21308216fac.22.1730981323736; Thu, 07 Nov 2024 04:08:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IHeJrwUsl9lztRDYZl1aEOL++WosS7qon8mJ6s7nwFpWJQj81Qdxv4suuQ4ykwvnLVP/ZrxCg== X-Received: by 2002:a05:6870:178e:b0:261:164e:d12a with SMTP id 586e51a60fabf-2949ee0b87emr21308196fac.22.1730981323479; Thu, 07 Nov 2024 04:08:43 -0800 (PST) Received: from [192.168.88.24] (146-241-44-112.dyn.eolo.it. [146.241.44.112]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-71a107eb5c8sm227391a34.13.2024.11.07.04.08.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Nov 2024 04:08:43 -0800 (PST) Message-ID: <7e0df321-e297-4d32-aac5-a885de906ad5@redhat.com> Date: Thu, 7 Nov 2024 13:08:39 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next] net: ppp: remove ppp->closing check To: Qingfang Deng , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , linux-ppp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241104092434.2677-1-dqfext@gmail.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20241104092434.2677-1-dqfext@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/4/24 10:24, Qingfang Deng wrote: > ppp->closing was used to test if an interface is closing down. But upon > .ndo_uninit() where ppp->closing is set to 1, dev_close() is already > called to bring down an interface and a synchronize_net() guarantees > that no pending TX/RX can take place, so the check is unnecessary. > Remove the check. I'm unsure we can remote such check. The TX callback can be triggered even from a write on the controlling file, and it looks like such file will be untouched by uninit. Cheers, Paolo