From: "Eric Paris" <eparis@parisplace.org>
To: "Pavel Emelyanov" <xemul@openvz.org>
Cc: linux-audit@redhat.com, "Thomas Graf" <tgraf@suug.ch>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
aviro@redhat.com, sgrubb@redhat.com, akpm@osdl.org
Subject: Re: [PATCH] Audit: netlink socket can be auto-bound to pid other than current->pid
Date: Tue, 18 Mar 2008 19:35:08 -0400 [thread overview]
Message-ID: <7e0fb38c0803181635t7b629bc4x707e4083b1c81edf@mail.gmail.com> (raw)
In-Reply-To: <7e0fb38c0803181629u4a6ff1d6ye83881ddf0e96d48@mail.gmail.com>
On 3/18/08, Eric Paris <eparis@parisplace.org> wrote:
> On 3/18/08, Pavel Emelyanov <xemul@openvz.org> wrote:
> > @@ -626,6 +628,7 @@ static int audit_receive_msg(struct sk_buff *skb, struct nlmsghdr *nlh)
> > sid, 1);
> >
> > audit_pid = new_pid;
> > + audit_nlk_pid = NETLINK_CB(skb).pid;
> > }
> > if (status_get->mask & AUDIT_STATUS_RATE_LIMIT)
> > err = audit_set_rate_limit(status_get->rate_limit,
Shouldn't the above be:
if (audit_pid)
audit_nlk_pid = NETLINK_CB(skb).pid;
else
audit_nlk_pid = 0;
otherwise I don't see how you can cleanly stop the userspace auditd.....
next prev parent reply other threads:[~2008-03-19 23:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-18 9:24 Pavel Emelyanov
2008-03-18 23:29 ` Eric Paris
2008-03-18 23:35 ` Eric Paris [this message]
2008-03-19 9:11 ` Pavel Emelyanov
2008-03-19 12:04 ` Eric Paris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e0fb38c0803181635t7b629bc4x707e4083b1c81edf@mail.gmail.com \
--to=eparis@parisplace.org \
--cc=akpm@osdl.org \
--cc=aviro@redhat.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sgrubb@redhat.com \
--cc=tgraf@suug.ch \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®