From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Xin Gao <gaoxin@cdjrlc.com>, linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hfsplus: Fix code typo
Date: Fri, 22 Jul 2022 16:12:34 -0400 [thread overview]
Message-ID: <7e1182f7c01af15d47d7ee836a72bbd5e9b47d64.camel@HansenPartnership.com> (raw)
In-Reply-To: <20220722195133.18730-1-gaoxin@cdjrlc.com>
On Sat, 2022-07-23 at 03:51 +0800, Xin Gao wrote:
> The double `free' is duplicated in line 498, remove one.
>
> Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
> ---
> fs/hfsplus/btree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/hfsplus/btree.c b/fs/hfsplus/btree.c
> index 66774f4cb4fd..655cf60eabbf 100644
> --- a/fs/hfsplus/btree.c
> +++ b/fs/hfsplus/btree.c
> @@ -495,7 +495,7 @@ void hfs_bmap_free(struct hfs_bnode *node)
> m = 1 << (~nidx & 7);
> byte = data[off];
> if (!(byte & m)) {
> - pr_crit("trying to free free bnode "
> + pr_crit("trying to free bnode "
What makes you think this message needs correcting? The code seems to
be checking whether we're freeing an already free bnode, meaning the
message looks correct as is and the proposed change makes it incorrect.
James
next prev parent reply other threads:[~2022-07-22 20:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 19:51 Xin Gao
2022-07-22 20:12 ` James Bottomley [this message]
2022-07-22 21:32 ` Matthew Wilcox
2022-07-24 10:48 ` Harald Arnesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e1182f7c01af15d47d7ee836a72bbd5e9b47d64.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=gaoxin@cdjrlc.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®