From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FD74429000 for ; Tue, 21 Jul 2026 10:02:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784628174; cv=none; b=DdsfRYCtkxC0KVK6XEY3lU8yQKj7szxcUhoRq7URTksL7LP7TWjQ23z6ZtyKtRupyv8Dy6PhqMnyFWqmSC2HNnmQjTSGqrlNX2BrK6015Bl7Xq+M4fBmtOGjpWnx+MkAB2u2IKM8TGhGQuD2uG3HrWoOfbUpM3Vkbzl77ofKfxs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784628174; c=relaxed/simple; bh=p61gCRXFIm0NiiY2OG0adIIyMTBhQAMC79Dsy1XTIxE=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=TjgyFJp1Wm32wK/00juCdCK3t9PaYRKXtk6EfCD0ZQ3acKs7UH0iVT5bimqng7cTT3z63Lu4iQtNyvrXurHQNXoBlvdAzw9UIprjIVmKQiAbyzzBl9dVR4uuvJx/PJhg7nJV/qXLnE4dlx+22CpjUmLkYQxTJuupWJ4v8YI1LKk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Fy40yyLX; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Yk+y2m2V; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Fy40yyLX"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Yk+y2m2V" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784628172; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FDdpB6ZYwZIlR+moMdqHy53xNfFlVy927sGzMiz2qu8=; b=Fy40yyLXiSyK8FdCLzP7qSELmxhKlTKj5BvhDpUH7wQFdYskwzXfxJyLnAYDOoj6+rclzN m1OvxA9fFUDx6oJz/YEJsW6CM+RiO33r3p39sGkWs0nTALkRMfn4/rsoQggKMrVmtiM982 YDWO74QLE0cqHk7JZF0q9fqsSsas6J4= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-641-9cTQKPMRN-al-Ks3yI-PzQ-1; Tue, 21 Jul 2026 06:02:50 -0400 X-MC-Unique: 9cTQKPMRN-al-Ks3yI-PzQ-1 X-Mimecast-MFC-AGG-ID: 9cTQKPMRN-al-Ks3yI-PzQ_1784628170 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-47f8158485eso316089f8f.3 for ; Tue, 21 Jul 2026 03:02:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1784628169; x=1785232969; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to:content-type; bh=FDdpB6ZYwZIlR+moMdqHy53xNfFlVy927sGzMiz2qu8=; b=Yk+y2m2VTxisxxiK7KH6BYN8bIo5mb7/2ZWRb4ZgCKIeVNTdbFYpKh1kNMPhpT5hDM ZbMiVX6PkOybpBZZhBaFD+4pZpqQpSdsihd6udkVEvYRWxOj6271SXBQq0qOQpyW7Cb5 He4TmGFyFp+/P9+wElnCgjx0IVKjYtPf+PL33wqmzTMF3MDt9dTiIdjpzBLMc5qSLUCN N4jVntQuhta1SBZtZLcjjP7zorKJiIRmD6trKG6HfFmG5zjwBtomzCMygpyk2AtE4E5K R6qYyYXCXWUd72BmOPjP2kRi9geOUBcO3/yFWRuXQToQfHMQuabAXwzn5fWjZCfN1AH7 UFCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784628169; x=1785232969; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=FDdpB6ZYwZIlR+moMdqHy53xNfFlVy927sGzMiz2qu8=; b=YlpFxjUSMylVbNnyQ03zNsgTFxm84uLfRYmoR21IE+ecMDUmSqJLMLeXpr0qaN8AYz Glc87jPXX6HyODahddrVphUSBPX2ad+kMFz7Peksyi9GxdRciLYGxDina7JyDmhX76y1 i/apcmoZiVin8mhgqh+h3Af4jCgKvdlPgG3U7CeKjreyTqlJp+Omr1epWfrffDt/lH4T MKNyloKF8QMf3tLTdgNwPbYXUvc6zV5j8JXJPVrRc+zBA+3BdEhOlm6tSEU2JILWYeFd aqgLCtSVf2MoKcSwdFN9bL+rLOvccbPQUxylmV+6WFE16Ji2owJU+t40OjtvnoLefPzU Es3g== X-Forwarded-Encrypted: i=1; AHgh+RoROuY2b5QbHzLRvRidX+HXRlG4xdn4V0YF7VIg+vssSbF5ZMoTxlnJCld/ML9Za0aQxs11gzTxqf4lNAo=@vger.kernel.org X-Gm-Message-State: AOJu0YxXQsZoaSNm4e9pgMxwTGzebg8CfhRdODTbQod0gbvovu/T21CH pno8f9ALLqYvsV7Y5FrCOB5MY/aEHsttUAoMj6a08lzCPTxWDoYfJ2II3ihkrExkg1Wzs0eA/W4 i2Z1Ypn//NYP9X65naQYmhcl1EroHFKtyHxUL3qEJ21ita0K4Sks9EyHFV5v3N/3/SmNrLtohig == X-Gm-Gg: AR+sD12RSkTAHGeTUbcamm0eR649twnVcX7Roqw6LLR1DZ07FzXJ1Kd2XwoQiXjXYuU W+oAXTlfhQHUZV4cVaBFmN+Amh4l06c+omobK52S4RhG1TIBbd9fpQpAthclcAbvJwGfUwxrLdn QF3VjAx2bLSNPavn6hQeF7WsANV8ngGdC81X15xOLx2YcrftDyJQl6UKiiUIFw+9qwKfqwozZ9u aB4KRe2LAmVJhqf6U9rgiZco+C/Nu9iDIItQClOY2Ji149Mk3t4FZmpTL7j3fRvfmIsOcBGMFLx nr7lzQPzX//rgEd5rhc4+wi2g+Sym7Zf6Atj77ZEBd9YFpaD20r212iobxw1H7ILQngR3J4u4Nc 139rD/KtvjFKviwqWsRS23o8e0xx4KOfPYhR/D4yCmLrXGxmIXCYUiqXGd21/T85ggjao2CR09y eJpQ== X-Received: by 2002:a5d:5848:0:b0:47f:71a6:79c5 with SMTP id ffacd0b85a97d-47f71a67a5amr12529386f8f.12.1784628169125; Tue, 21 Jul 2026 03:02:49 -0700 (PDT) X-Received: by 2002:a5d:5848:0:b0:47f:71a6:79c5 with SMTP id ffacd0b85a97d-47f71a67a5amr12529309f8f.12.1784628168390; Tue, 21 Jul 2026 03:02:48 -0700 (PDT) Received: from ?IPV6:2a0d:3344:5521:6b10:58fd:68f:7756:389d? ([2a0d:3344:5521:6b10:58fd:68f:7756:389d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f63e49ce4sm38099290f8f.8.2026.07.21.03.02.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jul 2026 03:02:47 -0700 (PDT) Message-ID: <7e12f83c-2449-4618-bf43-acc533df3a36@redhat.com> Date: Tue, 21 Jul 2026 12:02:46 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 4/5] net: phy: mediatek: add calibration logic for AN7581 To: Christian Marangi , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Daniel Golle , Qingfang Deng , SkyLake Huang , Matthias Brugger , AngeloGioacchino Del Regno , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20260708102341.53919-1-ansuelsmth@gmail.com> <20260708102341.53919-5-ansuelsmth@gmail.com> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260708102341.53919-5-ansuelsmth@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/8/26 12:23 PM, Christian Marangi wrote: > +static int airoha_cal_cycle(struct phy_device *phydev, int devad, > + u32 regnum, u16 mask, u16 cal_val) > +{ > + struct airoha_socphy_shared *shared = phy_package_get_priv(phydev); > + struct phy_device *phydev_p0; > + int ret; > + > + phydev_p0 = shared->phydev_p0; > + > + phy_modify_mmd(phydev, devad, regnum, mask, cal_val); > + > + ret = mtk_cal_cycle_wait(phydev_p0); The above call causes a builder error at link time in allmodyes config: ERROR: modpost: "mtk_cal_cycle_wait" [drivers/net/phy/mediatek/airoha-ge-soc.ko] undefined! Also sashiko gemini has a few points: https://sashiko.dev/#/patchset/20260708102341.53919-1-ansuelsmth%40gmail.com /P