From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: linux-kernel@vger.kernel.org, bhe@redhat.com, pmladek@suse.com,
akpm@linux-foundation.org, anton@enomsg.org, ccross@android.com,
dyoung@redhat.com, feng.tang@intel.com,
john.ogness@linutronix.de, keescook@chromium.org,
kernel@gpiccoli.net, kexec@lists.infradead.org,
rostedt@goodmis.org, tony.luck@intel.com, vgoyal@redhat.com
Subject: Re: [PATCH V6] panic: Move panic_print before kmsg dumpers
Date: Tue, 22 Feb 2022 11:10:48 -0300 [thread overview]
Message-ID: <7e15bc6a-ceae-aa3a-0a86-18d24181b0ed@igalia.com> (raw)
In-Reply-To: <YhRFNKtxSE8Xrbfw@google.com>
On 21/02/2022 23:06, Sergey Senozhatsky wrote:
> On (22/02/14 11:13), Guilherme G. Piccoli wrote:
> [...]
> By additional panic_print messages you mean that panic_print_sys_info()
> will print everything (except PANIC_PRINT_ALL_PRINTK_MSG) twice?
>
> Do we really need to dump everything twice? show_mem(), show_state(),
> ftrace_dump(DUMP_ALL). That's quite a bit of extra data.
>
Oh no, we don't print everything twice, that'd be insane heh
The patch only anticipates the call site for the panic_print_sys_info()
- but as discussed in the first iterations, we couldn't just bring it
earlier due to the console replay thing. Hence, we needed to split
calls...the first call dumps the information, the 2nd call only does the
console replaying if that is set.
Cheers,
Guilherme
next prev parent reply other threads:[~2022-02-22 14:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 14:13 Guilherme G. Piccoli
2022-02-15 16:14 ` Petr Mladek
2022-02-23 11:41 ` Sergey Senozhatsky
2022-02-23 12:30 ` Guilherme G. Piccoli
2022-02-22 1:45 ` Sergey Senozhatsky
2022-02-22 14:08 ` Guilherme G. Piccoli
2022-02-23 1:35 ` Sergey Senozhatsky
2022-02-22 2:06 ` Sergey Senozhatsky
2022-02-22 2:10 ` Sergey Senozhatsky
2022-02-22 14:10 ` Guilherme G. Piccoli [this message]
2022-02-23 1:27 ` Sergey Senozhatsky
2022-02-23 13:15 ` Guilherme G. Piccoli
2022-02-24 2:52 ` Sergey Senozhatsky
2022-02-24 14:33 ` Petr Mladek
2022-02-24 14:45 ` Guilherme G. Piccoli
2022-02-25 5:18 ` Sergey Senozhatsky
2022-02-25 5:23 ` Sergey Senozhatsky
2022-02-25 12:16 ` Petr Mladek
2022-02-26 2:23 ` Sergey Senozhatsky
2022-02-28 12:33 ` Guilherme G. Piccoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e15bc6a-ceae-aa3a-0a86-18d24181b0ed@igalia.com \
--to=gpiccoli@igalia.com \
--cc=akpm@linux-foundation.org \
--cc=anton@enomsg.org \
--cc=bhe@redhat.com \
--cc=ccross@android.com \
--cc=dyoung@redhat.com \
--cc=feng.tang@intel.com \
--cc=john.ogness@linutronix.de \
--cc=keescook@chromium.org \
--cc=kernel@gpiccoli.net \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=tony.luck@intel.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®